Fix coverity issues

CID-108175, 83324, 83323

Change-Id: Ifd95e507960c062afd313befdccf9a0d62bb4bdb

diff --git a/src/gdbus/mobileap_dbus.c b/src/gdbus/mobileap_dbus.c
index d80c6c8..17ac14f 100644 (file)
--- a/src/gdbus/mobileap_dbus.c
+++ b/src/gdbus/mobileap_dbus.c
@@ -345,10 +345,6 @@ void mobileap_gdbus_register_network_callbacks(networkCallbacks *callbacks)
        if (network_cb)
                return;
 
-       network_cb = g_try_new0(networkCallbacks, 1);
-       if (network_cb == NULL)
-               return;
-
        if (callbacks)
                network_cb = callbacks;
 }

diff --git a/src/mobileap_iptables.c b/src/mobileap_iptables.c
index 927d279..4ac6ad5 100755 (executable)
--- a/src/mobileap_iptables.c
+++ b/src/mobileap_iptables.c
@@ -479,31 +479,31 @@ int _iptables_set_vpn_passthrough_rule(iptables_vpn_passthorugh_e vpn_type, int
                        SERR("command [%s] failed\n", cmd); //LCOV_EXCL_LINE
                        return MOBILE_AP_ERROR_INTERNAL;
                }
-               memset(cmd, '0', sizeof(cmd));
+               memset(cmd, 0, sizeof(cmd));
                snprintf(cmd, sizeof(cmd), "%s -A FORWARD -p udp --dport 10000 --sport 10000 -j %s", IPTABLES, (enable ? "ACCEPT" : "REJECT"));
                if (_execute_command(cmd)) {
                        SERR("command [%s] failed\n", cmd); //LCOV_EXCL_LINE
                        return MOBILE_AP_ERROR_INTERNAL;
                }
-               memset(cmd, '0', sizeof(cmd));
+               memset(cmd, 0, sizeof(cmd));
                snprintf(cmd, sizeof(cmd), "%s -A FORWARD -p tcp --dport 10000 --sport 10000 -j %s", IPTABLES, (enable ? "ACCEPT" : "REJECT"));
                if (_execute_command(cmd)) {
                        SERR("command [%s] failed\n", cmd); //LCOV_EXCL_LINE
                        return MOBILE_AP_ERROR_INTERNAL;
                }
-               memset(cmd, '0', sizeof(cmd));
+               memset(cmd, 0, sizeof(cmd));
                snprintf(cmd, sizeof(cmd), "%s -A FORWARD -p udp --dport 4500 --sport 4500 -j %s", IPTABLES, (enable ? "ACCEPT" : "REJECT"));
                if (_execute_command(cmd)) {
                        SERR("command [%s] failed\n", cmd); //LCOV_EXCL_LINE
                        return MOBILE_AP_ERROR_INTERNAL;
                }
-               memset(cmd, '0', sizeof(cmd));
+               memset(cmd, 0, sizeof(cmd));
                snprintf(cmd, sizeof(cmd), "%s -A FORWARD -p 50 -j %s", IPTABLES, (enable ? "ACCEPT" : "REJECT"));
                if (_execute_command(cmd)) {
                        SERR("command [%s] failed\n", cmd); //LCOV_EXCL_LINE
                        return MOBILE_AP_ERROR_INTERNAL;
                }
-               memset(cmd, '0', sizeof(cmd));
+               memset(cmd, 0, sizeof(cmd));
                snprintf(cmd, sizeof(cmd), "%s -A FORWARD -p 51 -j %s", IPTABLES, (enable ? "ACCEPT" : "REJECT"));
                if (_execute_command(cmd)) {
                        SERR("command [%s] failed\n", cmd); //LCOV_EXCL_LINE

diff --git a/src/mobileap_softap.c b/src/mobileap_softap.c
index 741dd5f..4cf6c97 100755 (executable)
--- a/src/mobileap_softap.c
+++ b/src/mobileap_softap.c
@@ -2074,7 +2074,8 @@ int _get_hw_address(const char *if_name, char **hw_addr)
        }
 
        memset(&ifr, 0, sizeof(ifr));
-       strncpy(ifr.ifr_name, if_name, IFNAMSIZ);
+       strncpy(ifr.ifr_name, if_name, IFNAMSIZ - 1);
+       ifr.ifr_name[IFNAMSIZ - 1] = '\0';
 
        if (ioctl(fd, SIOCGIFHWADDR, &ifr) == -1) {
                ERR("Failed to get MAC address\n"); //LCOV_EXCL_LINE