tbm_surface_queue: forbid a registration of NULL instead of cb functions 60/163160/1
authorRoman Marchenko <r.marchenko@samsung.com>
Thu, 7 Dec 2017 11:26:11 +0000 (13:26 +0200)
committerRoman Marchenko <r.marchenko@samsung.com>
Thu, 7 Dec 2017 11:26:11 +0000 (13:26 +0200)
   It doesn't have sense to add NULL instead of an callback functions.

Change-Id: I038ad279f7fb83dc06f6b7cec41fc7f2ad416c60
Signed-off-by: Roman Marchenko <r.marchenko@samsung.com>
src/tbm_surface_queue.c

index 5dffe12..b722a73 100644 (file)
@@ -650,6 +650,8 @@ tbm_surface_queue_add_destroy_cb(
 
        TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(_tbm_surface_queue_is_valid(surface_queue),
                               TBM_SURFACE_QUEUE_ERROR_INVALID_QUEUE);
+       TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(destroy_cb,
+                              TBM_SURFACE_QUEUE_ERROR_INVALID_PARAMETER);
 
        pthread_mutex_lock(&surface_queue->lock);
 
@@ -696,6 +698,8 @@ tbm_surface_queue_add_dequeuable_cb(
 
        TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(_tbm_surface_queue_is_valid(surface_queue),
                               TBM_SURFACE_QUEUE_ERROR_INVALID_QUEUE);
+       TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(dequeuable_cb,
+                              TBM_SURFACE_QUEUE_ERROR_INVALID_PARAMETER);
 
        pthread_mutex_lock(&surface_queue->lock);
 
@@ -742,6 +746,8 @@ tbm_surface_queue_add_dequeue_cb(
 
        TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(_tbm_surface_queue_is_valid(surface_queue),
                               TBM_SURFACE_QUEUE_ERROR_INVALID_QUEUE);
+       TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(dequeue_cb,
+                              TBM_SURFACE_QUEUE_ERROR_INVALID_PARAMETER);
 
        pthread_mutex_lock(&surface_queue->lock);
 
@@ -788,6 +794,8 @@ tbm_surface_queue_add_can_dequeue_cb(
 
        TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(_tbm_surface_queue_is_valid(surface_queue),
                               TBM_SURFACE_QUEUE_ERROR_INVALID_QUEUE);
+       TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(can_dequeue_cb,
+                              TBM_SURFACE_QUEUE_ERROR_INVALID_PARAMETER);
 
        pthread_mutex_lock(&surface_queue->lock);
 
@@ -834,6 +842,8 @@ tbm_surface_queue_add_acquirable_cb(
 
        TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(_tbm_surface_queue_is_valid(surface_queue),
                               TBM_SURFACE_QUEUE_ERROR_INVALID_QUEUE);
+       TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(acquirable_cb,
+                              TBM_SURFACE_QUEUE_ERROR_INVALID_PARAMETER);
 
        pthread_mutex_lock(&surface_queue->lock);
 
@@ -880,6 +890,8 @@ tbm_surface_queue_add_trace_cb(
 
        TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(_tbm_surface_queue_is_valid(surface_queue),
                               TBM_SURFACE_QUEUE_ERROR_INVALID_QUEUE);
+       TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(trace_cb,
+                              TBM_SURFACE_QUEUE_ERROR_INVALID_PARAMETER);
 
        pthread_mutex_lock(&surface_queue->lock);
 
@@ -1025,6 +1037,8 @@ tbm_surface_queue_add_reset_cb(
 
        TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(_tbm_surface_queue_is_valid(surface_queue),
                               TBM_SURFACE_QUEUE_ERROR_INVALID_QUEUE);
+       TBM_SURF_QUEUE_RETURN_VAL_IF_FAIL(reset_cb,
+                              TBM_SURFACE_QUEUE_ERROR_INVALID_PARAMETER);
 
        pthread_mutex_lock(&surface_queue->lock);