[UTC][vpn-service][Non-ACR][Add new negative TC to check IP error]

utc_vpn_vpnsvc_update_settings_n() tries to update without local &
remote IP address.
In this case, Invalid argument error should be returned instead of IO error.

This patch adds new TC to verify IO error.

Change-Id: I67af451623ef04ce49fb72d39170271d64bd65d6
Signed-off-by: Seonah Moon <seonah1.moon@samsung.com>

diff --git a/src/utc/vpn/tct-vpn-core_mobile.h b/src/utc/vpn/tct-vpn-core_mobile.h
index 20400bf22213d86a2a6dfc835d9da0af98c0dfc0..b2fed47d4a9720e5f98b5052ad0e9d9c86f91bc6 100755 (executable)
--- a/src/utc/vpn/tct-vpn-core_mobile.h
+++ b/src/utc/vpn/tct-vpn-core_mobile.h
@@ -52,7 +52,8 @@ extern int utc_vpn_vpnsvc_set_local_ip_address_n(void);
 extern int utc_vpn_vpnsvc_set_local_ip_address_p(void);
 extern int utc_vpn_vpnsvc_set_remote_ip_address_n(void);
 extern int utc_vpn_vpnsvc_set_remote_ip_address_p(void);
-extern int utc_vpn_vpnsvc_update_settings_n(void);
+extern int utc_vpn_vpnsvc_update_settings_n1(void);
+extern int utc_vpn_vpnsvc_update_settings_n2(void);
 extern int utc_vpn_vpnsvc_update_settings_p(void);
 extern int utc_vpn_vpnsvc_add_route_n(void);
 extern int utc_vpn_vpnsvc_remove_route_n(void);
@@ -90,7 +91,8 @@ testcase tc_array[] = {
        {"utc_vpn_vpnsvc_set_local_ip_address_p",utc_vpn_vpnsvc_set_local_ip_address_p,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_set_remote_ip_address_n",utc_vpn_vpnsvc_set_remote_ip_address_n,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_set_remote_ip_address_p",utc_vpn_vpnsvc_set_remote_ip_address_p,utc_vpn_startup,utc_vpn_cleanup},
-       {"utc_vpn_vpnsvc_update_settings_n",utc_vpn_vpnsvc_update_settings_n,utc_vpn_startup,utc_vpn_cleanup},
+       {"utc_vpn_vpnsvc_update_settings_n1",utc_vpn_vpnsvc_update_settings_n1,utc_vpn_startup,utc_vpn_cleanup},
+       {"utc_vpn_vpnsvc_update_settings_n2",utc_vpn_vpnsvc_update_settings_n2,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_update_settings_p",utc_vpn_vpnsvc_update_settings_p,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_add_route_n",utc_vpn_vpnsvc_add_route_n,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_remove_route_n",utc_vpn_vpnsvc_remove_route_n,utc_vpn_startup,utc_vpn_cleanup},

diff --git a/src/utc/vpn/tct-vpn-core_tizeniot.h b/src/utc/vpn/tct-vpn-core_tizeniot.h
index 20400bf22213d86a2a6dfc835d9da0af98c0dfc0..b2fed47d4a9720e5f98b5052ad0e9d9c86f91bc6 100755 (executable)
--- a/src/utc/vpn/tct-vpn-core_tizeniot.h
+++ b/src/utc/vpn/tct-vpn-core_tizeniot.h
@@ -52,7 +52,8 @@ extern int utc_vpn_vpnsvc_set_local_ip_address_n(void);
 extern int utc_vpn_vpnsvc_set_local_ip_address_p(void);
 extern int utc_vpn_vpnsvc_set_remote_ip_address_n(void);
 extern int utc_vpn_vpnsvc_set_remote_ip_address_p(void);
-extern int utc_vpn_vpnsvc_update_settings_n(void);
+extern int utc_vpn_vpnsvc_update_settings_n1(void);
+extern int utc_vpn_vpnsvc_update_settings_n2(void);
 extern int utc_vpn_vpnsvc_update_settings_p(void);
 extern int utc_vpn_vpnsvc_add_route_n(void);
 extern int utc_vpn_vpnsvc_remove_route_n(void);
@@ -90,7 +91,8 @@ testcase tc_array[] = {
        {"utc_vpn_vpnsvc_set_local_ip_address_p",utc_vpn_vpnsvc_set_local_ip_address_p,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_set_remote_ip_address_n",utc_vpn_vpnsvc_set_remote_ip_address_n,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_set_remote_ip_address_p",utc_vpn_vpnsvc_set_remote_ip_address_p,utc_vpn_startup,utc_vpn_cleanup},
-       {"utc_vpn_vpnsvc_update_settings_n",utc_vpn_vpnsvc_update_settings_n,utc_vpn_startup,utc_vpn_cleanup},
+       {"utc_vpn_vpnsvc_update_settings_n1",utc_vpn_vpnsvc_update_settings_n1,utc_vpn_startup,utc_vpn_cleanup},
+       {"utc_vpn_vpnsvc_update_settings_n2",utc_vpn_vpnsvc_update_settings_n2,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_update_settings_p",utc_vpn_vpnsvc_update_settings_p,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_add_route_n",utc_vpn_vpnsvc_add_route_n,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_remove_route_n",utc_vpn_vpnsvc_remove_route_n,utc_vpn_startup,utc_vpn_cleanup},

diff --git a/src/utc/vpn/tct-vpn-core_wearable.h b/src/utc/vpn/tct-vpn-core_wearable.h
index 20400bf22213d86a2a6dfc835d9da0af98c0dfc0..b2fed47d4a9720e5f98b5052ad0e9d9c86f91bc6 100755 (executable)
--- a/src/utc/vpn/tct-vpn-core_wearable.h
+++ b/src/utc/vpn/tct-vpn-core_wearable.h
@@ -52,7 +52,8 @@ extern int utc_vpn_vpnsvc_set_local_ip_address_n(void);
 extern int utc_vpn_vpnsvc_set_local_ip_address_p(void);
 extern int utc_vpn_vpnsvc_set_remote_ip_address_n(void);
 extern int utc_vpn_vpnsvc_set_remote_ip_address_p(void);
-extern int utc_vpn_vpnsvc_update_settings_n(void);
+extern int utc_vpn_vpnsvc_update_settings_n1(void);
+extern int utc_vpn_vpnsvc_update_settings_n2(void);
 extern int utc_vpn_vpnsvc_update_settings_p(void);
 extern int utc_vpn_vpnsvc_add_route_n(void);
 extern int utc_vpn_vpnsvc_remove_route_n(void);
@@ -90,7 +91,8 @@ testcase tc_array[] = {
        {"utc_vpn_vpnsvc_set_local_ip_address_p",utc_vpn_vpnsvc_set_local_ip_address_p,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_set_remote_ip_address_n",utc_vpn_vpnsvc_set_remote_ip_address_n,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_set_remote_ip_address_p",utc_vpn_vpnsvc_set_remote_ip_address_p,utc_vpn_startup,utc_vpn_cleanup},
-       {"utc_vpn_vpnsvc_update_settings_n",utc_vpn_vpnsvc_update_settings_n,utc_vpn_startup,utc_vpn_cleanup},
+       {"utc_vpn_vpnsvc_update_settings_n1",utc_vpn_vpnsvc_update_settings_n1,utc_vpn_startup,utc_vpn_cleanup},
+       {"utc_vpn_vpnsvc_update_settings_n2",utc_vpn_vpnsvc_update_settings_n2,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_update_settings_p",utc_vpn_vpnsvc_update_settings_p,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_add_route_n",utc_vpn_vpnsvc_add_route_n,utc_vpn_startup,utc_vpn_cleanup},
        {"utc_vpn_vpnsvc_remove_route_n",utc_vpn_vpnsvc_remove_route_n,utc_vpn_startup,utc_vpn_cleanup},

diff --git a/src/utc/vpn/utc-vpn.c b/src/utc/vpn/utc-vpn.c
index d81a4cb8faa03c73b6f6b80d8cdfd41ef86ccf70..68f2fedc6778ce3240200c1a4d47389515b3bf68 100755 (executable)
--- a/src/utc/vpn/utc-vpn.c
+++ b/src/utc/vpn/utc-vpn.c
@@ -1017,12 +1017,12 @@ int utc_vpn_vpnsvc_set_remote_ip_address_p(void)
 }
 
 /**
- * @testcase           utc_vpn_vpnsvc_update_settings_n
+ * @testcase           utc_vpn_vpnsvc_update_settings_n1
  * @since_tizen                3.0
  * @description                vpnsvc_update_settings should fail on Invalid parameter
  * @scenario           check vpnsvc_update_settings by passing invalid parameter
  */
-int utc_vpn_vpnsvc_update_settings_n(void)
+int utc_vpn_vpnsvc_update_settings_n1(void)
 {
        int ret = VPNSVC_ERROR_NONE;
 
@@ -1043,6 +1043,68 @@ int utc_vpn_vpnsvc_update_settings_n(void)
                assert_eq(ret, VPNSVC_ERROR_NOT_SUPPORTED);
                return 0;
        }
+
+       assert_eq(ret, VPNSVC_ERROR_INVALID_PARAMETER);
+       return 0;
+}
+
+/**
+ * @testcase           utc_vpn_vpnsvc_update_settings_n2
+ * @since_tizen                3.0
+ * @description                vpnsvc_update_settings should fail on IO error
+ * @scenario           check vpnsvc_update_settings by passing invalid local & remote IP
+ */
+int utc_vpn_vpnsvc_update_settings_n2(void)
+{
+       int ret = VPNSVC_ERROR_NONE;
+       char *local_ip = "192.168.3.12";
+       char *remote_ip = "192.168.3.32";
+       char *invalid_ip = "224.0.0.0";
+
+       // Local IP is valid but remote IP isn't valid.
+       ret = vpnsvc_set_local_ip_address(g_handle, local_ip);
+       if(g_vpn_supported == false) {
+               assert_eq(ret, VPNSVC_ERROR_NOT_SUPPORTED);
+               return 0;
+       }
+       assert_eq(ret, VPNSVC_ERROR_NONE);
+
+       ret = vpnsvc_set_remote_ip_address(g_handle, invalid_ip);
+       if(g_vpn_supported == false) {
+               assert_eq(ret, VPNSVC_ERROR_NOT_SUPPORTED);
+               return 0;
+       }
+       assert_eq(ret, VPNSVC_ERROR_NONE);
+
+       ret = vpnsvc_update_settings(g_handle);
+       if(g_vpn_supported == false) {
+               assert_eq(ret, VPNSVC_ERROR_NOT_SUPPORTED);
+               return 0;
+       }
+
+       assert_eq(ret, VPNSVC_ERROR_IO_ERROR);
+
+       // Remote IP is valid but local IP isn't valid.
+       ret = vpnsvc_set_local_ip_address(g_handle, invalid_ip);
+       if(g_vpn_supported == false) {
+               assert_eq(ret, VPNSVC_ERROR_NOT_SUPPORTED);
+               return 0;
+       }
+       assert_eq(ret, VPNSVC_ERROR_NONE);
+
+       ret = vpnsvc_set_remote_ip_address(g_handle, remote_ip);
+       if(g_vpn_supported == false) {
+               assert_eq(ret, VPNSVC_ERROR_NOT_SUPPORTED);
+               return 0;
+       }
+       assert_eq(ret, VPNSVC_ERROR_NONE);
+
+       ret = vpnsvc_update_settings(g_handle);
+       if(g_vpn_supported == false) {
+               assert_eq(ret, VPNSVC_ERROR_NOT_SUPPORTED);
+               return 0;
+       }
+
        assert_eq(ret, VPNSVC_ERROR_IO_ERROR);
 
        return 0;