Assert prime_len instead of error check 57/236957/2
authorLukasz Pawelczyk <l.pawelczyk@samsung.com>
Tue, 23 Jun 2020 12:27:00 +0000 (14:27 +0200)
committerLukasz Pawelczyk <l.pawelczyk@samsung.com>
Fri, 26 Jun 2020 15:36:20 +0000 (17:36 +0200)
It's impossible now that it'll be larger than INT_MAX. No need to
check that.

Change-Id: I64bd04d13a46430cef3e969e79b60e2fb8a77e1b

src/key.c

index 17afc7cda26703cb842b14a50b8d837a9a32773b..68def621c082e3664f8028570b8d95f1ba217f02 100644 (file)
--- a/src/key.c
+++ b/src/key.c
@@ -1123,10 +1123,9 @@ static int generate_evp_pkey_params(int evp_id, size_t key_bit_len, EVP_PKEY **p
                        size_t gen_block = key_bit_len & YACA_KEYLEN_COMPONENT_DH_GEN_MASK;
                        size_t prime_len_block = key_bit_len & YACA_KEYLEN_COMPONENT_DH_PRIME_MASK;
 
-                       /* This is impossible now as we take only 16 bits,
-                        * but for the sake of type safety */
-                       if (prime_len_block > INT_MAX)
-                               return YACA_ERROR_INVALID_PARAMETER;
+                       /* This is impossible for now as we take only 16 bits
+                        * but just to be sure for the future */
+                       assert(prime_len_block <= INT_MAX);
                        dh_prime_len = prime_len_block;
 
                        if (gen_block == YACA_KEYLEN_COMPONENT_DH_GEN_2)