Fix a bidirectional UDS connect check typo

The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
bidirectional check that should have checked for mutual WRITE access
between two labels. Due to a typo the second check was incorrect.

Change-Id: I9c9337c9b31bc6247ba4f86017f6112f38cdf9db
Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@samsung.com>

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 6b014de..7a35d98 100644 (file)
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -3302,8 +3302,8 @@ static int smack_unix_stream_connect(struct sock *sock,
                rc = smk_bu_note("UDS connect", skp, okp->smk_known,
                                        MAY_WRITE, rc);
                if (rc == 0) {
-                       rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
-                       rc = smk_bu_note("UDS connect", okp, okp->smk_known,
+                       rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
+                       rc = smk_bu_note("UDS connect", okp, skp->smk_known,
                                                MAY_WRITE, rc);
                }
        }