Fix memory leak 54/189754/1
authorSeonah Moon <seonah1.moon@samsung.com>
Tue, 3 Apr 2018 07:48:20 +0000 (16:48 +0900)
committerYu <jiung.yu@samsung.com>
Thu, 20 Sep 2018 04:41:15 +0000 (13:41 +0900)
Change-Id: If15402affed56d5f5f0a127b4a1cd5d6ef372eca
Signed-off-by: Seonah Moon <seonah1.moon@samsung.com>
packaging/asp-manager.spec
src/tech/asp-tech-infra.c

index 4612d19..e134bc0 100755 (executable)
@@ -1,6 +1,6 @@
 Name:       asp-manager
 Summary:    ASP(application service platform) manager
-Version:    0.0.29
+Version:    0.0.30
 Release:    1
 Group:      Network & Connectivity/Other
 License:    Apache-2.0
index 7167cd4..0b0a543 100644 (file)
@@ -170,6 +170,8 @@ static void _search_result_cb(dnssd_service_state_e service_state,
                } else {
                        ASP_LOGE("TXT records don't contain advertisement ID");
                        g_hash_table_unref(service_info_map);
+                       g_free(service_name);
+                       g_free(txt);
                        return;
                }
 
@@ -179,6 +181,8 @@ static void _search_result_cb(dnssd_service_state_e service_state,
                } else {
                        ASP_LOGE("TXT records don't contain advertisement MAC");
                        g_hash_table_unref(service_info_map);
+                       g_free(service_name);
+                       g_free(txt);
                        return;
                }
 
@@ -188,6 +192,8 @@ static void _search_result_cb(dnssd_service_state_e service_state,
                }
        } else {
                ASP_LOGE("Found service should has at least one TXT record");
+               g_free(service_name);
+               g_free(txt);
                return;
        }
 
@@ -205,6 +211,7 @@ static void _search_result_cb(dnssd_service_state_e service_state,
        g_hash_table_unref(service_info_map);
        g_free(service_device_name);
        g_free(service_mac);
+       g_free(txt);
 }
 
 static gint32 __asp_service_infra_convert_error_type(gint32 dnssd_error)
@@ -256,7 +263,7 @@ static gint32 __add_txt_record(dnssd_service_h handle, const gchar* key, const g
 {
        gint32 result = 0;
        unsigned short txt_length;
-       gpointer txt_data;
+       gpointer txt_data = NULL;
 
        result = dnssd_service_add_txt_record(handle, key, (unsigned short)len, value);
        if (result != DNSSD_ERROR_NONE) {
@@ -277,6 +284,7 @@ static gint32 __add_txt_record(dnssd_service_h handle, const gchar* key, const g
        if (result != DNSSD_ERROR_NONE) {
                ASP_LOGE("Failed to add record");
                result = __asp_service_infra_convert_error_type(result);
+               g_free(txt_data);
                return result;
        }
        ASP_LOGD("Add TXT records");