Removed redundant TODOs 49/87549/4
authorAndrey Klimenko <and.klimenko@samsung.com>
Thu, 8 Sep 2016 12:35:02 +0000 (15:35 +0300)
committerAndrey Klimenko <and.klimenko@samsung.com>
Fri, 9 Sep 2016 13:10:04 +0000 (06:10 -0700)
Change-Id: Icb9f73ef2972eae62a84cc4ebe4c3de74c960e72
Signed-off-by: Andrey Klimenko <and.klimenko@samsung.com>
src/Common/ContactManager/src/ContactManager.cpp
src/Common/MsgEngine/src/MsgEngine.cpp
src/Common/View/src/NaviFrameItem.cpp
src/Common/View/src/View.cpp
src/Conversation/ConvList/Controller/src/BubbleEntityFactory.cpp
src/Conversation/ConvList/Controller/src/ConvList.cpp
src/Viewer/Controller/src/SmilPage.cpp

index 4ead015..646df7e 100644 (file)
 
     ContactPersonNumberRef ContactManager::getContactPersonNumber(int phoneNumId)
     {
-        // TODO: impl cache policy if needed
         contacts_filter_h filter = nullptr;
         contacts_filter_create(_contacts_contact_number._uri, &filter);
         contacts_filter_add_int(filter, _contacts_person_number.number_id, CONTACTS_MATCH_EQUAL, phoneNumId);
 
     void ContactManager::invalidateCache()
     {
-        // TODO: invalidate cache by uri table
         MSG_LOG("");
         m_AddressMap.clear();
         m_OwnerProfile.reset();
index 9ac27c4..1660539 100644 (file)
@@ -24,7 +24,6 @@
 #include "private/MsgSettingsPrivate.h"
 #include "private/MsgComposerPrivate.h"
 #else
- // TODO: msg public headers
 #endif
 
 #include <assert.h>
index 4612721..fd7639b 100644 (file)
@@ -288,7 +288,6 @@ void NaviFrameItem::NaviBar::setColor(NaviColorId id)
 
 void NaviFrameItem::NaviBar::setButtonText(NaviButtonId id, const std::string &text)
 {
-    //TODO: implement text color in edc
     TextStyle style;
 
     switch(m_CurrentColor)
index 7ec00b8..6cfcdd1 100644 (file)
@@ -69,7 +69,6 @@ void View::setEo(Evas_Object *eo)
 {
     if(m_pEo)
     {
-        // TODO: impl. reset EO if nedded
         MSG_LOG_ERROR("m_pEo not null");
         assert(false);
     }
index 31d98f2..6364b13 100644 (file)
@@ -83,7 +83,6 @@ BubbleEntity *BubbleEntityFactory::createEntity(const std::string &filePath, con
         switch(msgMediaType)
         {
             case MsgMedia::ImageType:
-                // TODO: msg service corrupts thumbnail's metadata, so it lost rotation. Use getPath instead getThumbPath until fix
                 return new BubbleImageEntity(filePath, direction);
             case MsgMedia::AudioType:
                 return new BubbleAudioEntity(filePath, fileName, bgType, direction);
index d18e843..ed6c537 100644 (file)
@@ -395,7 +395,7 @@ void ConvList::onMsgStorageInsert(const MsgIdList &msgIdList)
         }
     }
     if(inserted)
-        navigateToBottom(); // TODO: navigate to last inserted message or to compose item ?
+        navigateToBottom();
 }
 
 void ConvList::onMsgStorageDelete(const MsgIdList &msgIdList)
index 13f125e..09d5222 100644 (file)
@@ -130,8 +130,6 @@ void SmilPage::build(const MsgPage &page)
         m_Attachments.push_back(list[i].getFilePath());
     }
 
-    // TODO: image/video, text order
-
     const MsgMedia *video = getMedia(page, MsgMedia::VideoType);
     if(video)
         buildVideo(*video);
@@ -283,7 +281,6 @@ void SmilPage::onSaveButtonClicked(SmilAttachmentItemView &item)
     MSG_LOG("");
     if(FileUtils::saveFileToStorage(item.getFilePath()))
         notification_status_message_post(msg("IDS_MSGF_POP_SAVED_IN_MY_FILES").cStr());
-    // TODO: else
 }
 
 void SmilPage::onItemClicked(SmilSaveAllItemView &item)
@@ -291,6 +288,4 @@ void SmilPage::onItemClicked(SmilSaveAllItemView &item)
     MSG_LOG("");
     if(!m_Attachments.empty() && FileUtils::saveFilesToStorage(m_Attachments))
         notification_status_message_post(msg("IDS_MSGF_POP_SAVED_IN_MY_FILES").cStr());
-    // TODO: else
-
 }