Decreasing duplicate code

Change-Id: I4468953a434515d637d2aa2a40c9c00eabb52d6c
Signed-off-by: Le <xuan.tien@samsung.com>

diff --git a/test/tc-privilege-info.c b/test/tc-privilege-info.c
index 203e504fae0b5f8e467b543e68b4bc2463ad315c..f27b7bf40a6e0bf2a067993b9e5d02aa093d472a 100644 (file)
--- a/test/tc-privilege-info.c
+++ b/test/tc-privilege-info.c
@@ -368,61 +368,40 @@ void __test_privilege_info_get_privacy_list()
 
 void __test_privilege_info_get_privilege_list_by_privacy()
 {
+       int ret = 0;
        GList* privilege_list = NULL;
-       GList* l;
-       printf("privacy : http://tizen.org/privacy/account\n");
-       int ret = privilege_info_get_privilege_list_by_privacy("http://tizen.org/privacy/account", &privilege_list);
-       if (ret == 0) {
-               success_cnt++;
-               for (l = privilege_list; l != NULL; l = l->next) {
-                       char *privilege_name = (char*)l->data;
-                       printf("%s\n", privilege_name);
-               }
-               printf_green("Test SUCCEEDED\n");
-       } else {
-               fail_cnt++;
-               printf_red("Test FAILED\n");
-       }
+       GList* privilege_list_temp = NULL;
 
-       gfree(privilege_list);
+       int expected_results[] = {0, 0, 0};
+       char* privacy_names[] = {
+               "http://tizen.org/privacy/account",
+               "http://tizen.org/privacy/location",
+               "http://tizen.org/privacy/userhistory"
+       };
 
-       __print_line();
+       int num_of_test_cases = sizeof(privacy_names) / sizeof(privacy_names[0]);
 
-       printf("privacy : http://tizen.org/privacy/location\n");
-       ret = privilege_info_get_privilege_list_by_privacy("http://tizen.org/privacy/location", &privilege_list);
-       if (ret == 0) {
-               success_cnt++;
-               for (l = privilege_list; l != NULL; l = l->next) {
-                       char *privilege_name = (char*)l->data;
-                       printf("%s\n", privilege_name);
-               }
-               printf_green("Test SUCCEEDED\n");
-       } else {
-               fail_cnt++;
-               printf_red("Test FAILED\n");
-       }
+       for (int i = 0; i < num_of_test_cases; i++) {
+               printf("privacy : %s\n", privacy_names[i]);
 
-       gfree(privilege_list);
+               ret = privilege_info_get_privilege_list_by_privacy(privacy_names[i], &privilege_list);
 
-       __print_line();
-
-       printf("privacy : http://tizen.org/privacy/userhistory\n");
-       ret = privilege_info_get_privilege_list_by_privacy("http://tizen.org/privacy/userhistory", &privilege_list);
-       if (ret == 0) {
-               success_cnt++;
-               for (l = privilege_list; l != NULL; l = l->next) {
-                       char *privilege_name = (char*)l->data;
-                       printf("%s\n", privilege_name);
+               if (ret == expected_results[i]) {
+                       success_cnt++;
+                       for (privilege_list_temp = privilege_list; privilege_list_temp != NULL; privilege_list_temp = privilege_list_temp->next) {
+                               char *privilege_name = (char*)privilege_list_temp->data;
+                               printf("%s\n", privilege_name);
+                       }
+                       printf_green("Test SUCCEEDED\n");
+               } else {
+                       fail_cnt++;
+                       printf_red("Test FAILED\n");
                }
-               printf_green("Test SUCCEEDED\n");
-       } else {
-               fail_cnt++;
-               printf_red("Test FAILED\n");
-       }
 
-       gfree(privilege_list);
+               gfree(privilege_list);
 
-       __print_line();
+               __print_line();
+       }
 }
 
 void __test_privilege_info_get_privacy_by_privilege()