Fix memory leak issue 45/316045/2
authorInhong Han <inhong1.han@samsung.com>
Thu, 8 Aug 2024 09:30:21 +0000 (18:30 +0900)
committerInhong Han <inhong1.han@samsung.com>
Tue, 13 Aug 2024 01:36:09 +0000 (10:36 +0900)
Change-Id: Ic9df1e29919db51f80fb29358b91ef5360c97be5

client/sticker_dbus.c

index a36cfaa..d0d035b 100644 (file)
@@ -541,9 +541,6 @@ int sticker_dbus_insert_sticker_info(GDBusConnection *gdbus_connection, sticker_
     g_variant_builder_unref(info_builder);
     g_variant_builder_unref(keyword_builder);
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -741,9 +738,6 @@ int sticker_dbus_update_sticker_info(GDBusConnection *gdbus_connection, sticker_
 cleanup:
     sticker_data_destroy(origin_data);
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -765,9 +759,6 @@ int sticker_dbus_get_sticker_info_by_record_id(GDBusConnection *gdbus_connection
 
         g_variant_get(reply_body, "(a{iv}a(s))", &info_iter, &keyword_iter);
         _get_sticker_info_from_gvariant(info_iter, keyword_iter, sticker_data);
-
-        if (reply_body)
-            g_variant_unref(reply_body);
     }
 
     if (reply)
@@ -806,9 +797,6 @@ int sticker_dbus_get_group_list(GDBusConnection *gdbus_connection, const char *a
         g_variant_iter_free(iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -845,9 +833,6 @@ int sticker_dbus_get_keyword_list(GDBusConnection *gdbus_connection, const char
         g_variant_iter_free(iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -866,9 +851,6 @@ int sticker_dbus_get_sticker_count(GDBusConnection *gdbus_connection, const char
         g_variant_get(reply_body, "(i)", count);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -887,9 +869,6 @@ int sticker_dbus_get_all_sticker_info(GDBusConnection *gdbus_connection, const c
         g_variant_get(reply_body, "(a(i))", id_iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -908,9 +887,6 @@ int sticker_dbus_get_sticker_info_by_appid(GDBusConnection *gdbus_connection, co
         g_variant_get(reply_body, "(a(i))", id_iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -929,9 +905,6 @@ int sticker_dbus_get_sticker_info_by_type(GDBusConnection *gdbus_connection, con
         g_variant_get(reply_body, "(a(i))", id_iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -950,9 +923,6 @@ int sticker_dbus_get_sticker_info_by_group(GDBusConnection *gdbus_connection, co
         g_variant_get(reply_body, "(a(i))", id_iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -971,9 +941,6 @@ int sticker_dbus_get_sticker_info_by_keyword(GDBusConnection *gdbus_connection,
         g_variant_get(reply_body, "(a(i))", id_iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -992,9 +959,6 @@ int sticker_dbus_get_sticker_info_by_display_type(GDBusConnection *gdbus_connect
         g_variant_get(reply_body, "(a(i))", id_iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -1031,9 +995,6 @@ int sticker_dbus_get_group_list_by_display_type(GDBusConnection *gdbus_connectio
         g_variant_iter_free(iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -1052,9 +1013,6 @@ int sticker_dbus_check_file_exists(GDBusConnection *gdbus_connection, const char
         g_variant_get(reply_body, "(i)", result);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -1088,9 +1046,6 @@ int sticker_dbus_get_recent_sticker_list(GDBusConnection *gdbus_connection, int
         g_variant_get(reply_body, "(a(i))", id_iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -1110,9 +1065,6 @@ int sticker_dbus_get_sticker_info_by_uri(GDBusConnection *gdbus_connection, stic
         reply_body = g_dbus_message_get_body(reply);
         g_variant_get(reply_body, "(a{iv}a(s))", &info_iter, &keyword_iter);
         _get_sticker_info_from_gvariant(info_iter, keyword_iter, sticker_data);
-
-        if (reply_body)
-            g_variant_unref(reply_body);
     }
 
     if (reply)
@@ -1133,9 +1085,6 @@ int sticker_dbus_check_group_exists(GDBusConnection *gdbus_connection, const cha
         g_variant_get(reply_body, "(i)", result);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);
 
@@ -1205,9 +1154,6 @@ int sticker_dbus_get_group_image_list(GDBusConnection *gdbus_connection, const c
         g_variant_iter_free(iter);
     }
 
-    if (reply_body)
-        g_variant_unref(reply_body);
-
     if (reply)
         g_object_unref(reply);