Fix some file descriptor leaks

Change-Id: I1bb8cc2580ca208cc8387a84528d9a60e6909cd3

diff --git a/src/crash-json2info/crash-json2info.c b/src/crash-json2info/crash-json2info.c
index 213a316..b761ada 100644 (file)
--- a/src/crash-json2info/crash-json2info.c
+++ b/src/crash-json2info/crash-json2info.c
@@ -81,6 +81,8 @@ int main(int argc, char *argv[])
                switch(c) {
                case 'o':
                case OPT_OUTPUT_FILE:
+                       if (fp_output != stdout)
+                               fclose(fp_output);
                        fp_output = fopen(optarg, "w");
                        break;
                case 'h':

diff --git a/src/crash-stack/crash-stack.c b/src/crash-stack/crash-stack.c
index 48db99d..16b0e5b 100644 (file)
--- a/src/crash-stack/crash-stack.c
+++ b/src/crash-stack/crash-stack.c
@@ -633,9 +633,13 @@ int main(int argc, char **argv)
                        signo = atoi(optarg);
                        break;
                case OPT_OUTPUTFILE:
+                       if (outputfile)
+                               fclose(outputfile);
                        outputfile = fopen(optarg, "w");
                        break;
                case OPT_JSONOUTPUTFILE:
+                       if (jsonoutputfile)
+                               fclose(jsonoutputfile);
                        jsonoutputfile = fopen(optarg, "w");
                        break;
                case OPT_PRSTATUS_FD: