libdevman: check return values for IO apis 39/55739/2
authorTaeyoung Kim <ty317.kim@samsung.com>
Tue, 29 Dec 2015 05:56:36 +0000 (14:56 +0900)
committerTaeyoung Kim <ty317.kim@samsung.com>
Thu, 31 Dec 2015 05:53:22 +0000 (14:53 +0900)
Change-Id: I2e54606ad44b75d0b6cd40666009d98b786dfda0
Signed-off-by: Taeyoung Kim <ty317.kim@samsung.com>
src/libdevman/src/devman_internal.c
src/libdevman/src/display_wd.c

index 64bb629..b2a53dc 100644 (file)
@@ -90,7 +90,9 @@ API int display_register_postjob(void)
                unlink(fifo_path);
                return -1;
        }
-       read(fifo_pollfd.fd, buf, sizeof(buf));
+       ret = read(fifo_pollfd.fd, buf, sizeof(buf));
+       if (ret < 0)
+               DEVERR("read() failed (%d)", ret);
 
        fifo_fd = fifo_pollfd.fd;
 
@@ -100,7 +102,7 @@ API int display_register_postjob(void)
 API int display_cancel_postjob(void)
 {
        char buf[PATH_MAX];
-       int ret;
+       int ret, disp;
 
        snprintf(buf, PATH_MAX, "%s.%d", DISPLAY_WD_FIFO, getpid());
        if (access(buf, F_OK) != 0) {
@@ -115,8 +117,10 @@ API int display_cancel_postjob(void)
                DEVLOG("fifo file path is %s", buf);
                return -1;
        }
-       ret = DISPLAY_WD_CANCEL;
-       write(fifo_fd, &ret, sizeof(int));
+       disp = DISPLAY_WD_CANCEL;
+       ret = write(fifo_fd, &disp, sizeof(int));
+       if (ret <= 0)
+               DEVERR("write() failed (%d)", ret);
        close(fifo_fd);
        unlink(buf);
        fifo_fd = -1;
index 52b5f6d..e1e10e8 100644 (file)
@@ -47,7 +47,7 @@ static void sig_quit(int signo)
 
 int main(void)
 {
-       int fd = -1;
+       int r = -1;
        int ret = -1;
        int val = -1;
        int auto_brightness_state = -1;
@@ -87,7 +87,9 @@ int main(void)
                        return -1;
                }
                if (fifo_pollfd.revents & POLLIN) {
-                       read(fifo_pollfd.fd, &ret, sizeof(int));
+                       r = read(fifo_pollfd.fd, &ret, sizeof(int));
+                       if (r < 0)
+                               DEVERR("read() failed(%d)", r);
                        if (ret == DISPLAY_WD_CANCEL) {
                                DEVERR("[DISPLAY_WD] Canceled. - %s, %d", fifo_path, ret);
                                close(fifo_pollfd.fd);