Apply consistent log messages.

1. First letter to uppercase.
2. Period at the end.
3. Rearrange parameters.

Change-Id: I5fd9968f4a0ec22a6c4f2e88f355e72238fd4233
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>

diff --git a/signal-sender/signal-sender.c b/signal-sender/signal-sender.c
index ec2a1a3..8a7d979 100644 (file)
--- a/signal-sender/signal-sender.c
+++ b/signal-sender/signal-sender.c
@@ -80,7 +80,7 @@ static int append_variant(DBusMessageIter *iter, const char *sig, char *param[])
                        dbus_message_iter_append_basic(iter, DBUS_TYPE_INT32, &int_type);
                        break;
                default:
-                       _E("ERROR: %s %c", sig, *ch);
+                       _E("Failed to append. signal=%s ch=%c", sig, *ch);
                        return -EINVAL;
                }
        }
@@ -143,13 +143,13 @@ int call_dbus_method_for_pairs(const char *dest, const char *path,
        conn = dbus_bus_get(DBUS_BUS_SYSTEM, NULL);
        if (!conn) {
                ret = 0;
-               _E("dbus_bus_get error");
+               _E("Failed to dbus_bus_get.");
                return -EPERM;
        }
 
        msg = dbus_message_new_method_call(dest, path, interface, method);
        if (!msg) {
-               _E("dbus_message_new_method_call(%s:%s-%s)", path, interface, method);
+               _E("Failed to dbus_message_new_method_call(%s:%s-%s).", path, interface, method);
                return -EBADMSG;
        }
 
@@ -158,7 +158,7 @@ int call_dbus_method_for_pairs(const char *dest, const char *path,
        for (i = 0 ; i < size ; i = i + 2) {
                key = param[i];
                value = param[i+1];
-               _I("key(%s), value(%s)", key, value);
+               _I("key=%s value=%s", key, value);
                dbus_message_iter_open_container(&aiter, DBUS_TYPE_DICT_ENTRY, NULL, &piter);
                dbus_message_iter_append_basic(&piter, DBUS_TYPE_STRING, &key);
                dbus_message_iter_append_basic(&piter, DBUS_TYPE_STRING, &value);
@@ -171,7 +171,7 @@ int call_dbus_method_for_pairs(const char *dest, const char *path,
        reply = dbus_connection_send_with_reply_and_block(conn, msg, DBUS_REPLY_TIMEOUT, &err);
        dbus_message_unref(msg);
        if (!reply) {
-               _E("dbus_connection_send error(%s:%s) %s %s:%s-%s", err.name, err.message, dest, path, interface, method);
+               _E("Failed to dbus_connection_send. dest=%s %s:%s-%s. err.name=%s: %s", dest, path, interface, method, err.name, err.message);
                dbus_error_free(&err);
                return -ECOMM;
        }
@@ -179,7 +179,7 @@ int call_dbus_method_for_pairs(const char *dest, const char *path,
        ret = dbus_message_get_args(reply, &err, DBUS_TYPE_INT32, &result, DBUS_TYPE_INVALID);
        dbus_message_unref(reply);
        if (!ret) {
-               _E("no message : [%s:%s] %s %s:%s-%s", err.name, err.message, dest, path, interface, method);
+               _E("No message dest=%s %s:%s-%s. err.name=%s: %s", dest, path, interface, method, err.name, err.message);
                dbus_error_free(&err);
                return -ENOMSG;
        }
@@ -202,14 +202,14 @@ int request_to_launch_by_dbus(char *bus, char *path, char *iface,
                i++;
        } while (i < RETRY_MAX);
        if (!msg) {
-               _E("fail to call dbus method");
+               _E("Failed to call dbus method.");
                return -ECONNREFUSED;
        }
 
        dbus_error_init(&err);
        r = dbus_message_get_args(msg, &err, DBUS_TYPE_INT32, &ret_val, DBUS_TYPE_INVALID);
        if (!r) {
-               _E("no message : [%s:%s]", err.name, err.message);
+               _E("No message. err.name=%s: %s", err.name, err.message);
                ret_val = -EBADMSG;
        }
 
@@ -275,13 +275,13 @@ static int get_err_and_space(bundle *b, char *type,
 
        cErr = (char *)bundle_get_val(b, SIGNAL_SENDER_ERROR_TYPE);
        if (!cErr) {
-               _E("Failed to get error type");
+               _E("Failed to get error type.");
                return -ENOMEM;
        }
 
        spc = (char *)bundle_get_val(b, SIGNAL_SENDER_MEMORY_SPACE);
        if (!spc) {
-               _E("Failed to get memory space");
+               _E("Failed to get memory space.");
                return -ENOMEM;
        }
 
@@ -294,7 +294,7 @@ static int get_err_and_space(bundle *b, char *type,
                snprintf(error, error_len, "%s_operation_failed", type);
                break;
        default:
-               _E("Unknown type (%d)", iErr);
+               _E("Unknown type: %d", iErr);
                return -EINVAL;
        }
 
@@ -351,7 +351,7 @@ static int load_ode_setting_ug(void)
        ret = aul_launch_app(setting_ug, b);
        bundle_free(b);
        if (ret <= 0) {
-               _E("Failed to launch app (%s)(%d)", setting_ug, ret);
+               _E("Failed to launch app(%s): %d", setting_ug, ret);
                return ret;
        }
 
@@ -391,7 +391,7 @@ static int app_reset(bundle *b, void *data)
 
        type = (char *)bundle_get_val(b, SIGNAL_SENDER_TYPE);
        if (!type) {
-               _E("FAIL: bundle_get_val()");
+               _E("Failed to bundle_get_val().");
                ret = -ENOMEM;
                goto out;
        }
@@ -405,7 +405,7 @@ static int app_reset(bundle *b, void *data)
                                strlen(SIGNAL_SENDER_TYPE_USBSTORAGE_UNMOUNT))) {
                path = (char *)bundle_get_val(b, "_DEVICE_PATH_");
                if (!path) {
-                       _E("FAIL: bundle_get_val()");
+                       _E("Failed to bundle_get_val().");
                        ret = -ENOMEM;
                        goto out;
                }

diff --git a/src/battery/battery-mobile.c b/src/battery/battery-mobile.c
index 0d55887..646df45 100644 (file)
--- a/src/battery/battery-mobile.c
+++ b/src/battery/battery-mobile.c
@@ -40,14 +40,14 @@ static int remove_other_charge_popups(bundle *b, const struct popup_ops *ops);
 
 static void remove_other_lowbattery_popups(const struct popup_ops *ops)
 {
-       _D("remove_other_lowbattery_popups() is finished");
+       _D("remove_other_lowbattery_popups() is finished.");
        if (ops != &lowbattery_poweroff_ops)
                unload_simple_popup(&lowbattery_poweroff_ops);
 }
 
 static int remove_other_charge_popups(bundle *b, const struct popup_ops *ops)
 {
-       _D("remove_other_charge_popups() is finished");
+       _D("remove_other_charge_popups() is finished.");
        if (ops != &charge_error_low_ops)
                unload_simple_popup(&charge_error_low_ops);
 
@@ -65,14 +65,14 @@ static void charger_status_changed(keynode_t *key, void *data)
        int status;
        const struct popup_ops *ops = data;
 
-       _D("charger_status_changed() is finished");
+       _D("charger_status_changed() is finished.");
        status = vconf_keynode_get_int(key);
        if (status != VCONFKEY_SYSMAN_CHARGER_CONNECTED)
                return;
 
        if (vconf_ignore_key_changed(VCONFKEY_SYSMAN_CHARGER_STATUS,
                                charger_status_changed) < 0)
-               _E("Failed to release vconf key handler");
+               _E("Failed to release vconf key handler.");
 
        unload_simple_popup(ops);
 
@@ -90,7 +90,7 @@ static void battery_status_changed(keynode_t *key, void *data)
 
        if (vconf_ignore_key_changed(VCONFKEY_SYSMAN_BATTERY_LEVEL_STATUS,
                                battery_status_changed) < 0)
-               _E("Failed to release vconf key handler");
+               _E("Failed to release vconf key handler.");
 
        unload_simple_popup(ops);
 
@@ -114,14 +114,14 @@ static void register_charger_status_handler(const struct popup_ops *ops)
 {
        if (vconf_notify_key_changed(VCONFKEY_SYSMAN_CHARGER_STATUS,
                                charger_status_changed, (void *)ops) < 0)
-               _E("Failed to register vconf key handler");
+               _E("Failed to register vconf key handler.");
 }
 
 static void register_battery_status_handler(const struct popup_ops *ops)
 {
        if (vconf_notify_key_changed(VCONFKEY_SYSMAN_BATTERY_LEVEL_STATUS,
                                battery_status_changed, (void *)ops) < 0)
-               _E("Failed to register vconf key handler");
+               _E("Failed to register vconf key handler.");
 }
 
 static int lowbattery_launch(bundle *b, const struct popup_ops *ops)
@@ -163,27 +163,27 @@ static void poweroff_clicked(const struct popup_ops *ops)
                        REBOOT_METHOD,
                        "si", param);
        if (ret < 0)
-               _E("Failed to request poweroff to deviced (%d)", ret);
+               _E("Failed to request poweroff to deviced: %d", ret);
 
 }
 
 static void charge_error_ok_clicked(const struct popup_ops *ops)
 {
-       _I("OK is selected");
+       _I("OK is selected.");
        unload_simple_popup(ops);
 
        if (broadcast_dbus_signal(DEVICED_PATH_SYSNOTI,
                                DEVICED_INTERFACE_SYSNOTI,
                                SIGNAL_CHARGEERR_RESPONSE,
                                NULL, NULL) < 0)
-               _E("Failed to send signal");
+               _E("Failed to send signal.");
 
        terminate_if_no_popup();
 }
 
 static int remove_battery_popups(bundle *b, const struct popup_ops *ops)
 {
-       _I("Remove battery related popups");
+       _I("Remove battery related popups.");
        unload_simple_popup(&lowbattery_poweroff_ops);
        unload_simple_popup(&charge_error_low_ops);
        unload_simple_popup(&charge_error_high_ops);

diff --git a/src/battery/battery-wearable.c b/src/battery/battery-wearable.c
index b3b318b..75df768 100644 (file)
--- a/src/battery/battery-wearable.c
+++ b/src/battery/battery-wearable.c
@@ -70,7 +70,7 @@ static void charger_status_changed(keynode_t *key, void *data)
 
        if (vconf_ignore_key_changed(VCONFKEY_SYSMAN_CHARGER_STATUS,
                                charger_status_changed) < 0)
-               _E("Failed to release vconf key handler");
+               _E("Failed to release vconf key handler.");
 
        unload_simple_popup(ops);
 
@@ -88,7 +88,7 @@ static void battery_status_changed(keynode_t *key, void *data)
 
        if (vconf_ignore_key_changed(VCONFKEY_SYSMAN_BATTERY_LEVEL_STATUS,
                                battery_status_changed) < 0)
-               _E("Failed to release vconf key handler");
+               _E("Failed to release vconf key handler.");
 
        unload_simple_popup(ops);
 
@@ -111,14 +111,14 @@ static void register_charger_status_handler(const struct popup_ops *ops)
 {
        if (vconf_notify_key_changed(VCONFKEY_SYSMAN_CHARGER_STATUS,
                                charger_status_changed, (void *)ops) < 0)
-               _E("Failed to register vconf key handler");
+               _E("Failed to register vconf key handler.");
 }
 
 static void register_battery_status_handler(const struct popup_ops *ops)
 {
        if (vconf_notify_key_changed(VCONFKEY_SYSMAN_BATTERY_LEVEL_STATUS,
                                battery_status_changed, (void *)ops) < 0)
-               _E("Failed to register vconf key handler");
+               _E("Failed to register vconf key handler.");
 }
 
 static int lowbattery_launch(bundle *b, const struct popup_ops *ops)
@@ -160,26 +160,26 @@ static void poweroff_clicked(const struct popup_ops *ops)
                        REBOOT_METHOD,
                        "si", param);
        if (ret < 0)
-               _E("Failed to request poweroff to deviced (%d)", ret);
+               _E("Failed to request poweroff to deviced: %d", ret);
 }
 
 static void charge_error_ok_clicked(const struct popup_ops *ops)
 {
-       _I("OK is selected");
+       _I("OK is selected.");
        unload_simple_popup(ops);
 
        if (broadcast_dbus_signal(DEVICED_PATH_SYSNOTI,
                                DEVICED_INTERFACE_SYSNOTI,
                                SIGNAL_CHARGEERR_RESPONSE,
                                NULL, NULL) < 0)
-               _E("Failed to send signal");
+               _E("Failed to send signal.");
 
        terminate_if_no_popup();
 }
 
 static int remove_battery_popups(bundle *b, const struct popup_ops *ops)
 {
-       _I("Remove battery related popups");
+       _I("Remove battery related popups.");
        unload_simple_popup(&lowbattery_poweroff_ops);
        unload_simple_popup(&charge_error_low_ops);
        unload_simple_popup(&charge_error_high_ops);

diff --git a/src/common/core.c b/src/common/core.c
index 09c32b9..07dd2ad 100644 (file)
--- a/src/common/core.c
+++ b/src/common/core.c
@@ -35,13 +35,13 @@ void register_popup(const struct popup_ops *ops)
        struct object_ops *obj;
 
        if (!ops) {
-               _E("Invalid parameter");
+               _E("Invalid parameter.");
                return;
        }
 
        obj = (struct object_ops *)calloc(1, sizeof(struct object_ops));
        if (!obj) {
-               _E("calloc() fialed");
+               _E("Failed to calloc().");
                return;
        }
 
@@ -72,7 +72,7 @@ void terminate_if_no_popup(void)
        for (l = popup_list ; l ; l = g_list_next(l)) {
                obj = (struct object_ops *)(l->data);
                if (obj->popup) {
-                       _I("popup exists(%s)", obj->ops->name);
+                       _I("Popup(%s) exists.", obj->ops->name);
                        return;
                }
        }
@@ -91,7 +91,7 @@ static int load_popup_by_type(bundle *b)
 
        type = (char *)bundle_get_val(b, SYSPOPUP_CONTENT);
        if (!type) {
-               _E("FAIL: bundle_get_val()");
+               _E("Failed to bundle_get_val().");
                return -ENOMEM;
        }
 
@@ -171,11 +171,11 @@ static int app_create(void *data)
        app_info = (appdata_s *)data;
 
        if (appcore_set_i18n(LANG_DOMAIN, LOCALE_DIR) != 0)
-               _E("FAIL: appcore_set_i18n()");
+               _E("Failed to appcore_set_i18n().");
 
        ret = set_dbus_connection();
        if (ret < 0)
-               _E("Failed to set dbus connection (%d)", ret);
+               _E("Failed to set dbus connection: %d", ret);
 
        if (!feedback_init_processed) {
                init_multi_feedback();
@@ -234,7 +234,7 @@ static int app_reset(bundle *b, void *data)
 
                ret = syspopup_create(b, &handler, win, NULL);
                if (ret < 0) {
-                       _E("FAIL: syspopup_create(): %d", ret);
+                       _E("Failed to syspopup_create(): %d", ret);
                        goto out;
                }
 

diff --git a/src/common/popup-common.c b/src/common/popup-common.c
index 3d38111..dc82434 100644 (file)
--- a/src/common/popup-common.c
+++ b/src/common/popup-common.c
@@ -48,7 +48,7 @@ void play_feedback(int type, int pattern)
 
        ret = feedback_initialize();
        if (ret != FEEDBACK_ERROR_NONE) {
-               _E("Cannot initialize feedback");
+               _E("Cannot initialize feedback.");
                return;
        }
 
@@ -61,15 +61,15 @@ void play_feedback(int type, int pattern)
                ret = feedback_play(pattern);
                break;
        default:
-               _E("Play type is unknown");
+               _E("Play type is unknown.");
                ret = 0;
        }
        if (ret != FEEDBACK_ERROR_NONE)
-               _E("Cannot play feedback: %d", pattern);
+               _E("Cannot play feedback(%d).", pattern);
 
        ret = feedback_deinitialize();
        if (ret != FEEDBACK_ERROR_NONE)
-               _E("Cannot deinitialize feedback");
+               _E("Cannot deinitialize feedback.");
 }
 
 void init_multi_feedback(void)
@@ -78,7 +78,7 @@ void init_multi_feedback(void)
 
        ret = feedback_initialize();
        if (ret != FEEDBACK_ERROR_NONE)
-               _E("Cannot initialize feedback");
+               _E("Cannot initialize feedback.");
 }
 
 void play_multi_feedback(int pattern)
@@ -87,7 +87,7 @@ void play_multi_feedback(int pattern)
 
        ret = feedback_play(pattern);
        if (ret != FEEDBACK_ERROR_NONE)
-               _E("Cannot play feedback: %d", pattern);
+               _E("Cannot play feedback(%d).", pattern);
 }
 
 void stop_multi_feedback(void)
@@ -96,7 +96,7 @@ void stop_multi_feedback(void)
 
        ret = feedback_deinitialize();
        if (ret != FEEDBACK_ERROR_NONE)
-               _E("Cannot deinitialize feedback");
+               _E("Cannot deinitialize feedback.");
 }
 
 static void *thread_feedback(void* data)
@@ -111,7 +111,7 @@ static void *thread_feedback(void* data)
 static void *thread_display(void* data)
 {
        if (display_change_state(LCD_NORMAL) < 0)
-               _E("FAIL: display_change_state()");
+               _E("Failed to display_change_state().");
        return NULL;
 }
 
@@ -122,7 +122,7 @@ static void start_thread(void *(*operation)(void *), void *data)
 
        ret = pthread_create(&th, NULL, operation, data);
        if (ret < 0) {
-               _E("Failed to create pthread(%d)", ret);
+               _E("Failed to create pthread: %d", ret);
                return;
        }
        pthread_detach(th);
@@ -155,7 +155,7 @@ int set_dbus_connection(void)
 
        edbus_conn = e_dbus_bus_get(DBUS_BUS_SYSTEM);
        if (!edbus_conn) {
-               _E("Failed to get dbus bus");
+               _E("Failed to get dbus bus.");
                e_dbus_shutdown();
                return -ENOMEM;
        }
@@ -216,26 +216,26 @@ int broadcast_dbus_signal(const char *path, const char *interface,
 
        conn = get_dbus_connection();
        if (!conn) {
-               _E("Failed to get dbus connection");
+               _E("Failed to get dbus connection.");
                return -ENOMEM;
        }
 
        msg = dbus_message_new_signal(path, interface, name);
        if (!msg) {
-               _E("FAIL: dbus_message_new_signal()");
+               _E("Failed to dbus_message_new_signal().");
                return -ENOMEM;
        }
 
        dbus_message_iter_init_append(msg, &iter);
        ret = append_variant(&iter, sig, param);
        if (ret < 0) {
-               _E("append_variant error(%d)", ret);
+               _E("Failed to append_variant: %d", ret);
                goto out;
        }
 
        pc = e_dbus_message_send(conn, msg, NULL, -1, NULL);
        if (!pc) {
-               _E("FAIL: e_dbus_message_send()");
+               _E("Failed to e_dbus_message_send().");
                ret = -ECONNREFUSED;
                goto out;
        }
@@ -260,13 +260,13 @@ int popup_dbus_method_sync(const char *dest, const char *path,
 
        conn = dbus_bus_get(DBUS_BUS_SYSTEM, NULL);
        if (!conn) {
-               _E("dbus_bus_get error");
+               _E("Failed to dbus_bus_get.");
                return -EPERM;
        }
 
        msg = dbus_message_new_method_call(dest, path, interface, method);
        if (!msg) {
-               _E("dbus_message_new_method_call(%s:%s-%s)",
+               _E("dbus_message_new_method_call(%s:%s-%s).",
                                path, interface, method);
                ret = -EBADMSG;
                goto out;
@@ -275,7 +275,7 @@ int popup_dbus_method_sync(const char *dest, const char *path,
        dbus_message_iter_init_append(msg, &iter);
        ret = append_variant(&iter, sig, param);
        if (ret < 0) {
-               _E("append_variant error(%d)", ret);
+               _E("Failed to append_variant: %d", ret);
                goto out;
        }
 
@@ -293,7 +293,7 @@ int popup_dbus_method_sync(const char *dest, const char *path,
        ret = dbus_message_get_args(reply, &err,
                        DBUS_TYPE_INT32, &result, DBUS_TYPE_INVALID);
        if (!ret) {
-               _E("no message : [%s:%s]", err.name, err.message);
+               _E("No message. err.name=%s: %s", err.name, err.message);
                dbus_error_free(&err);
                ret = -ENOMSG;
                goto out;
@@ -320,7 +320,7 @@ void unregister_dbus_signal_handler(E_DBus_Signal_Handler *handler)
 
        conn = get_dbus_connection();
        if (!conn) {
-               _E("Failed to get dbus connection");
+               _E("Failed to get dbus connection.");
                return;
        }
 
@@ -343,7 +343,7 @@ int register_dbus_signal_handler(
 
        conn = get_dbus_connection();
        if (!conn) {
-               _E("Failed to get dbus connection");
+               _E("Failed to get dbus connection.");
                return -ENOMEM;
        }
 

diff --git a/src/common/popup-ui-circle.c b/src/common/popup-ui-circle.c
index f2c2e53..ca5b7f5 100644 (file)
--- a/src/common/popup-ui-circle.c
+++ b/src/common/popup-ui-circle.c
@@ -53,7 +53,7 @@ int load_normal_popup(const struct popup_ops *ops)
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -EINVAL;
        }
 

diff --git a/src/common/popup-ui-normal.c b/src/common/popup-ui-normal.c
index 3459f5e..edf7edf 100644 (file)
--- a/src/common/popup-ui-normal.c
+++ b/src/common/popup-ui-normal.c
@@ -28,7 +28,7 @@ void event_back_key_up(void *data, Evas_Object *obj, void *event_info)
 
        win = get_window();
        if (win) {
-               _D("unregister event back key, ops->name=%s", ops->name);
+               _D("Unregister event back key. ops->name=%s", ops->name);
                eext_object_event_callback_del(obj, EEXT_CALLBACK_BACK, event_back_key_up);
 }
 
@@ -53,7 +53,7 @@ int load_normal_popup(const struct popup_ops *ops)
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -EINVAL;
        }
 

diff --git a/src/common/popup-ui.c b/src/common/popup-ui.c
index 5525797..b0f6a68 100644 (file)
--- a/src/common/popup-ui.c
+++ b/src/common/popup-ui.c
@@ -61,7 +61,7 @@ int create_window(const char *name)
 
        eo = elm_win_add(NULL, name, ELM_WIN_BASIC);
        if (!eo) {
-               _E("FAIL: elm_win_add()");
+               _E("Failed to elm_win_add().");
                return -ENOMEM;;
        }
 
@@ -166,7 +166,7 @@ int load_simple_popup(bundle *b, const struct popup_ops *ops)
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -ENOENT;
        }
        obj->b = bundle_dup(b);

diff --git a/src/cooldown/cooldown-mobile.c b/src/cooldown/cooldown-mobile.c
index d75bf1a..ed678f9 100644 (file)
--- a/src/cooldown/cooldown-mobile.c
+++ b/src/cooldown/cooldown-mobile.c
@@ -37,7 +37,7 @@ static int remove_cooldown_popups(bundle *b, const struct popup_ops *ops)
 static int remove_other_cooldown_popups(bundle *b, const struct popup_ops *ops)
 {
        if (!ops) {
-               _E("Invalid removal request for cooldown");
+               _E("Invalid removal request for cooldown.");
                return 0;
        }
 

diff --git a/src/cooldown/cooldown-wearable.c b/src/cooldown/cooldown-wearable.c
index 317c2f7..82815f6 100644 (file)
--- a/src/cooldown/cooldown-wearable.c
+++ b/src/cooldown/cooldown-wearable.c
@@ -146,7 +146,7 @@ static int add_dbus_signal_handler(const struct popup_ops *ops)
 
        conn = get_dbus_connection();
        if (!conn) {
-               _E("Failed to get dbus connection");
+               _E("Failed to get dbus connection.");
                return -ENOMEM;
        }
 
@@ -159,7 +159,7 @@ static int add_dbus_signal_handler(const struct popup_ops *ops)
                        (void *)ops);
 
        if (!release_handler) {
-               _E("Failed to add signal handler");
+               _E("Failed to add signal handler.");
                return -ENOMEM;
        }
 
@@ -189,7 +189,7 @@ static void cooldown_send_warning_signal(const struct popup_ops *ops)
                        SIGNAL_COOL_DOWN_RESPONSE,
                        NULL, NULL);
        if (ret < 0)
-               _E("Failed to broadcast signal(%d)", ret);
+               _E("Failed to broadcast signal: %d", ret);
 }
 
 static void cooldown_poweroff(const struct popup_ops *ops)
@@ -198,7 +198,7 @@ static void cooldown_poweroff(const struct popup_ops *ops)
        char data[8];
        int ret;
 
-       _I("Poweroff is selected");
+       _I("Poweroff is selected.");
        unload_simple_popup(ops);
 
        param[0] = REBOOT_OPERATION_OFF;
@@ -212,7 +212,7 @@ static void cooldown_poweroff(const struct popup_ops *ops)
                        "si", param);
 
        if (ret < 0)
-               _E("Failed to request poweroff to deviced (%d)", ret);
+               _E("Failed to request poweroff to deviced: %d", ret);
 }
 
 static void cooldown_poweroff_terminate(const struct popup_ops *ops)
@@ -222,7 +222,7 @@ static void cooldown_poweroff_terminate(const struct popup_ops *ops)
 
 static void cooldown_warning(const struct popup_ops *ops)
 {
-       _I("Warning is selected");
+       _I("Warning is selected.");
 
        unload_simple_popup(ops);
 }
@@ -250,7 +250,7 @@ static Eina_Bool beep_time_expired(void *data)
 
        timer = ecore_timer_add(beep[index].timeout, beep_time_expired, ops);
        if (!timer)
-               _E("Failed to add timer");
+               _E("Failed to add timer.");
 
        notify_feedback(beep[index].type);
 
@@ -269,11 +269,11 @@ static int cooldown_warning_timer(bundle *b, const struct popup_ops *ops)
        timer = ecore_timer_add(TIMEOUT_BEEP_40, beep_time_expired, ops);
 
        if (!timer)
-               _E("Failed to add timer");
+               _E("Failed to add timer.");
 
        ret = add_dbus_signal_handler(ops);
        if (ret < 0)
-               _E("Failed to add dbus handler(%d)", ret);
+               _E("Failed to add dbus handler: %d", ret);
 
        return 0;
 }
@@ -295,7 +295,7 @@ static int cooldown_poweroff_timer(bundle *b, const struct popup_ops *ops)
 
        timer = ecore_timer_add(TIMEOUT_POWEROFF, poweroff_time_expired, ops);
        if (!timer)
-               _E("Failed to add timer");
+               _E("Failed to add timer.");
 
        return 0;
 }
@@ -335,7 +335,7 @@ int cooldown_warning_show(bundle *b, const struct popup_ops *ops)
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -EINVAL;
        }
 
@@ -409,7 +409,7 @@ int cooldown_poweroff_show(bundle *b, const struct popup_ops *ops)
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -EINVAL;
        }
 

diff --git a/src/crash/crash.c b/src/crash/crash.c
index 56d3c5f..e456cc1 100644 (file)
--- a/src/crash/crash.c
+++ b/src/crash/crash.c
@@ -28,7 +28,7 @@ static int appinfo_get_appname_func(pkgmgrinfo_appinfo_h handle, void *data)
        char *label;
        int ret;
 
-       _D("appinfo_get_appname_func() is entered");
+       _D("appinfo_get_appname_func() is entered.");
        if (!data)
                return PMINFO_R_ERROR;
 
@@ -45,7 +45,7 @@ static int appinfo_get_appname_func(pkgmgrinfo_appinfo_h handle, void *data)
 
        (*(char**)data) = label;
 
-       _D("appinfo_get_appname_func() is finished");
+       _D("appinfo_get_appname_func() is finished.");
        return PMINFO_R_OK;
 }
 
@@ -55,7 +55,7 @@ static int get_app_name(char *exepath, char *tname, unsigned int len)
        int count, ret;
        char *name = NULL;
 
-       _D("get_app_name() is entered");
+       _D("get_app_name() is entered.");
        ret = pkgmgrinfo_appinfo_filter_create(&handle);
        if (ret != PMINFO_R_OK)
                goto out;
@@ -87,7 +87,7 @@ out:
 
        snprintf(tname, len, "%s", name);
        free(name);
-       _D("get_app_name() is finished");
+       _D("get_app_name() is finished.");
        return 0;
 }
 
@@ -104,19 +104,19 @@ static int crash_get_content(const struct popup_ops *ops, char *content, unsigne
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -ENOENT;
        }
 
        name = (char *)bundle_get_val(obj->b, "_PROCESS_NAME_");
        if (!name) {
-               _E("Failed to get process name");
+               _E("Failed to get process name.");
                return -ENOENT;
        }
 
        path = (char *)bundle_get_val(obj->b, "_EXEPATH_");
        if (!path) {
-               _E("Failed to get execution path");
+               _E("Failed to get execution path.");
                return -ENOENT;
        }
 
@@ -125,7 +125,7 @@ static int crash_get_content(const struct popup_ops *ops, char *content, unsigne
        if (ret < 0)
                snprintf(tname, l, "%s", name);
 
-       _I("name(%s), path(%s), tname(%s)", name, path, tname);
+       _I("name=%s path='%s' tname=%s", name, path, tname);
 
        text = _("WDS_TPLATFORM_BODY_PS_HAS_STOPPED");
        snprintf(content, len, text, tname);

diff --git a/src/launcher/app.c b/src/launcher/app.c
index 98ac05b..e690e93 100644 (file)
--- a/src/launcher/app.c
+++ b/src/launcher/app.c
@@ -54,7 +54,7 @@ static int launch_app(char *appname,
 
        ret = aul_launch_app(appname, b);
        if (ret <= 0)
-               _E("FAIL: aul_launch_app(%s)", appname);
+               _E("Failed to aul_launch_app(%s).", appname);
 
 out:
        bundle_free(b);
@@ -67,13 +67,13 @@ static int launch_app_raw(char *path, char **argv)
        int ret;
 
        if (!path || access(path, X_OK) != 0) {
-               _E("Cannot execute (%s)", path);
+               _E("Cannot execute '%s'.", path);
                return -EINVAL;
        }
 
        pid = fork();
        if (pid < 0) {
-               _E("Failed to fork (%d)", errno);
+               _E("Failed to fork: %d", errno);
                return -errno;
        }
 
@@ -85,7 +85,7 @@ static int launch_app_raw(char *path, char **argv)
        ret = execvp(path, argv);
 
        /* Failed */
-       _E("Failed execvp(ret: %d, errno: %d)", ret, errno);
+       _E("Failed execvp. return=%d: %d", ret, errno);
        return -errno;
 }
 
@@ -101,11 +101,11 @@ DBusMessage *launch_app_no_param(E_DBus_Object *obj,
                goto out;
        }
 
-       _I("launch app (%s)", appname);
+       _I("Launch app(%s).", appname);
 
        ret = launch_app(appname, NULL, NULL, NULL, NULL, NULL, NULL);
        if (ret < 0)
-               _E("FAIL: launch_app(): %d", ret);
+               _E("Failed to launch_app(): %d", ret);
 
 out:
        reply = dbus_message_new_method_return(msg);
@@ -130,7 +130,7 @@ DBusMessage *launch_app_single_param(E_DBus_Object *obj,
                goto out;
        }
 
-       _I("launch app (%s)", appname);
+       _I("Launch app(%s).", appname);
 
        dbus_error_init(&err);
 
@@ -138,20 +138,20 @@ DBusMessage *launch_app_single_param(E_DBus_Object *obj,
                    DBUS_TYPE_STRING, &key,
                    DBUS_TYPE_STRING, &value,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                ret = -EINVAL;
                goto out;
        }
 
        if (!key || !value) {
-               _E("message is invalid!");
+               _E("Message is invalid.");
                ret = -EINVAL;
                goto out;
        }
 
        ret = launch_app(appname, key, value, NULL, NULL, NULL, NULL);
        if (ret < 0)
-               _E("FAIL: launch_app(): %d", ret);
+               _E("Failed to launch_app(): %d", ret);
 
 out:
        reply = dbus_message_new_method_return(msg);
@@ -174,20 +174,20 @@ DBusMessage *terminate_app_by_pid(E_DBus_Object *obj, DBusMessage *msg)
        if (!dbus_message_get_args(msg, &err,
                    DBUS_TYPE_INT32, &pid,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                ret = -EINVAL;
                goto out;
        }
 
        if (pid < 0) {
-               _E("message is invalid!");
+               _E("Message is invalid.");
                ret = -EINVAL;
                goto out;
        }
 
        ret = aul_terminate_pid(pid);
        if (ret < 0)
-               _E("FAIL: aul_terminate_pid(): %d", ret);
+               _E("Failed to aul_terminate_pid(): %d", ret);
 
 out:
        reply = dbus_message_new_method_return(msg);
@@ -208,11 +208,11 @@ DBusMessage *launch_system_servant_app(E_DBus_Object *obj,        DBusMessage *msg, cha
                goto out;
        }
 
-       _I("launch app raw(%s)", argv[0]);
+       _I("Launch app raw(%s).", argv[0]);
 
        ret = launch_app_raw(argv[0], argv);
        if (ret < 0)
-               _E("FAIL: launch_app_raw: %d", ret);
+               _E("Failed to launch_app_raw: %d", ret);
 
 out:
        reply = dbus_message_new_method_return(msg);

diff --git a/src/launcher/launcher.c b/src/launcher/launcher.c
index 28568f5..c344c06 100644 (file)
--- a/src/launcher/launcher.c
+++ b/src/launcher/launcher.c
@@ -328,7 +328,7 @@ static int init_methods(void)
                                        edbus_objects[i].methods[j].reply_signature,
                                        edbus_objects[i].methods[j].func);
                        if (!ret) {
-                               _E("fail to add method %s!", edbus_objects[i].methods[j].member);
+                               _E("Failed to add method(%s).", edbus_objects[i].methods[j].member);
                                return -ECONNREFUSED;
                        }
                }
@@ -348,7 +348,7 @@ static int register_dbus(void)
                if (e_dbus_init())
                        break;
                if (++retry == RETRY_MAX) {
-                       _E("fail to init edbus");
+                       _E("Failed to init edbus.");
                        return -ECONNREFUSED;
                }
        } while (retry <= RETRY_MAX);
@@ -359,7 +359,7 @@ static int register_dbus(void)
                if (edbus_conn)
                        break;
                if (++retry == RETRY_MAX) {
-                       _E("fail to get edbus");
+                       _E("Failed to get edbus.");
                        ret = -ECONNREFUSED;
                        goto out1;
                }
@@ -371,7 +371,7 @@ static int register_dbus(void)
                if (edbus_request_name)
                        break;
                if (++retry == RETRY_MAX) {
-                       _E("fail to request edbus name");
+                       _E("Failed to request edbus name.");
                        ret = -ECONNREFUSED;
                        goto out2;
                }
@@ -380,14 +380,14 @@ static int register_dbus(void)
        for (i = 0; i < ARRAY_SIZE(edbus_objects); i++) {
                edbus_objects[i].obj = e_dbus_object_add(edbus_conn, edbus_objects[i].path, NULL);
                if (!(edbus_objects[i].obj)) {
-                       _E("fail to add edbus obj");
+                       _E("Failed to add edbus obj.");
                        ret = -ECONNREFUSED;
                        goto out2;
                }
 
                edbus_objects[i].iface = e_dbus_interface_new(edbus_objects[i].interface);
                if (!(edbus_objects[i].iface)) {
-                       _E("fail to add edbus interface");
+                       _E("Failed to add edbus interface.");
                        ret = -ECONNREFUSED;
                        goto out2;
                }

diff --git a/src/launcher/noti.c b/src/launcher/noti.c
index 80acf3b..d2ddccf 100644 (file)
--- a/src/launcher/noti.c
+++ b/src/launcher/noti.c
@@ -108,20 +108,20 @@ static int add_notification(
 
        noti = notification_create(type);
        if (!noti) {
-               _E("FAIL: notification_create()");
+               _E("Failed to notification_create().");
                return -ENOMEM;
        }
 
        noti_err = notification_set_text_domain(noti, LANG_DOMAIN, LOCALE_DIR);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_set_text_domain()");
+               _E("Failed to notification_set_text_domain().");
                priv_id = -ENOMEM;
                goto out;
        }
 
        noti_err = notification_set_layout(noti, layout);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_set_layout()");
+               _E("Failed to notification_set_layout().");
                priv_id = -ENOMEM;
                goto out;
        }
@@ -129,7 +129,7 @@ static int add_notification(
        if (layout == NOTIFICATION_LY_ONGOING_PROGRESS) {
                noti_err = notification_set_progress(noti, (double)0.0);
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_setprogress()");
+                       _E("Failed to notification_setprogress().");
                        priv_id = -ENOMEM;
                        goto out;
                }
@@ -142,7 +142,7 @@ static int add_notification(
                                title,
                                NOTIFICATION_VARIABLE_TYPE_NONE);
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_set_text()");
+                       _E("Failed to notification_set_text().");
                        priv_id = -ENOMEM;
                        goto out;
                }
@@ -162,7 +162,7 @@ static int add_notification(
                }
 
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_set_text()");
+                       _E("Failed to notification_set_text().");
                        priv_id = -ENOMEM;
                        goto out;
                }
@@ -173,7 +173,7 @@ static int add_notification(
                                NOTIFICATION_IMAGE_TYPE_ICON,
                                icon);
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_set_image()");
+                       _E("Failed to notification_set_image().");
                        priv_id = -ENOMEM;
                        goto out;
                }
@@ -184,7 +184,7 @@ static int add_notification(
                                NOTIFICATION_IMAGE_TYPE_ICON_FOR_INDICATOR,
                                icon_indi);
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_set_image()");
+                       _E("Failed to notification_set_image().");
                        priv_id = -ENOMEM;
                        goto out;
                }
@@ -192,7 +192,7 @@ static int add_notification(
 
        noti_err = notification_set_property(noti, prop);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_set_property()");
+               _E("Failed to notification_set_property().");
                priv_id = -ENOMEM;
                goto out;
        }
@@ -201,7 +201,7 @@ static int add_notification(
                noti_err = notification_set_execute_option(noti,
                                NOTIFICATION_EXECUTE_TYPE_SINGLE_LAUNCH, NULL, NULL, b);
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_set_pkgname()");
+                       _E("Failed to notification_set_pkgname().");
                        priv_id = -ENOMEM;
                        goto out;
                }
@@ -209,14 +209,14 @@ static int add_notification(
 
        noti_err = notification_set_display_applist(noti, applist);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_set_display_applist()");
+               _E("Failed to notification_set_display_applist().");
                priv_id = -ENOMEM;
                goto out;
        }
 
        noti_err = notification_set_pkgname(noti, APPNAME);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_set_pkgname()");
+               _E("Failed to notification_set_pkgname().");
                priv_id = -ENOMEM;
                goto out;
        }
@@ -224,7 +224,7 @@ static int add_notification(
        priv_id = -1;
        noti_err = notification_insert(noti, &priv_id);
        if (noti_err != NOTIFICATION_ERROR_NONE)
-               _E("FAIL: notification_insert()");
+               _E("Failed to notification_insert().");
 
 out:
        if (noti)
@@ -341,7 +341,7 @@ static int launch_ode_complete_notification(void *data)
 
        ret = notification_status_message_post(content);
        if (ret != NOTIFICATION_ERROR_NONE)
-               _E("FAIL: notification_status_message_post(text)");
+               _E("Failed to notification_status_message_post(text).");
 
        return ret;
 }
@@ -517,7 +517,7 @@ static int launch_usb_storage_notification(void *data, int type)
                title = "IDS_ST_BODY_READ_ONLY_USB_DEV_CONNECTED_M_NOUN_ABB";
                break;
        default:
-               _E("Unknown type(%d)", type);
+               _E("Unknown type(%d).", type);
                return -EINVAL;
        }
 
@@ -599,7 +599,7 @@ static int launch_usb_device_notification(char *dev, char *name)
        } else if (!strncmp(dev, "unknown", strlen(dev))) {
                title = "IDS_COM_POP_UNKNOWN_USB_DEVICE_CONNECTED";
        } else {
-               _E("Invalid device");
+               _E("Invalid device.");
                return -EINVAL;
        }
 
@@ -687,7 +687,7 @@ static int launch_ticker_notification(void *data)
 
        ret = notification_status_message_post(content);
        if (ret != NOTIFICATION_ERROR_NONE)
-               _E("FAIL: notification_status_message_post(text)");
+               _E("Failed to notification_status_message_post(text).");
 
        return ret;
 }
@@ -714,7 +714,7 @@ static int launch_sdcard_notification(void *data)
 
        ret = notification_status_message_post(content);
        if (ret != NOTIFICATION_ERROR_NONE)
-               _E("FAIL: notification_status_message_post(text)");
+               _E("Failed to notification_status_message_post(text).");
 
        return ret;
 }
@@ -764,7 +764,7 @@ static int launch_battery_notification(int type)
                                NULL,
                                NULL);
        } else
-               _E("Unknown type(%d)", type);
+               _E("Unknown type(%d).", type);
 
        return ret;
 }
@@ -822,7 +822,7 @@ static int launch_battery_active_notification(int type)
                                NULL,
                                NULL);
        } else
-               _E("Unknown type(%d)", type);
+               _E("Unknown type(%d).", type);
 
        return ret;
 }
@@ -874,7 +874,7 @@ static int launch_notification_no_param_by_type(int type)
        case TEMP_COOLDOWN:
                return launch_temp_cooldown_notification(type);
        default:
-               _E("Noti type is unknown");
+               _E("Noti type is unknown.");
                return -EINVAL;
        }
 }
@@ -897,7 +897,7 @@ static int launch_notification_single_param_by_type(int type, void *data)
        case BATTERY_CRITICAL_ACT:
                return launch_battery_discharge_active_notification(data, type);
        default:
-               _E("Noti type is unknown");
+               _E("Noti type is unknown.");
                return -EINVAL;
        }
 }
@@ -908,7 +908,7 @@ static int launch_notification_double_param_by_type(int type, char *data1, char
        case USB_DEVICE:
                return launch_usb_device_notification(data1, data2);
        default:
-               _E("Noti type is unknown");
+               _E("Noti type is unknown.");
                return -EINVAL;
        }
 }
@@ -919,7 +919,7 @@ static int launch_notification_triple_param_by_type(int type, void *data1, void
        case ODE_ERROR:
                return launch_ode_error_notification(data1, data2, data3);
        default:
-               _E("Noti type is unknown");
+               _E("Noti type is unknown.");
                return -EINVAL;
        }
 }
@@ -931,11 +931,11 @@ DBusMessage *activate_notification_no_param(E_DBus_Object *obj, DBusMessage *msg
        DBusMessage *reply;
        int priv_id;
 
-       _D("Load notification");
+       _D("Load notification.");
 // event noti should be supported in mobile profile only
        priv_id = launch_notification_no_param_by_type(type);
        if (priv_id < 0)
-               _E("FAIL: launch_noti_by_type()");
+               _E("Failed to launch_noti_by_type().");
 
        reply = dbus_message_new_method_return(msg);
        dbus_message_iter_init_append(reply, &iter);
@@ -952,21 +952,21 @@ DBusMessage *activate_notification_single_param(E_DBus_Object *obj, DBusMessage
        int priv_id;
        char *value;
 
-       _D("Load notification");
+       _D("Load notification.");
 
        dbus_error_init(&err);
 
        if (!dbus_message_get_args(msg, &err,
                    DBUS_TYPE_STRING, &value,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                priv_id = -EINVAL;
                goto out;
        }
 
        priv_id = launch_notification_single_param_by_type(type, value);
        if (priv_id < 0)
-               _E("FAIL: launch_noti_single_param_by_type()");
+               _E("Failed to launch_noti_single_param_by_type().");
 
 out:
        reply = dbus_message_new_method_return(msg);
@@ -991,14 +991,14 @@ DBusMessage *activate_notification_double_param(E_DBus_Object *obj, DBusMessage
                    DBUS_TYPE_STRING, &str1,
                        DBUS_TYPE_STRING, &str2,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                priv_id = -EINVAL;
                goto out;
        }
 
        priv_id = launch_notification_double_param_by_type(type, str1, str2);
        if (priv_id < 0)
-               _E("FAIL: launch_notification_double_param_by_type()");
+               _E("Failed to launch_notification_double_param_by_type().");
 
 out:
        reply = dbus_message_new_method_return(msg);
@@ -1024,14 +1024,14 @@ DBusMessage *activate_notification_triple_param(E_DBus_Object *obj, DBusMessage
                        DBUS_TYPE_INT32, &data2,
                        DBUS_TYPE_INT32, &data3,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                priv_id = -EINVAL;
                goto out;
        }
 
        priv_id = launch_notification_triple_param_by_type(type, (void *)data1, (void *)data2, (void *)data3);
        if (priv_id < 0)
-               _E("FAIL: launch_noti_single_param_by_type()");
+               _E("Failed to launch_noti_single_param_by_type().");
 
 out:
        reply = dbus_message_new_method_return(msg);
@@ -1055,7 +1055,7 @@ DBusMessage *deactivate_notification(E_DBus_Object *obj, DBusMessage *msg)
        if (!dbus_message_get_args(msg, &err,
                    DBUS_TYPE_INT32, &value,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                ret = -EINVAL;
                goto out;
        }
@@ -1063,7 +1063,7 @@ DBusMessage *deactivate_notification(E_DBus_Object *obj, DBusMessage *msg)
        noti_err = notification_delete_by_priv_id(APPNAME,
                        NOTIFICATION_TYPE_NOTI, value);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_delete_by_priv_id(): %d", noti_err);
+               _E("Failed to notification_delete_by_priv_id(): %d", noti_err);
                ret = -EBADF;
                goto out;
        }
@@ -1085,26 +1085,26 @@ static int progress_update_notification_by_progress_rate(int priv_id, int rate)
        notification_error_e noti_err = NOTIFICATION_ERROR_NONE;
 
        if (rate < 0 || rate > 100) {
-               _E("Improper rate: %d", rate);
+               _E("Improper rate(%d).", rate);
                return -EINVAL;
        }
 
        noti = notification_load(APPNAME, priv_id);
        if (!noti) {
-               _E("FAIL: notification_load()");
+               _E("Failed to notification_load().");
                return -ENOMEM;
        }
 
        noti_err = notification_set_progress(noti, rate/100.f);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_set_progress()");
+               _E("Failed to notification_set_progress().");
                ret = -ENOMEM;
                goto out;
        }
 
        noti_err = notification_update(noti);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_update()");
+               _E("Failed to notification_update().");
                ret = -ENOMEM;
                goto out;
        }
@@ -1114,7 +1114,7 @@ static int progress_update_notification_by_progress_rate(int priv_id, int rate)
 out:
        noti_err = notification_free(noti);
        if (noti_err != NOTIFICATION_ERROR_NONE)
-               _E("FAIL: notification_free()");
+               _E("Failed to notification_free().");
        return ret;
 }
 
@@ -1133,14 +1133,14 @@ DBusMessage *progress_update_notification(E_DBus_Object *obj, DBusMessage *msg)
                    DBUS_TYPE_INT32, &priv_id,
                        DBUS_TYPE_INT32, &rate,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                ret = -EINVAL;
                goto out;
        }
 
        ret = progress_update_notification_by_progress_rate(priv_id, rate);
        if (ret < 0)
-               _E("FAIL: progress_update_notification()");
+               _E("Failed to progress_update_notification().");
 
 out:
        reply = dbus_message_new_method_return(msg);
@@ -1173,7 +1173,7 @@ static int update_usb_device_notification(int id, int num, char *str1, char *str
                } else if (!strncmp(str1, "unknown", strlen(str1))) {
                        title = "IDS_COM_POP_UNKNOWN_USB_DEVICE_CONNECTED";
                } else {
-                       _E("Invalid device");
+                       _E("Invalid device.");
                        return -EINVAL;
                }
 
@@ -1186,13 +1186,13 @@ static int update_usb_device_notification(int id, int num, char *str1, char *str
 
        noti = notification_load(APPNAME, id);
        if (!noti) {
-               _E("FAIL: notification_load()");
+               _E("Failed to notification_load().");
                return -ENOMEM;
        }
 
        noti_err = notification_set_text_domain(noti, LANG_DOMAIN, LOCALE_DIR);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_set_text_domain()");
+               _E("Failed to notification_set_text_domain().");
                ret = -ENOMEM;
                goto out;
        }
@@ -1214,7 +1214,7 @@ static int update_usb_device_notification(int id, int num, char *str1, char *str
                                        NOTIFICATION_VARIABLE_TYPE_NONE);
 
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_set_text()");
+                       _E("Failed to notification_set_text().");
                        ret = -ENOMEM;
                        goto out;
                }
@@ -1227,14 +1227,14 @@ static int update_usb_device_notification(int id, int num, char *str1, char *str
                                content,
                                NOTIFICATION_VARIABLE_TYPE_NONE);
                if (noti_err != NOTIFICATION_ERROR_NONE) {
-                       _E("FAIL: notification_set_text()");
+                       _E("Failed to notification_set_text().");
                        ret = -ENOMEM;
                        goto out;
                }
        }
        noti_err = notification_update(noti);
        if (noti_err != NOTIFICATION_ERROR_NONE) {
-               _E("FAIL: notification_update()");
+               _E("Failed to notification_update().");
                ret = -ENOMEM;
                goto out;
        }
@@ -1244,7 +1244,7 @@ static int update_usb_device_notification(int id, int num, char *str1, char *str
 out:
        noti_err = notification_free(noti);
        if (noti_err != NOTIFICATION_ERROR_NONE)
-               _E("FAIL: notification_free()");
+               _E("Failed to notification_free().");
        return ret;
 }
 
@@ -1277,14 +1277,14 @@ DBusMessage *update_notification_double_param(E_DBus_Object *obj, DBusMessage *m
                        DBUS_TYPE_STRING, &str1,
                        DBUS_TYPE_STRING, &str2,
                        DBUS_TYPE_INVALID)) {
-               _E("there is no message");
+               _E("There is no message.");
                ret = -EINVAL;
                goto out;
        }
 
        ret = text_update_notification(type, id, data, str1, str2);
        if (ret < 0)
-               _E("FAIL: progress_update_notification()");
+               _E("Failed to progress_update_notification().");
 
 out:
        reply = dbus_message_new_method_return(msg);

diff --git a/src/launcher/popup.c b/src/launcher/popup.c
index 6bd7227..2ebc7f0 100644 (file)
--- a/src/launcher/popup.c
+++ b/src/launcher/popup.c
@@ -38,7 +38,7 @@ DBusMessage *launch_popup(E_DBus_Object *obj,
                goto out;
        }
 
-       _I("launch popup (%s)", name);
+       _I("Launch popup(%s).", name);
 
        b = bundle_create();
        if (!b) {
@@ -56,18 +56,18 @@ DBusMessage *launch_popup(E_DBus_Object *obj,
                dbus_message_iter_get_basic(&piter, &value);
                dbus_message_iter_next(&aiter);
 
-               _I("key(%s), value(%s)", key, value);
+               _I("key=%s value=%s", key, value);
 
                ret = bundle_add(b, key, value);
                if (ret < 0) {
-                       _E("Failed to add bundle (%s,%s) (ret:%d)", key, value, ret);
+                       _E("Failed to add bundle(key=%s value=%s): %d", key, value, ret);
                        goto out;
                }
        }
 
        ret = syspopup_launch(name, b);
        if (ret < 0)
-               _E("Failed to launch popup(%d)", ret);
+               _E("Failed to launch popup: %d", ret);
 
 out:
        if (b)

diff --git a/src/mmc/mmc-mobile.c b/src/mmc/mmc-mobile.c
index 4f22836..0e24ca4 100644 (file)
--- a/src/mmc/mmc-mobile.c
+++ b/src/mmc/mmc-mobile.c
@@ -122,7 +122,7 @@ static void send_mount_signal(char *signal)
                        signal,
                        NULL, NULL);
        if (ret < 0)
-               _E("FAIL: broadcast_dbus_signal(%s:%d)", signal, ret);
+               _E("Failed to broadcast_dbus_signal(%s): %d", signal, ret);
 }
 
 static void launch_app(int type)
@@ -145,18 +145,18 @@ static void launch_app(int type)
                app_control_add_extra_data(app_control, MAPPINGNODE_KEY, Mapping_Node);
                ret = app_control_set_app_id(app_control, ODE_APPNAME);
        } else {
-               _E("No matched type(%d)", type);
+               _E("No matched type(%d).", type);
                goto out;
        }
 
        if (ret != APP_CONTROL_ERROR_NONE) {
-               _E("Fail to set app id");
+               _E("Failed to set app id.");
                goto out;
        }
 
        ret = app_control_send_launch_request(app_control, NULL, NULL);
        if (ret != APP_CONTROL_ERROR_NONE)
-               _E("Fail to send launch request");
+               _E("Failed to send launch request.");
 
 out:
        if (app_control) {
@@ -233,7 +233,7 @@ static void register_ode_handler(const struct popup_ops *ops)
                        mmc_removed,
                        (void*)ops);
        if (ret < 0)
-               _E("Failed to register mmc removed signal handler(%d)", ret);
+               _E("Failed to register mmc removed signal handler: %d", ret);
 }
 
 static void mmc_mount_status_changed(keynode_t *in_key, void *data)
@@ -262,7 +262,7 @@ static void register_mmc_mount_handler(const struct popup_ops *ops)
 {
        if (vconf_notify_key_changed(VCONFKEY_SYSMAN_MMC_MOUNT,
                                mmc_mount_status_changed, (void *)ops) != 0)
-               _E("Failed to register mmc mount handler");
+               _E("Failed to register mmc mount handler.");
 }
 
 static void unregister_mmc_mount_handler(const struct popup_ops *ops)
@@ -275,7 +275,7 @@ static void register_mmc_unmount_handler(const struct popup_ops *ops)
 {
        if (vconf_notify_key_changed(VCONFKEY_SYSMAN_MMC_UNMOUNT,
                                mmc_unmount_status_changed, (void *)ops) != 0)
-               _E("Failed to register mmc mount handler");
+               _E("Failed to register mmc mount handler.");
 }
 
 static void unregister_mmc_unmount_handler(const struct popup_ops *ops)
@@ -326,7 +326,7 @@ static int launch_ode(bundle *b, const struct popup_ops *ops)
        Mapping_Node = (char *)bundle_get_val(b, MAPPINGNODE_KEY);
 
        if (!View_Type || !Dev_Path || !Mapping_Node) {
-               _E("Failed to get data for ode");
+               _E("Failed to get data for ode.");
                return -ENOENT;
        }
 
@@ -345,13 +345,13 @@ static int sdcard_setup_get_content(const struct popup_ops *ops, char *content,
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -ENOENT;
        }
 
        Sdcard_ID = (char *)bundle_get_val(obj->b, SDCARD_KEY);
        if (!Sdcard_ID) {
-               _E("Failed to get SDCARD ID");
+               _E("Failed to get SDCARD ID.");
                return -ENOENT;
        }
 

diff --git a/src/overheat/overheat.c b/src/overheat/overheat.c
index 696b969..b712c96 100644 (file)
--- a/src/overheat/overheat.c
+++ b/src/overheat/overheat.c
@@ -101,7 +101,7 @@ static void update_overtemp_time(void *data, DBusMessage *msg)
 
        ret = dbus_message_is_signal(msg, OVERHEAT_INTERFACE, SIGNAL_OVERHEAT_TIME);
        if (!ret) {
-               _E("No overheat SIG");
+               _E("No overheat SIG.");
                return;
        }
 
@@ -152,7 +152,7 @@ static void overheat_poweroff(const struct popup_ops *ops)
                        REBOOT_METHOD,
                        "si", param);
        if (ret < 0)
-               _E("Failed to request poweroff to deviced (%d)", ret);
+               _E("Failed to request poweroff to deviced: %d", ret);
 }
 
 static int overheat_poweroff_warning_launch(bundle *b, const struct popup_ops *ops)
@@ -167,7 +167,7 @@ static int add_dbus_signal_handler(const struct popup_ops *ops)
 
        conn = get_dbus_connection();
        if (!conn) {
-               _E("Failed to get dbus connection");
+               _E("Failed to get dbus connection.");
                return -ENOMEM;
        }
 
@@ -179,7 +179,7 @@ static int add_dbus_signal_handler(const struct popup_ops *ops)
                        update_overtemp_time,
                        (void *)ops);
        if (!overheat_sig_handler) {
-               _E("Failed to add signal handler");
+               _E("Failed to add signal handler.");
                return -ENOMEM;
        }
 
@@ -191,14 +191,14 @@ static void remove_dbus_signal_handler(void)
        E_DBus_Connection *conn;
 
        if (!overheat_sig_handler) {
-               _E("No available sig handler for overheat");
+               _E("No available sig handler for overheat.");
                return;
        }
 
        conn = get_dbus_connection();
        if (!conn) {
                overheat_sig_handler = NULL;
-               _E("No Dbus connection for overheat sig");
+               _E("No Dbus connection for overheat sig.");
                return;
        }
 
@@ -214,7 +214,7 @@ static int overheat_launch(bundle *b, const struct popup_ops *ops)
 
        ret = add_dbus_signal_handler(ops);
        if (ret < 0)
-               _E("Failed to add dbus handler(%d)", ret);
+               _E("Failed to add dbus handler: %d", ret);
 
        return 0;
 }
@@ -260,7 +260,7 @@ int overheat_popup(bundle *b, const struct popup_ops *ops)
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -EINVAL;
        }
 

diff --git a/src/power/power.c b/src/power/power.c
index 8c39e60..20e3231 100644 (file)
--- a/src/power/power.c
+++ b/src/power/power.c
@@ -60,7 +60,7 @@ static void send_result(int result)
                        METHOD_LOCK_TIMEOUT_INPUT,
                        "si", param);
        if (ret < 0)
-               _E("Failed to deliver the result (%d)", ret);
+               _E("Failed to deliver the result: %d", ret);
 }
 
 static int power_lock_expired_get_content(const struct popup_ops *ops, char *content, unsigned int len)
@@ -75,19 +75,19 @@ static int power_lock_expired_get_content(const struct popup_ops *ops, char *con
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -ENOENT;
        }
 
        pid_str = (char *)bundle_get_val(obj->b, APP_PID);
        if (!pid_str) {
-               _E("Failed to get app pid");
+               _E("Failed to get app pid.");
                return -ENOENT;
        }
 
        request_id = (char *)bundle_get_val(obj->b, REQ_ID);
        if (!request_id) {
-               _E("Failed to get request id");
+               _E("Failed to get request id.");
                return -ENOENT;
        }
 
@@ -96,7 +96,7 @@ static int power_lock_expired_get_content(const struct popup_ops *ops, char *con
        if (ret != APP_MANAGER_ERROR_NONE) {
                name = (char *)bundle_get_val(obj->b, APP_COMM);
                if (!name) {
-                       _E("Failed to get app command");
+                       _E("Failed to get app command.");
                return -ENOENT;
        }
        }
@@ -111,7 +111,7 @@ static int power_lock_expired_get_content(const struct popup_ops *ops, char *con
 
 static void power_lock_expired_allow_app(const struct popup_ops *ops)
 {
-       _I("Allow is selected");
+       _I("Allow is selected.");
 
        unload_simple_popup(ops);
 
@@ -122,7 +122,7 @@ static void power_lock_expired_allow_app(const struct popup_ops *ops)
 
 static void power_lock_expired_close_app(const struct popup_ops *ops)
 {
-       _I("Close is selected");
+       _I("Close is selected.");
 
        unload_simple_popup(ops);
 

diff --git a/src/powerkey/powerkey-mobile.c b/src/powerkey/powerkey-mobile.c
index b3166b0..455000a 100644 (file)
--- a/src/powerkey/powerkey-mobile.c
+++ b/src/powerkey/powerkey-mobile.c
@@ -93,7 +93,7 @@ static void restart_clicked(const struct popup_ops *ops)
                        REBOOT_METHOD,
                        "si", param);
 
-       if (ret < 0) _E("Failed to request restart to deviced (%d)", ret);
+       if (ret < 0) _E("Failed to request restart to deviced: %d", ret);
 }
 
 static char* gl_text_get_cb(void *data, Evas_Object *obj, const char *part)
@@ -126,13 +126,13 @@ static void gl_sel_cb(void *data, Evas_Object *obj, void *event_info)
        unload_simple_popup(data);
 
        if (clicked_index == 0) {
-               _D("poweroff is chosen");
+               _D("Poweroff is chosen.");
                load_simple_popup(b, &poweroff_ops);
        } else if (clicked_index == 1) {
-               _D("restart is chosen");
+               _D("Restart is chosen.");
                load_simple_popup(b, &restart_ops);
        } else
-               _E("Wrong button is pressed");
+               _E("Wrong button is pressed.");
 }
 
 static Evas_Object* gl_image_get_cb(void *data, Evas_Object *obj, const char *part)
@@ -143,7 +143,7 @@ static Evas_Object* gl_image_get_cb(void *data, Evas_Object *obj, const char *pa
        Evas_Coord w, h;
 
        if (!img) {
-               _E("BAD image");
+               _E("BAD image.");
                return NULL;
        }
 
@@ -153,7 +153,7 @@ static Evas_Object* gl_image_get_cb(void *data, Evas_Object *obj, const char *pa
                        elm_image_file_set(img, RESDIR"/core_power_off.png", NULL);
                        elm_image_object_size_get(img, &w, &h);
                        evas_object_size_hint_min_set(img, w, h);
-                       _D("Power off img");
+                       _D("Power off img.");
                        return img;
                } else if (!strncmp(part, "elm.swallow.icon.end", sizeof("elm.swallow.icon.end"))) {
                        check = elm_check_add(obj);
@@ -166,7 +166,7 @@ static Evas_Object* gl_image_get_cb(void *data, Evas_Object *obj, const char *pa
                        elm_image_file_set(img, RESDIR"/core_restart.png", NULL);
                        elm_image_object_size_get(img, &w, &h);
                        evas_object_size_hint_min_set(img, w, h);
-                       _D("Restart img");
+                       _D("Restart img.");
                        return img;
                } else if (!strncmp(part, "elm.swallow.icon.end", sizeof("elm.swallow.icon.end"))) {
                        check = elm_check_add(obj);
@@ -175,7 +175,7 @@ static Evas_Object* gl_image_get_cb(void *data, Evas_Object *obj, const char *pa
                        return NULL;
 
        default:
-               _E("BAD data!");
+               _E("BAD data.");
                return NULL;
        }
 }
@@ -186,7 +186,7 @@ Eina_Bool KeyUpCb(void *data, int type, void *event)
        const struct popup_ops *ops = data;
 
        if (!strncmp(e->key, BACK_KEY, sizeof(BACK_KEY)) || !strncmp(e->key, HOME_KEY, sizeof(HOME_KEY))) {
-               _D("HOME_KEY or BACK KEY is pressed");
+               _D("HOME_KEY or BACK KEY is pressed.");
                if (ops)
                        unload_simple_popup(ops);
                terminate_if_no_popup();
@@ -279,7 +279,7 @@ static void register_handlers(const struct popup_ops *ops)
                VCONFKEY_PM_STATE,
                pm_state_changed,
                (void *)ops) != 0)
-               _E("Failed to register vconf");
+               _E("Failed to register vconf.");
 }
 
 static void unregister_handlers(const struct popup_ops *ops)
@@ -332,7 +332,7 @@ static void poweroff_clicked(const struct popup_ops *ops)
                        REBOOT_INTERFACE_NAME,
                        REBOOT_METHOD,
                        "si", param);
-       if (ret < 0) _E("Failed to request poweroff to deviced (%d)", ret);
+       if (ret < 0) _E("Failed to request poweroff to deviced: %d", ret);
 }
 
 static const struct popup_ops restart_ops = {

diff --git a/src/powerkey/powerkey-tv.c b/src/powerkey/powerkey-tv.c
index 47931c1..6e31c29 100644 (file)
--- a/src/powerkey/powerkey-tv.c
+++ b/src/powerkey/powerkey-tv.c
@@ -55,7 +55,7 @@ Eina_Bool KeyUpCb(void *data, int type, void *event)
        const struct popup_ops *ops = data;
 
        if (!strncmp(e->key, BACK_KEY, sizeof(BACK_KEY)) || !strncmp(e->key, HOME_KEY, sizeof(HOME_KEY))) {
-               _D("HOME_KEY or BACK KEY is pressed");
+               _D("HOME_KEY or BACK KEY is pressed.");
                if (ops)
                        unload_simple_popup(ops);
                terminate_if_no_popup();
@@ -81,7 +81,7 @@ static void register_handlers(const struct popup_ops *ops)
                VCONFKEY_PM_STATE,
                pm_state_changed,
                (void *)ops) != 0)
-               _E("Failed to register vconf");
+               _E("Failed to register vconf.");
 }
 
 static void unregister_handlers(const struct popup_ops *ops)
@@ -122,7 +122,7 @@ static void poweroff_clicked(const struct popup_ops *ops)
                        REBOOT_INTERFACE_NAME,
                        REBOOT_METHOD,
                        "si", param);
-       if (ret < 0) _E("Failed to request poweroff to deviced (%d)", ret);
+       if (ret < 0) _E("Failed to request poweroff to deviced: %d", ret);
 }
 
 static const struct popup_ops powerkey_ops = {

diff --git a/src/powerkey/powerkey-wearable.c b/src/powerkey/powerkey-wearable.c
index b82ca98..13013b9 100644 (file)
--- a/src/powerkey/powerkey-wearable.c
+++ b/src/powerkey/powerkey-wearable.c
@@ -71,7 +71,7 @@ static int is_supported(const char *path)
        bool res;
 
        if (system_info_get_platform_bool(path, &res) != SYSTEM_INFO_ERROR_NONE) {
-               _E("Fail to get TELEPHONY INFO");
+               _E("Failed to get TELEPHONY INFO.");
                return -1;
        }
 
@@ -121,7 +121,7 @@ _gl_sel_poweroff_cb(void *data, Evas_Object *obj, void *event_info)
 {
        const struct popup_ops *ops = data;
 
-       _D("poweroff is chosen");
+       _D("Poweroff is chosen.");
        elm_genlist_item_selected_set((Elm_Object_Item *)event_info, EINA_FALSE);
        poweroff_clicked(ops);
 
@@ -137,10 +137,10 @@ _gl_sel_airplane_cb(void *data, Evas_Object *obj, void *event_info)
 
        elm_genlist_item_selected_set((Elm_Object_Item *)event_info, EINA_FALSE);
 
-               _D("flight mode is chosen");
+               _D("Flight mode is chosen.");
                ret = vconf_get_bool(VCONFKEY_TELEPHONY_FLIGHT_MODE, &is_flight_mode);
                if (ret < 0) {
-                       _E("Error in getting VCONFKEY_TELEPHONY_FLIGHT_MODE");
+                       _E("Failed to get VCONFKEY_TELEPHONY_FLIGHT_MODE.");
                        return;
                }
 
@@ -160,17 +160,17 @@ static Evas_Object *_gl_menu_contents_get_airplane(void *data, Evas_Object *obj,
        int ret = 0;
 
        if (!strncmp(part, "elm.icon", sizeof("elm.icon"))) {
-               _D("index = AIRPLANE_MODE");
+               _D("Index=AIRPLANE_MODE");
                        check = elm_check_add(obj);
                if (!check) {
-                       _E("BAD check!");
+                       _E("BAD check.");
                                return NULL;
                        }
                        flight_icon = check;
 
                        ret = vconf_get_bool(VCONFKEY_TELEPHONY_FLIGHT_MODE, &is_value);
                        if (ret < 0) {
-                               _E("Error in getting VCONFKEY_TELEPHONY_FLIGHT_MODE");
+                               _E("Failed to get VCONFKEY_TELEPHONY_FLIGHT_MODE.");
                                return NULL;
                        }
                        elm_check_state_set(check, (is_value) ? EINA_TRUE : EINA_FALSE);
@@ -191,12 +191,12 @@ static Evas_Object *_gl_menu_contents_get_poweroff(void *data, Evas_Object *obj,
        Evas_Coord w = 56, h = 56;
 
        if (!strncmp(part, "elm.icon", sizeof("elm.icon"))) {
-               _D("index = POWEROFF_MODE");
+               _D("Index=POWEROFF_MODE");
                table = elm_table_add(obj);
                img1 = elm_image_add(table);
                img2 = elm_image_add(table);
                if (!img1 || !img2) {
-                       _E("BAD image!");
+                       _E("BAD image.");
                        return NULL;
                }
                elm_image_file_set(img1, RESDIR"/gear_device_options_bg.png", NULL);
@@ -230,7 +230,7 @@ static void register_handlers(const struct popup_ops *ops)
                VCONFKEY_PM_STATE,
                pm_state_changed,
                (void *)ops) != 0)
-               _E("Failed to register vconf");
+               _E("Failed to register vconf.");
 }
 
 static void unregister_handlers(const struct popup_ops *ops)
@@ -259,7 +259,7 @@ static void poweroff_clicked(const struct popup_ops *ops)
                        REBOOT_INTERFACE_NAME,
                        REBOOT_METHOD,
                        "si", param);
-       if (ret < 0) _E("Failed to request poweroff to deviced (%d)", ret);
+       if (ret < 0) _E("Failed to request poweroff to deviced: %d", ret);
 }
 
 static int powerkey_launch(bundle *b, const struct popup_ops *ops)
@@ -279,14 +279,14 @@ create_base_gui(appdata_s *application_info, const struct popup_ops *ops)
        appdata_s *ad = application_info;
 
        if (ad == NULL) {
-               _E("No appdata");
+               _E("No appdata.");
                return -1;
        }
 
        /* Window */
        ad->win = get_window();
        if (!ad->win) {
-               _E("Error in creating window!");
+               _E("Failed to create window.");
                return -1;
        }
        elm_win_conformant_set(ad->win, EINA_TRUE);
@@ -294,7 +294,7 @@ create_base_gui(appdata_s *application_info, const struct popup_ops *ops)
 
        ad->popup = elm_popup_add(ad->win);
        if (!ad->popup) {
-               _E("Error in creating popup!");
+               _E("Failed to create popup.");
                return -1;
        }
 
@@ -500,13 +500,13 @@ static void set_flight_icon(int value)
        int ret = 0;
 
        if (value > 1 || value < 0) {
-               _E("Invalid VCONFKEY_TELEPHONY_FLIGHT_MODE value");
+               _E("Invalid VCONFKEY_TELEPHONY_FLIGHT_MODE value.");
                return;
        }
 
        ret = vconf_set_bool(VCONFKEY_TELEPHONY_FLIGHT_MODE, value);
        if (ret < 0) {
-               _E("Fail in setting VCONFKEY_TELEPHONY_FLIGHT_MODE");
+               _E("Failed to set VCONFKEY_TELEPHONY_FLIGHT_MODE.");
                return;
        }
 
@@ -566,9 +566,9 @@ static const struct popup_ops flightmode_ops = {
 static __attribute__ ((constructor)) void powerkey_register_popup(void)
 {
        telephony_supported = is_supported(TELEPHONY_PATH);
-       _I("TELEPHONY = %d", telephony_supported);
+       _I("TELEPHONY=%d", telephony_supported);
        if (telephony_supported > 1 || telephony_supported < 0) {
-               _E("Cannot decide powerkey type!");
+               _E("Cannot decide powerkey type.");
                telephony_supported = 0;
        }
 

diff --git a/src/usb/usb-device.c b/src/usb/usb-device.c
index e193269..ce87c56 100644 (file)
--- a/src/usb/usb-device.c
+++ b/src/usb/usb-device.c
@@ -66,7 +66,7 @@ static void send_result_dbus_signal(int result)
                        USD_USB_DEVICE_CONFIRM_SIGNAL,
                        "i", param);
        if (ret < 0)
-               _E("FAIL: broadcast_dbus_signal(%d)", ret);
+               _E("Failed to broadcast_dbus_signal: %d", ret);
 }
 
 static void send_usbhost_result_dbus_signal(int result)
@@ -85,12 +85,12 @@ static void send_usbhost_result_dbus_signal(int result)
                USBHOST_APP_CONFIRM_SIGNAL,
                "ii", param);
        if (ret < 0)
-               _E("FAIL: broadcast_dbus_signal(%d)", ret);
+               _E("Failed to broadcast_dbus_signal: %d", ret);
 }
 
 static void usb_device_confirm_ok_clicked(const struct popup_ops *ops)
 {
-       _I("OK is selected");
+       _I("OK is selected.");
        unload_simple_popup(ops);
        send_result_dbus_signal(USB_DEVICE_CONFIRM_OK);
        terminate_if_no_popup();
@@ -98,7 +98,7 @@ static void usb_device_confirm_ok_clicked(const struct popup_ops *ops)
 
 static void usb_device_confirm_cancel_clicked(const struct popup_ops *ops)
 {
-       _I("CANCEL is selected");
+       _I("CANCEL is selected.");
        unload_simple_popup(ops);
        send_result_dbus_signal(USB_DEVICE_CONFIRM_NOK);
        terminate_if_no_popup();
@@ -106,14 +106,14 @@ static void usb_device_confirm_cancel_clicked(const struct popup_ops *ops)
 
 static void usb_device_confirm_terminate(const struct popup_ops *ops)
 {
-       _I("terminate usb device confirm popup");
+       _I("Terminate usb device confirm popup.");
        send_result_dbus_signal(USB_DEVICE_CONFIRM_NOK);
        terminate_if_no_popup();
 }
 
 static void usbhost_confirm_terminate(const struct popup_ops *ops)
 {
-       _I("terminate usb device confirm popup");
+       _I("Terminate usb device confirm popup.");
        terminate_if_no_popup();
 }
 
@@ -121,7 +121,7 @@ static void usbhost_confirm_ok_clicked(void *data, Evas_Object *obj, void *event
 {
        const struct popup_ops *ops = data;
 
-       _I("OK is selected");
+       _I("OK is selected.");
        unload_simple_popup(ops);
        send_usbhost_result_dbus_signal(USB_DEVICE_CONFIRM_OK);
        terminate_if_no_popup();
@@ -131,7 +131,7 @@ static void usbhost_confirm_cancel_clicked(void *data, Evas_Object *obj, void *e
 {
        const struct popup_ops *ops = data;
 
-       _I("CANCEL is selected");
+       _I("CANCEL is selected.");
        unload_simple_popup(ops);
        send_usbhost_result_dbus_signal(USB_DEVICE_CONFIRM_NOK);
        terminate_if_no_popup();
@@ -144,13 +144,13 @@ static int usbhost_get_contents(bundle *b, char *content, unsigned int len)
        pid_t pid;
 
        if (!b) {
-               _E("bundle is null return -EINVAL");
+               _E("Bundle is null return -EINVAL.");
                return -EINVAL;
        }
 
        app_pid = (char *)bundle_get_val(b, "_APP_PID_");
        if (!app_pid) {
-               _E("Failed to get pid");
+               _E("Failed to get pid.");
                return -ENOENT;
        }
 
@@ -159,7 +159,7 @@ static int usbhost_get_contents(bundle *b, char *content, unsigned int len)
 
        ret = app_manager_get_app_id(pid, &app_name);
        if (ret != APP_MANAGER_ERROR_NONE) {
-               _E("Failed to get app id(%d)", ret);
+               _E("Failed to get app id: %d", ret);
                return -ENOENT;
        }
 
@@ -196,7 +196,7 @@ static int usbhost_show(bundle *b, const struct popup_ops *ops)
 
        ret = get_object_by_ops(ops, &obj);
        if (ret < 0) {
-               _E("Failed to get object (%d)", ret);
+               _E("Failed to get object: %d", ret);
                return -EINVAL;
        }
 

diff --git a/src/usb/usb-mobile.c b/src/usb/usb-mobile.c
index c982b77..d88b0da 100644 (file)
--- a/src/usb/usb-mobile.c
+++ b/src/usb/usb-mobile.c
@@ -34,7 +34,7 @@ static void usb_state_changed(keynode_t *key, void *data)
 
        switch (state) {
        case VCONFKEY_SYSMAN_USB_DISCONNECTED:
-               _I("USB cabel is disconnected");
+               _I("USB cabel is disconnected.");
                unload_simple_popup(ops);
                if (state_handler == 0) {
                        vconf_ignore_key_changed(
@@ -70,7 +70,7 @@ static int usb_launch(bundle *b, const struct popup_ops *ops)
                                VCONFKEY_SYSMAN_USB_STATUS,
                                usb_state_changed, (void *)ops);
                if (state_handler != 0)
-                       _E("Failed to register usb state change event()");
+                       _E("Failed to register usb state change event().");
        }
 
        return 0;

diff --git a/src/usb/usbotg-mobile.c b/src/usb/usbotg-mobile.c
index abc7607..6c70b67 100644 (file)
--- a/src/usb/usbotg-mobile.c
+++ b/src/usb/usbotg-mobile.c
@@ -115,7 +115,7 @@ static void launch_app(int type)
                        break;
        }
        if (i == type_len) {
-               _E("Invalid type (%d)", type);
+               _E("Invalid type(%d).", type);
                return;
        }
 
@@ -128,18 +128,18 @@ static void launch_app(int type)
        else if (type == 1)
                ret = app_control_set_app_id(app_control, GALLERY_APPNAME);
        else {
-               _E("No matched type(%d)", type);
+               _E("No matched type(%d).", type);
                goto out;
        }
 
        if (ret != APP_CONTROL_ERROR_NONE) {
-               _E("Fail to set app id");
+               _E("Failed to set app id.");
                goto out;
        }
 
        ret = app_control_send_launch_request(app_control, NULL, NULL);
        if (ret != APP_CONTROL_ERROR_NONE)
-               _E("Fail to send launch request");
+               _E("Fail to send launch request.");
 
 out:
        if (app_control) {
@@ -175,7 +175,7 @@ static void storage_unmount(const struct popup_ops *ops)
                        DEVICED_IFACE_USBHOST,
                        SIGNAL_NAME_UNMOUNT, "s", param);
        if (ret < 0)
-               _E("FAIL: broadcast_dbus_signal()");
+               _E("Failed to broadcast_dbus_signal().");
 
        memset(removed_path, 0, sizeof(removed_path));
 
@@ -191,11 +191,11 @@ static int storage_mounted_launch(bundle *b, const struct popup_ops *ops)
 
        path = (char *)bundle_get_val(b, USB_MOUNT_PATH);
        if (!path) {
-               _E("Failed to get mount path");
+               _E("Failed to get mount path.");
                return -2;
        }
 
-       _I("USB storage mount path (%s)", path);
+       _I("USB storage mount path(%s).", path);
        snprintf(added_path, sizeof(added_path), "%s", path);
        return 0;
 }
@@ -209,7 +209,7 @@ static int unmount_storage_launch(bundle *b, const struct popup_ops *ops)
 
        path = (char *)bundle_get_val(b, USB_MOUNT_PATH);
        if (!path) {
-               _E("Failed to get mount path");
+               _E("Failed to get mount path.");
                return -2;
        }
 
@@ -228,7 +228,7 @@ static int storage_unmounted(bundle *b, const struct popup_ops *ops)
 
        path = (char *)bundle_get_val(b, USB_MOUNT_PATH);
        if (!path) {
-               _E("Failed to get mount path");
+               _E("Failed to get mount path.");
                return -ENOENT;
        }
 

diff --git a/system-cooperator/system-cooperator.c b/system-cooperator/system-cooperator.c
index e4cef48..53e55ef 100644 (file)
--- a/system-cooperator/system-cooperator.c
+++ b/system-cooperator/system-cooperator.c
@@ -120,7 +120,7 @@ static int app_create(int type)
        case CHARGER_CONNECTION:
                return play_notification(type, FEEDBACK_PATTERN_CHARGERCONN);
        default:
-               _E("Unknown type(%d)", type);
+               _E("Unknown type(%d).", type);
                return -EINVAL;
        }
 }
@@ -131,7 +131,7 @@ static int app_terminate(int type)
        case CHARGER_CONNECTION:
                return 0;
        default:
-               _E("Unknown type(%d)", type);
+               _E("Unknown type(%d).", type);
                return -EINVAL;
        }
 }
@@ -187,7 +187,7 @@ int main(int argc, char *argv[])
 
        ret = appcore_set_i18n(LANG_DOMAIN, LOCALE_DIR);
        if (ret != 0)
-               _E("FAIL: appcore_set_i18n()");
+               _E("Failed to appcore_set_i18n().");
 
        if (argc <= 1)
                return 0;
@@ -197,13 +197,13 @@ int main(int argc, char *argv[])
 
        ret = init_main_loop(looptype);
        if (ret < 0) {
-               _E("Failed to init main loop (%d)", ret);
+               _E("Failed to init main loop: %d", ret);
                return ret;
        }
 
        ret = app_create(type);
        if (ret < 0) {
-               _E("Failed to register handlers");
+               _E("Failed to register handlers.");
                goto out;
        }
 
@@ -212,7 +212,7 @@ int main(int argc, char *argv[])
 out:
        ret = app_terminate(type);
        if (ret < 0)
-               _E("Failed to release handlers(%d)", ret);
+               _E("Failed to release handlers: %d", ret);
 
        finalize_main_loop(looptype);