Fix svace issues (WGID-343635, 343636)

Change-Id: Icc4094ebc3831ff74c479e71938906184fbc7ca7
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>

diff --git a/test/firewall.c b/test/firewall.c
index e29daff..0efc210 100755 (executable)
--- a/test/firewall.c
+++ b/test/firewall.c
@@ -831,15 +831,13 @@ static int _test_stc_fw_remove_rule(MManager *mm, struct menu_data *menu)
        ret = stc_firewall_rule_remove(rule_h);
        if (ret == STC_ERROR_NONE) {
                msg(LOG_GREEN "Success to remove firewall rule" LOG_END);
+               g_rule_list = g_slist_remove(g_rule_list, rule_h);
                ret = stc_firewall_rule_destroy(rule_h);
                if (ret == STC_ERROR_NONE)
                        msg(LOG_GREEN "Success to destroy firewall rule" LOG_END);
                else
                        msg("Fail to destroy firewall rule " LOG_RED "[%s]" LOG_END,
                                test_stc_convert_error_type_to_string(ret));
-
-               g_rule_list = g_slist_remove(g_rule_list, rule_h);
-
        } else
                msg("Fail to remove firewall rule " LOG_RED "[%s]" LOG_END,
                        test_stc_convert_error_type_to_string(ret));
@@ -1033,15 +1031,13 @@ static int _test_stc_fw_remove_chain(MManager *mm, struct menu_data *menu)
        ret = stc_firewall_chain_remove(chain_h);
        if (ret == STC_ERROR_NONE) {
                msg(LOG_GREEN "Success to remove firewall chain" LOG_END);
+               g_chain_list = g_slist_remove(g_chain_list, chain_h);
                ret = stc_firewall_chain_destroy(chain_h);
                if (ret == STC_ERROR_NONE)
                        msg(LOG_GREEN "Success to destroy firewall chain" LOG_END);
                else
                        msg("Fail to destroy firewall chain " LOG_RED "[%s]" LOG_END,
                                test_stc_convert_error_type_to_string(ret));
-
-               g_chain_list = g_slist_remove(g_chain_list, chain_h);
-
        } else
                msg("Fail to remove firewall chain " LOG_RED "[%s]" LOG_END,
                        test_stc_convert_error_type_to_string(ret));