e_client: remove CLIENT_DEL_STACK_ISSUE defines 36/325436/1
authorJunseok Kim <juns.kim@samsung.com>
Mon, 12 May 2025 08:03:11 +0000 (17:03 +0900)
committerTizen Window System <tizen.windowsystem@gmail.com>
Tue, 10 Jun 2025 09:37:49 +0000 (18:37 +0900)
Since the patch "e_policy_desk_area: refine layer list to use e_view_tree" adjusted,
the list of client uses view tree instead of eina_inlist.
So, this hotfix codes are no more useful. remove it

Change-Id: I9ce8aa7ce1bb39747c6f71e6c3bf0d5dfd121f4b

src/bin/core/e_client.c
src/bin/core/e_desk_area_intern.h
src/bin/core/e_intern.h
src/bin/windowmgr/e_policy_desk_area.c
src/include/e_client.h

index 1786f32dd710d10871783e176d9ec8c2d6e29bc3..bc3ae81beb6b103fe7611cf87f77d55dbf35b70c 100644 (file)
@@ -241,9 +241,6 @@ static Eina_Inlist *_e_client_hooks[] =
    [E_CLIENT_HOOK_TRANSFORM_CHANGE] = NULL,
    [E_CLIENT_HOOK_ACTIVATE_DONE] = NULL,
    [E_CLIENT_HOOK_EVAL_VISIBILITY_END] = NULL,
-#ifdef CLIENT_DEL_STACK_ISSUE
-   [E_CLIENT_HOOK_FREE] = NULL,
-#endif // CLIENT_DEL_STACK_ISSUE
 };
 
 static Eina_Inlist *_e_client_intercept_hooks[] =
@@ -783,10 +780,6 @@ _e_client_free(E_Client *ec)
    eina_stringshare_replace(&ec->icccm.window_role, NULL);
    e_client_netwm_name_set(ec, NULL);
 
-#ifdef CLIENT_DEL_STACK_ISSUE
-   e_client_hook_call(E_CLIENT_HOOK_FREE, ec);
-#endif // CLIENT_DEL_STACK_ISSUE
-
    E_FREE_FUNC(ec->frame, evas_object_del);
 
    E_OBJECT(ec)->references--;
index 44c8b2cf3a49c79a95f811394016b9b126878971..d613778b330f2cdb84e8805b654dfc9e8bb5e096 100644 (file)
@@ -38,9 +38,6 @@ struct _E_Desk_Area
    Eina_List           *fullscreen_clients;
 
    E_Comp_Wl_Hook      *hook_subsurf_create;
-#ifdef CLIENT_DEL_STACK_ISSUE
-   E_Client_Hook       *hook_client_free;
-#endif // CLIENT_DEL_STACK_ISSUE
 };
 
 typedef struct _E_Desk_Area_Data_EC_Get
index 2879366071089207e828a78b27bb5d5e0bbffb8f..0f65154ab622d6254260975d8df03f0bd0aa2ce0 100644 (file)
@@ -21,7 +21,6 @@
 #include <Eina.h>
 
 #define CHECKING_PRIMARY_ZPOS
-#define CLIENT_DEL_STACK_ISSUE
 
 #ifdef ENABLE_TTRACE
 #undef TRACE_DS_BEGIN
index 3ff7b2bcb3337f4ebe312c74f5c5484ee77296b2..a4d76080d49928d98b282b5f77fb34a29931ac43 100644 (file)
@@ -2893,10 +2893,6 @@ _e_policy_desk_area_private_client_del(E_Policy_Desk_Area_Private_Client *eda_cl
 {
    E_Desk_Area *eda = eda_client->eda;
    E_Client *ec = eda_client->ec;
-#ifdef CLIENT_DEL_STACK_ISSUE
-#else
-   E_Comp_Object *cw;
-#endif // CLIENT_DEL_STACK_ISSUE
 
    if (!e_desk_area_has_ec(eda, ec)) return;
 
@@ -2904,13 +2900,6 @@ _e_policy_desk_area_private_client_del(E_Policy_Desk_Area_Private_Client *eda_cl
    e_util_transform_del(ec->desk_area.transform);
    ec->desk_area.transform = NULL;
 
-#ifdef CLIENT_DEL_STACK_ISSUE
-#else
-   cw = evas_object_smart_data_get(ec->frame);
-   if (!cw)
-     ELOGF("EDA", "No Comp Object. Fix Me~!!", ec);
-#endif // CLIENT_DEL_STACK_ISSUE
-
    // wl_list remove
    if (eda_client->comp_object_color_set.notify)
      wl_list_remove(&eda_client->comp_object_color_set.link);
@@ -3016,21 +3005,6 @@ _e_policy_desk_area_cb_hook_subsurface_create(void *data, E_Client *ec)
      }
 }
 
-#ifdef CLIENT_DEL_STACK_ISSUE
-static void
-_e_policy_desk_area_cb_client_free(void *data, E_Client *ec)
-{
-   E_Desk_Area *eda = data;
-   E_Comp_Object *cw;
-
-   ELOGF("EDA", "HOOK CLIENT FREE. desk_area:%p", ec, eda);
-
-   cw = evas_object_smart_data_get(ec->frame);
-   if (!cw)
-     ELOGF("EDA", "No Comp Object. Fix Me~!!", ec);
-}
-#endif //CLIENT_DEL_STACK_ISSUE
-
 EINTERN void
 e_policy_desk_area_client_add_listener_add(E_Policy_Desk_Area *pda, struct wl_listener *listener)
 {
@@ -3148,12 +3122,6 @@ e_policy_desk_area_new(E_Desk_Area *eda)
                                                  _e_policy_desk_area_cb_hook_subsurface_create,
                                                  NULL);
 
-#ifdef CLIENT_DEL_STACK_ISSUE
-   eda->hook_client_free = e_client_hook_add(E_CLIENT_HOOK_FREE,
-                                             _e_policy_desk_area_cb_client_free,
-                                             eda);
-#endif // CLIENT_DEL_STACK_ISSUE
-
    pda->geometry_set.notify = _e_policy_desk_area_cb_geometry_set;
    e_desk_area_geometry_set_listener_add(eda, &pda->geometry_set);
    pda->activate.notify = _e_policy_desk_area_cb_activate;
@@ -3209,9 +3177,6 @@ e_policy_desk_area_del(E_Policy_Desk_Area *pda)
    wl_list_remove(&pda->client_del.link);
 
    E_FREE_FUNC(eda->hook_subsurf_create, e_comp_wl_hook_del);
-#ifdef CLIENT_DEL_STACK_ISSUE
-   E_FREE_FUNC(eda->hook_client_free, e_client_hook_del);
-#endif // CLIENT_DEL_STACK_ISSUE
 
    e_policy_container_view_tree_shutdown(e_policy_container_get(pda));
 
index 6bde011a6e2234421beeba128c349619992e3708..e923b96c0f519480aed889f7f97aaf1c072563e8 100644 (file)
@@ -276,9 +276,6 @@ typedef enum _E_Client_Hook_Point
    E_CLIENT_HOOK_TRANSFORM_CHANGE,
    E_CLIENT_HOOK_ACTIVATE_DONE,
    E_CLIENT_HOOK_EVAL_VISIBILITY_END,
-#ifdef CLIENT_DEL_STACK_ISSUE
-   E_CLIENT_HOOK_FREE,
-#endif // CLIENT_DEL_STACK_ISSUE
    E_CLIENT_HOOK_LAST,
 } E_Client_Hook_Point;