Alow multiplexing from writer-made readers 36/291736/2
authorMichal Bloch <m.bloch@samsung.com>
Tue, 18 Apr 2023 13:43:50 +0000 (15:43 +0200)
committerMichal Bloch <m.bloch@samsung.com>
Fri, 21 Apr 2023 16:03:29 +0000 (18:03 +0200)
Change-Id: I0ab35b82c7c4e04909e4a011eee7ce4e99915562
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
src/logger/log_buffer.c
src/logger/reader_pipe.c
src/logger/reader_pipe.h

index c168ae7..95946e1 100644 (file)
@@ -260,7 +260,7 @@ static int service_writer_handle_req_util(struct logger *server, struct writer *
                goto cleanup;
        }
 
-       retval = reader_pipe_init_with_writer(&reader, wr, server, params.monitor, params.is_dumping);
+       retval = reader_pipe_init(&reader, params.enabled_buffers, server, params.monitor, params.is_dumping);
        if (retval != 0)
                goto cleanup;
 
index cca9ecf..4d5b590 100644 (file)
@@ -78,32 +78,6 @@ int reader_pipe_init(struct reader_pipe **reader, int enabled_buffers, struct lo
        return 0;
 }
 
-int reader_pipe_init_with_writer(struct reader_pipe **reader, struct writer *writer, struct logger *server,
-       bool monitor, bool is_dumping)
-{
-       assert(reader);
-       assert(writer);
-       assert(writer->buf_ptr);
-       assert(server);
-
-       __attribute__((cleanup(reader_free_ptr))) struct reader_pipe *ret = reader_pipe_alloc(server, monitor, is_dumping);
-       if (!ret)
-               return -ENOMEM;
-
-       log_storage_reader *const lsr = log_storage_new_reader(writer->buf_ptr->log_storage_ptr,
-               is_dumping, monitor, reader_pipe_notify_losing_log, ret);
-       if (!lsr)
-               return -ENOMEM;
-       ret->log_storage_reader_ptrs[0] = lsr;
-
-       init_fd_entity(&ret->common.fd_entity_sink,   dispatch_event_reader, ret);
-       init_fd_entity(&ret->common.fd_entity_source, dispatch_event_reader, ret);
-
-       *reader = ret;
-       ret = NULL;
-       return 0;
-}
-
 int reader_pipe_print_out_single_log(struct reader_pipe *reader, const dlogutil_entry_s *dlogutil_entry)
 {
        assert(reader);
index 7f9dccf..ec11987 100644 (file)
@@ -16,6 +16,4 @@ struct reader_pipe {
 
 int reader_pipe_init(struct reader_pipe **reader, int enabled_buffers, struct logger *server,
        bool monitor, bool is_dumping);
-int reader_pipe_init_with_writer(struct reader_pipe **reader, struct writer *writer, struct logger *server,
-       bool monitor, bool is_dumping);
 int reader_pipe_print_out_single_log(struct reader_pipe *reader, const dlogutil_entry_s *dlogutil_entry);