lottie: mordernize using clang-tidy "modernize-use-override"

Change-Id: Ice8612f9ceb3b99ebeeb6b618a54e9298b4cb66f

diff --git a/src/lottie/lottieitem.h b/src/lottie/lottieitem.h
index 99db81e..83fbda9 100644 (file)
--- a/src/lottie/lottieitem.h
+++ b/src/lottie/lottieitem.h
@@ -362,7 +362,7 @@ class LOTPaintDataItem : public LOTContentItem
 public:
    LOTPaintDataItem(bool staticContent);
    void addPathItems(std::vector<LOTPathDataItem *> &list, int startOffset);
-   virtual void update(int frameNo, const VMatrix &parentMatrix, float parentAlpha, const DirtyFlag &flag);
+   void update(int frameNo, const VMatrix &parentMatrix, float parentAlpha, const DirtyFlag &flag) override;
    void renderList(std::vector<VDrawable *> &list) final;
 protected:
    virtual void updateContent(int frameNo) = 0;
@@ -476,8 +476,8 @@ class LOTRepeaterItem : public LOTContentItem
 {
 public:
    LOTRepeaterItem(LOTRepeaterData *data);
-   virtual void update(int frameNo, const VMatrix &parentMatrix, float parentAlpha, const DirtyFlag &flag) final;
-   virtual void renderList(std::vector<VDrawable *> &list) final;
+   void update(int frameNo, const VMatrix &parentMatrix, float parentAlpha, const DirtyFlag &flag) final;
+   void renderList(std::vector<VDrawable *> &list) final;
 private:
    LOTRepeaterData             *mData;
 };

diff --git a/src/lottie/lottiemodel.cpp b/src/lottie/lottiemodel.cpp
index 5d4145f..58b7f4b 100644 (file)
--- a/src/lottie/lottiemodel.cpp
+++ b/src/lottie/lottiemodel.cpp
@@ -6,19 +6,19 @@
 class LottieRepeaterProcesser : public LOTDataVisitor {
 public:
     LottieRepeaterProcesser() : mRepeaterFound(false) {}
-    void visit(LOTCompositionData *) {}
-    void visit(LOTLayerData *) {}
-    void visit(LOTTransformData *) {}
-    void visit(LOTShapeGroupData *) {}
-    void visit(LOTShapeData *) {}
-    void visit(LOTRectData *) {}
-    void visit(LOTEllipseData *) {}
-    void visit(LOTTrimData *) {}
-    void visit(LOTRepeaterData *) { mRepeaterFound = true; }
-    void visit(LOTFillData *) {}
-    void visit(LOTStrokeData *) {}
-    void visit(LOTPolystarData *) {}
-    void visitChildren(LOTGroupData *obj)
+    void visit(LOTCompositionData *) override {}
+    void visit(LOTLayerData *) override {}
+    void visit(LOTTransformData *) override {}
+    void visit(LOTShapeGroupData *) override {}
+    void visit(LOTShapeData *) override {}
+    void visit(LOTRectData *) override {}
+    void visit(LOTEllipseData *) override {}
+    void visit(LOTTrimData *) override {}
+    void visit(LOTRepeaterData *) override { mRepeaterFound = true; }
+    void visit(LOTFillData *) override {}
+    void visit(LOTStrokeData *) override {}
+    void visit(LOTPolystarData *) override {}
+    void visitChildren(LOTGroupData *obj) override
     {
         for (auto child : obj->mChildren) {
             child.get()->accept(this);

diff --git a/src/lottie/lottieparser.cpp b/src/lottie/lottieparser.cpp
index be8dbc9..5a0b05f 100644 (file)
--- a/src/lottie/lottieparser.cpp
+++ b/src/lottie/lottieparser.cpp
@@ -1856,13 +1856,13 @@ void LottieParserImpl::parseProperty(LOTAnimatable<T> &obj)
 
 class LOTDataInspector : public LOTDataVisitor {
 public:
-    void visit(LOTCompositionData *obj)
+    void visit(LOTCompositionData *obj) override
     {
         vDebug << "[COMP_START:: static:" << obj->isStatic()
                << " v:" << obj->mVersion << " [{ stFm endFm fmRate } { "
                << obj->mStartFrame << " " << obj->mEndFrame << " }]\n";
     }
-    void visit(LOTLayerData *obj)
+    void visit(LOTLayerData *obj) override
     {
         vDebug << "[LAYER_START:: type:" << layerType(obj->mLayerType)
                << " id:" << obj->mId << " Pid:" << obj->mParentId
@@ -1871,57 +1871,57 @@ public:
                << obj->mOutFrame << " " << obj->mStartFrame << " "
                << obj->mTimeStreatch << " }]";
     }
-    void visit(LOTTransformData *t)
+    void visit(LOTTransformData *t) override
     {
         vDebug << "[TRANSFORM: static: " << t->isStatic() << " ]";
     }
-    void visit(LOTShapeGroupData *o)
+    void visit(LOTShapeGroupData *o) override
     {
         vDebug << "[GROUP_START:: static:" << o->isStatic() << "]";
     }
-    void visit(LOTShapeData *s)
+    void visit(LOTShapeData *s) override
     {
         vDebug << "[SHAPE: static:" << s->isStatic() << "]";
     }
-    void visit(LOTRectData *r)
+    void visit(LOTRectData *r) override
     {
         vDebug << "[RECT: static:" << r->isStatic() << "]";
     }
-    void visit(LOTEllipseData *e)
+    void visit(LOTEllipseData *e) override
     {
         vDebug << "[ELLIPSE: static:" << e->isStatic() << "]";
     }
-    void visit(LOTPolystarData *e)
+    void visit(LOTPolystarData *e) override
     {
         vDebug << "[POLYSTAR: static:" << e->isStatic() << "]";
     }
-    void visit(LOTTrimData *t)
+    void visit(LOTTrimData *t) override
     {
         vDebug << "[TRIM: static: " << t->isStatic() << " ]";
     }
-    void visit(LOTRepeaterData *r)
+    void visit(LOTRepeaterData *r) override
     {
         vDebug << "[REPEATER: static:" << r->isStatic() << "]";
     }
-    void visit(LOTFillData *f)
+    void visit(LOTFillData *f) override
     {
         vDebug << "[FILL: static:" << f->isStatic() << "]";
     }
-    void visit(LOTGFillData *f)
+    void visit(LOTGFillData *f) override
     {
         vDebug << "[GFILL: static:" << f->isStatic()
                << " ty:" << f->mGradientType << " s:" << f->mStartPoint.value(0)
                << " e:" << f->mEndPoint.value(0) << "]";
     }
-    void visit(LOTGStrokeData *f)
+    void visit(LOTGStrokeData *f) override
     {
         vDebug << "[GSTROKE: static:" << f->isStatic() << "]";
     }
-    void visit(LOTStrokeData *s)
+    void visit(LOTStrokeData *s) override
     {
         vDebug << "[STROKE: static:" << s->isStatic() << "]";
     }
-    void visitChildren(LOTGroupData *obj)
+    void visitChildren(LOTGroupData *obj) override
     {
         for (auto child : obj->mChildren) child.get()->accept(this);
         switch (obj->type()) {

diff --git a/src/vector/vdebug.cpp b/src/vector/vdebug.cpp
index 22e131b..2d8b3a8 100644 (file)
--- a/src/vector/vdebug.cpp
+++ b/src/vector/vdebug.cpp
@@ -397,7 +397,7 @@ public:
         static_assert(sizeof(Item) == 256, "Unexpected size != 256");
     }
 
-    ~RingBuffer()
+    ~RingBuffer() override
     {
         for (size_t i = 0; i < m_size; ++i) {
             m_ring[i].~Item();