[Tizen] Rename functions, variables, etc related to policy decision.

Originally 'policy,newwindow,decide' is processed, it is not
expected. Actually 'policy,response,decide' need be processed.
This patch is to rename some functions, callbacks, variables, etc.

Change-Id: Ia0804542589ed10028a259f21f633142b4b276c7

diff --git a/dali-extension/web-engine-chromium/tizen-web-engine-chromium.cpp b/dali-extension/web-engine-chromium/tizen-web-engine-chromium.cpp
index e568a3d..a3b3a74 100755 (executable)
--- a/dali-extension/web-engine-chromium/tizen-web-engine-chromium.cpp
+++ b/dali-extension/web-engine-chromium/tizen-web-engine-chromium.cpp
@@ -256,8 +256,8 @@ public:
     evas_object_smart_callback_add(mWebView, "form,repost,warning,show",
                                    &WebViewContainerForDali::OnFormRepostDecisionRequest,
                                    &mClient);
-    evas_object_smart_callback_add(mWebView, "policy,newwindow,decide",
-                                   &WebViewContainerForDali::OnNewWindowPolicyDecided,
+    evas_object_smart_callback_add(mWebView, "policy,response,decide",
+                                   &WebViewContainerForDali::OnResponsePolicyDecided,
                                    &mClient);
     evas_object_smart_callback_add(mWebView, "request,certificate,confirm",
                                    &WebViewContainerForDali::OnCertificateConfirmRequest,
@@ -936,12 +936,12 @@ private:
     return client->GeolocationPermission(host, protocol);
   }
 
-  static void OnNewWindowPolicyDecided(void* data, Evas_Object*, void* policy)
+  static void OnResponsePolicyDecided(void* data, Evas_Object*, void* policy)
   {
     auto client = static_cast<WebViewContainerClient*>(data);
     Ewk_Policy_Decision* policyDecision = static_cast<Ewk_Policy_Decision*>(policy);
     std::shared_ptr<Dali::WebEnginePolicyDecision> webPolicyDecision(new TizenWebEnginePolicyDecision(policyDecision));
-    client->NewWindowPolicyDecided(std::move(webPolicyDecision));
+    client->ResponsePolicyDecided(std::move(webPolicyDecision));
   }
 
   static void OnCertificateConfirmRequest(void* data, Evas_Object*, void* eventInfo)
@@ -1526,12 +1526,11 @@ Dali::WebEngineBackForwardList& TizenWebEngineChromium::GetBackForwardList() con
 
 std::unique_ptr<Dali::WebEngineHitTest> TizenWebEngineChromium::CreateHitTest(int32_t x, int32_t y, Dali::WebEngineHitTest::HitTestMode mode)
 {
-  std::unique_ptr<Dali::WebEngineHitTest> webHitTest;
-  if (!mWebViewContainer)
+  if (mWebViewContainer)
   {
-    return webHitTest;
+    return mWebViewContainer->CreateHitTest(x, y, mode);
   }
-  return mWebViewContainer->CreateHitTest(x, y, mode);
+  return nullptr;
 }
 
 bool TizenWebEngineChromium::CreateHitTestAsynchronously(int32_t x, int32_t y, Dali::WebEngineHitTest::HitTestMode mode, Dali::WebEnginePlugin::WebEngineHitTestCreatedCallback callback)
@@ -1852,9 +1851,9 @@ Dali::WebEnginePlugin::WebEngineConsoleMessageSignalType& TizenWebEngineChromium
   return mConsoleMessageSignal;
 }
 
-Dali::WebEnginePlugin::WebEnginePolicyDecisionSignalType& TizenWebEngineChromium::PolicyDecisionSignal()
+Dali::WebEnginePlugin::WebEngineResponsePolicyDecisionSignalType& TizenWebEngineChromium::ResponsePolicyDecisionSignal()
 {
-  return mPolicyDecisionSignal;
+  return mResponsePolicyDecisionSignal;
 }
 
 Dali::WebEnginePlugin::WebEngineCertificateSignalType& TizenWebEngineChromium::CertificateConfirmSignal()
@@ -1963,12 +1962,12 @@ void TizenWebEngineChromium::OnConsoleMessage(std::shared_ptr<Dali::WebEngineCon
   }
 }
 
-void TizenWebEngineChromium::NewWindowPolicyDecided(std::shared_ptr<Dali::WebEnginePolicyDecision> decision)
+void TizenWebEngineChromium::ResponsePolicyDecided(std::shared_ptr<Dali::WebEnginePolicyDecision> decision)
 {
-  DALI_LOG_RELEASE_INFO("#NewWindowPolicyDecided.\n");
-  if (!mPolicyDecisionSignal.Empty())
+  DALI_LOG_RELEASE_INFO("#ResponsePolicyDecided.\n");
+  if (!mResponsePolicyDecisionSignal.Empty())
   {
-    mPolicyDecisionSignal.Emit(std::move(decision));
+    mResponsePolicyDecisionSignal.Emit(std::move(decision));
   }
 }
 

diff --git a/dali-extension/web-engine-chromium/tizen-web-engine-chromium.h b/dali-extension/web-engine-chromium/tizen-web-engine-chromium.h
index 1b99a8a..f289e90 100755 (executable)
--- a/dali-extension/web-engine-chromium/tizen-web-engine-chromium.h
+++ b/dali-extension/web-engine-chromium/tizen-web-engine-chromium.h
@@ -115,7 +115,7 @@ public:
    * policy would be decided.
    * @param [in] decision Policy need be decided.
    */
-  virtual void NewWindowPolicyDecided(std::shared_ptr<Dali::WebEnginePolicyDecision> decision) = 0;
+  virtual void ResponsePolicyDecided(std::shared_ptr<Dali::WebEnginePolicyDecision> decision) = 0;
 
   /**
    * @brief Callback function to be called by WebViewContainer when certificate
@@ -698,9 +698,9 @@ public:
   Dali::WebEnginePlugin::WebEngineConsoleMessageSignalType& ConsoleMessageSignal() override;
 
   /**
-   * @copydoc Dali::WebEnginePlugin::PolicyDecisionSignal()
+   * @copydoc Dali::WebEnginePlugin::ResponsePolicyDecisionSignal()
    */
-  Dali::WebEnginePlugin::WebEnginePolicyDecisionSignalType& PolicyDecisionSignal() override;
+  Dali::WebEnginePlugin::WebEngineResponsePolicyDecisionSignalType& ResponsePolicyDecisionSignal() override;
 
   /**
    * @copydoc Dali::WebEnginePlugin::CertificateConfirmSignal()
@@ -765,9 +765,9 @@ public:
   void RequestFormRepostDecision(std::shared_ptr<Dali::WebEngineFormRepostDecision> decision) override;
 
   /**
-   * @copydoc Dali::Plugin::WebViewContainerClient::NewWindowPolicyDecided()
+   * @copydoc Dali::Plugin::WebViewContainerClient::ResponsePolicyDecided()
    */
-  void NewWindowPolicyDecided(std::shared_ptr<Dali::WebEnginePolicyDecision> policy) override;
+  void ResponsePolicyDecided(std::shared_ptr<Dali::WebEnginePolicyDecision> policy) override;
 
   /**
    * @copydoc Dali::Plugin::WebViewContainerClient::UrlChanged()
@@ -872,7 +872,7 @@ private:
   Dali::WebEnginePlugin::WebEngineFrameRenderedSignalType           mFrameRenderedSignal;
   Dali::WebEnginePlugin::WebEngineRequestInterceptorSignalType      mRequestInterceptorSignal;
   Dali::WebEnginePlugin::WebEngineConsoleMessageSignalType          mConsoleMessageSignal;
-  Dali::WebEnginePlugin::WebEnginePolicyDecisionSignalType          mPolicyDecisionSignal;
+  Dali::WebEnginePlugin::WebEngineResponsePolicyDecisionSignalType  mResponsePolicyDecisionSignal;
   Dali::WebEnginePlugin::WebEngineCertificateSignalType             mCertificateConfirmSignal;
   Dali::WebEnginePlugin::WebEngineCertificateSignalType             mSslCertificateChangedSignal;
   Dali::WebEnginePlugin::WebEngineHttpAuthHandlerSignalType         mHttpAuthHandlerSignal;

diff --git a/dali-extension/web-engine-chromium/tizen-web-engine-context.h b/dali-extension/web-engine-chromium/tizen-web-engine-context.h
index 70daba2..acf9f3f 100755 (executable)
--- a/dali-extension/web-engine-chromium/tizen-web-engine-context.h
+++ b/dali-extension/web-engine-chromium/tizen-web-engine-context.h
@@ -102,7 +102,7 @@ public:
   void DeleteAllWebStorage() override;
 
   /**
-   * @copydoc Dali::WebEngineContext::DeleteWebStorageOrigin()
+   * @copydoc Dali::WebEngineContext::DeleteWebStorage()
    */
   bool DeleteWebStorage(WebEngineSecurityOrigin& origin) override;
 
@@ -152,12 +152,12 @@ public:
   std::string GetContextCertificateFile() const override;
 
   /**
-   * @copydoc Dali::WebEngineContext::SetContextTizenAppId()
+   * @copydoc Dali::WebEngineContext::SetContextAppId()
    */
   void SetContextAppId(const std::string& appID) override;
 
   /**
-   * @copydoc Dali::WebEngineContext::SetContextTizenAppVersion()
+   * @copydoc Dali::WebEngineContext::SetContextAppVersion()
    */
   bool SetContextAppVersion(const std::string& appVersion) override;
 
@@ -207,7 +207,7 @@ public:
   bool DeleteAllWebIndexedDatabase() override;
 
   /**
-   * @copydoc Dali::WebEngineContext::FreeFormPasswordDataList()
+   * @copydoc Dali::WebEngineContext::DeleteFormPasswordDataList()
    */
   void DeleteFormPasswordDataList(const std::vector<std::string>& list) override;
 
@@ -239,7 +239,7 @@ public:
   std::string GetProxyBypassRule() const override;
 
   /**
-   * @copydoc Dali::WebEngineContext::NotifyLowMemory()
+   * @copydoc Dali::WebEngineContext::FreeUnusedMemory()
    */
   bool FreeUnusedMemory() override;
 

diff --git a/dali-extension/web-engine-lwe/tizen-web-engine-lwe.h b/dali-extension/web-engine-lwe/tizen-web-engine-lwe.h
index dad7bfa..88d4e04 100755 (executable)
--- a/dali-extension/web-engine-lwe/tizen-web-engine-lwe.h
+++ b/dali-extension/web-engine-lwe/tizen-web-engine-lwe.h
@@ -547,11 +547,11 @@ public:
   }
 
   /**
-   * @copydoc Dali::WebEnginePlugin::PolicyDecisionSignal()
+   * @copydoc Dali::WebEnginePlugin::ResponsePolicyDecisionSignal()
    */
-  Dali::WebEnginePlugin::WebEnginePolicyDecisionSignalType& PolicyDecisionSignal() override
+  Dali::WebEnginePlugin::WebEngineResponsePolicyDecisionSignalType& ResponsePolicyDecisionSignal() override
   {
-    return mPolicyDecisionSignal;
+    return mResponsePolicyDecisionSignal;
   }
 
   /**
@@ -648,7 +648,7 @@ private:
   Dali::WebEnginePlugin::WebEngineFrameRenderedSignalType           mFrameRenderedSignal;
   Dali::WebEnginePlugin::WebEngineRequestInterceptorSignalType      mRequestInterceptorSignal;
   Dali::WebEnginePlugin::WebEngineConsoleMessageSignalType          mConsoleMessageSignal;
-  Dali::WebEnginePlugin::WebEnginePolicyDecisionSignalType          mPolicyDecisionSignal;
+  Dali::WebEnginePlugin::WebEngineResponsePolicyDecisionSignalType  mResponsePolicyDecisionSignal;
   Dali::WebEnginePlugin::WebEngineCertificateSignalType             mCertificateConfirmSignal;
   Dali::WebEnginePlugin::WebEngineCertificateSignalType             mSslCertificateChangedSignal;
   Dali::WebEnginePlugin::WebEngineHttpAuthHandlerSignalType         mHttpAuthHandlerSignal;