testsuite : check return value of API properly. 28/212928/1
authorSeungbae Shin <seungbae.shin@samsung.com>
Wed, 28 Aug 2019 07:35:43 +0000 (16:35 +0900)
committerSeungbae Shin <seungbae.shin@samsung.com>
Wed, 28 Aug 2019 07:35:43 +0000 (16:35 +0900)
[Version] 0.5.39
[Issue Type] Coverity

Change-Id: I0a9450ca656b64d579591f367be74d15d2a6caf7

packaging/capi-media-sound-manager.spec
test/sound_manager_test.c

index b310786f4b715a692bed569b9d7b49ea09f2fbbf..c200520fcea68cee05f66edd5f9f8de492d64f3b 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-sound-manager
 Summary:    Sound Manager library
-Version:    0.5.38
+Version:    0.5.39
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 130995076d6e79aa857fe34aec9d756dce61ee40..8e2f266d4702b2c183a4b5ad268c292ee4b976d1 100644 (file)
@@ -1770,20 +1770,25 @@ static void interpret(char *cmd)
                                break;
                        }
 
-                       sound_manager_get_device_list(SOUND_DEVICE_TYPE_INTERNAL_MASK, &device_list);
-                       while (!sound_manager_get_next_device(device_list, &device)) {
-                               if (!sound_manager_get_device_id(device, &id)) {
-                                       if (in_device_id && id == in_device_id) {
-                                               sound_manager_get_device_type(device, &type);
-                                               g_print("preferred [ IN] device type[%s], id[%d]\n", g_device_type_str[type], in_device_id);
-                                       }
-                                       if (out_device_id && id == out_device_id) {
-                                               sound_manager_get_device_type(device, &type);
-                                               g_print("preferred [OUT] device type[%s], id[%d]\n", g_device_type_str[type], out_device_id);
+                       ret = sound_manager_get_device_list(SOUND_DEVICE_TYPE_INTERNAL_MASK, &device_list);
+                       if (ret) {
+                               g_print("failed to get device list(), ret(0x%x)\n", ret);
+                       } else {
+                               while (!sound_manager_get_next_device(device_list, &device)) {
+                                       if (!sound_manager_get_device_id(device, &id)) {
+                                               if (in_device_id && id == in_device_id) {
+                                                       if (sound_manager_get_device_type(device, &type) == SOUND_MANAGER_ERROR_NONE)
+                                                               g_print("preferred [ IN] device type[%s], id[%d]\n", g_device_type_str[type], in_device_id);
+                                               }
+                                               if (out_device_id && id == out_device_id) {
+                                                       if (sound_manager_get_device_type(device, &type) == SOUND_MANAGER_ERROR_NONE)
+                                                               g_print("preferred [OUT] device type[%s], id[%d]\n", g_device_type_str[type], out_device_id);
+                                               }
                                        }
                                }
+
+                               sound_manager_free_device_list(device_list);
                        }
-                       sound_manager_free_device_list(device_list);
                }
                reset_menu_state();
                break;