gkdbus: fix special rule for name signals 24/131524/5
authorAdrian Szyndela <adrian.s@samsung.com>
Mon, 29 May 2017 13:48:26 +0000 (15:48 +0200)
committerHyotaek Shim <hyotaek.shim@samsung.com>
Thu, 1 Jun 2017 09:16:24 +0000 (09:16 +0000)
Sender_unique_name can never be NULL. However, it is checked
if it is NULL. It should be tested for emptiness,
but not for being NULL, but for being an empty string.

Change-Id: I2c968d614f34d7d388a629e0ce4bc9148b7e148e

gio/gdbusconnection.c

index a9d75d4..e0181ac 100755 (executable)
@@ -4394,9 +4394,9 @@ g_dbus_connection_signal_subscribe_with_ref (GDBusConnection             *connec
         {
           gboolean special_rule = FALSE;
           /* rule for special message */
-          if (!signal_data->sender_unique_name || g_strcmp0 (signal_data->sender_unique_name, "org.freedesktop.DBus") == 0)
+          if (!signal_data->sender_unique_name[0] || g_strcmp0 (signal_data->sender_unique_name, "org.freedesktop.DBus") == 0)
             {
-              if (signal_data->sender_unique_name)
+              if (signal_data->sender_unique_name[0])  /* So, this is org.freedesktop.DBus */
                 special_rule = TRUE;
               if (!signal_data->object_path || g_strcmp0 (signal_data->object_path, "/org/freedesktop/DBus") == 0)
                 {