[Alarm] Fixed Coverity issue and undefined behaviour 21/228921/1
authorPiotr Kosko <p.kosko@samsung.com>
Thu, 26 Mar 2020 07:41:59 +0000 (08:41 +0100)
committerPiotr Kosko <p.kosko@samsung.com>
Thu, 26 Mar 2020 07:42:03 +0000 (08:42 +0100)
[Coverity] 1134493

Change-Id: I3c9aa41a640efc6ca001ea96978374994a88e029

src/alarm/alarm_manager.cc

index c9690ce..7a23181 100644 (file)
@@ -365,7 +365,11 @@ PlatformResult AlarmManager::GetAlarm(int id, picojson::object& obj) {
 
     int interval = 0;
 
-    app_control_get_extra_data(app_control, kAlarmAbsoluteRecurrenceTypeKey, &alarm_type);
+    ret = app_control_get_extra_data(app_control, kAlarmAbsoluteRecurrenceTypeKey, &alarm_type);
+    if (APP_CONTROL_ERROR_NONE != ret) {
+      return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Unknown error occurred.",
+                                ("Getting data failed: %d (%s)", ret, get_error_message(ret)));
+    }
 
     if (!strcmp(alarm_type, kAlarmAbsoluteReccurrenceTypeInterval)) {
       ret = alarm_get_scheduled_period(id, &interval);