turn on the utests bulding and fix svace issues 21/160621/4
authorKonstantin Drabeniuk <k.drabeniuk@samsung.com>
Fri, 17 Nov 2017 10:56:10 +0000 (12:56 +0200)
committerKonstantin Drabeniuk <k.drabeniuk@samsung.com>
Fri, 17 Nov 2017 10:56:10 +0000 (12:56 +0200)
Change-Id: I1c8288cb962725462cc71b6621740dc81075274d
Signed-off-by: Konstantin Drabeniuk <k.drabeniuk@samsung.com>
packaging/libtdm.spec
utests/src/ut_tdm_layer.cpp
utests/src/ut_tdm_pp.cpp
utests/src/ut_tdm_vblank.cpp

index 80787c9..6e68d87 100644 (file)
@@ -1,4 +1,4 @@
-%define UTEST_PACKAGE 0
+%define UTEST_PACKAGE 1
 
 Name:           libtdm
 Version:        1.8.3
index 0d629f6..ae6855d 100644 (file)
@@ -87,11 +87,10 @@ protected:
                tbm_fd = tbm_drm_helper_get_fd();
                ASSERT_TRUE(tdm_display_get_output_count(dpy, &output_count) == TDM_ERROR_NONE);
 
-               tdm_layer_output_idx = (int *) calloc(output_count, sizeof(int));
-               ASSERT_FALSE(NULL == tdm_layer_output_idx);
-
                preferred_mode_array = (const tdm_output_mode **)calloc(output_count, sizeof(tdm_output_mode *));
                ASSERT_FALSE(NULL == preferred_mode_array);
+               if (!preferred_mode_array)
+                       return;
 
                for (int i = 0; i < output_count; i++) {
                        tdm_output *output = tdm_display_get_output(dpy, i, &error);
@@ -132,6 +131,10 @@ protected:
 
                        ASSERT_FALSE(NULL == tdm_layer_array);
 
+                       tdm_layer_output_idx = (int *) realloc(tdm_layer_output_idx,
+                                                                                       (layer_count + temp_layer_count)*sizeof(int));
+                       ASSERT_FALSE(NULL == tdm_layer_output_idx);
+
                        for (int k = layer_count; k < (layer_count + temp_layer_count); k++) {
                                tdm_layer_array[k] = tdm_output_get_layer(output, k, &error);
                                tdm_layer_output_idx[k] = i;
index 2ff78c9..3e59f3c 100644 (file)
@@ -409,7 +409,7 @@ void UtPpDoneHandler(tdm_pp *pp, tbm_surface_h src,
                                                        tbm_surface_h dst, void *user_data)
 {
        TDMPPCommit *pp_commit = (TDMPPCommit *)user_data;
-       bool src_valid, dst_valid;
+       bool src_valid = false, dst_valid = false;
 
        if (!pp_commit)
                return;
index b2cacdc..8f61790 100644 (file)
@@ -1122,14 +1122,14 @@ void *UtWaitVblankThreadHndl(void *ptr)
        if (error != TDM_ERROR_NONE)
                vblankWait->utWaitVblankThreadHndlResult = 0;
        else
-               vblankWait->utWaitVblankThreadHndlResult = 0;
+               vblankWait->utWaitVblankThreadHndlResult = 1;
 
        return NULL;
 }
 
 TEST_F(TDMVblankWait, VblankWaitFailInOtherThread)
 {
-       pthread_t thread;
+       pthread_t thread = 0;
 
        SKIP_FLAG(has_output);
 
@@ -1793,14 +1793,14 @@ void *UtWaitVblankSeqThreadHndl(void *ptr)
        if (error != TDM_ERROR_NONE)
                vblankWait->utWaitVblankSeqThreadHndlResult = 0;
        else
-               vblankWait->utWaitVblankSeqThreadHndlResult = 0;
+               vblankWait->utWaitVblankSeqThreadHndlResult = 1;
 
        return NULL;
 }
 
 TEST_F(TDMVblankWait, VblankWaitSeqFailInOtherThread)
 {
-       pthread_t thread;
+       pthread_t thread = 0;
 
        SKIP_FLAG(has_output);