ticker: perfrom additional null-check

Fix potential issue spotted by PVS-Studio static analyzer and
described on https://www.viva64.com/en/b/0519/.
The _ticker_view_create may call _ticker_window_create with
invalid parameter. This situation cannot occur in current
code since ad is always valid pointer.

However function may cause crashes when some refactoring
will be applied without additional null-checking of 'ad' param.

Change-Id: I409ce3774390f9fa67ed26b7b9a8c34c5a7c077e

diff --git a/src/ticker.c b/src/ticker.c
index bd35b7c115d0c00b1994cf3c889c04612b593c30..4445c4097ff40b61450168d7bc15fa7b489fea45 100644 (file)
--- a/src/ticker.c
+++ b/src/ticker.c
@@ -585,7 +585,7 @@ static void _ticker_window_destroy(void)
 
 static int _ticker_view_create(void)
 {
-       if (!ticker.win)
+       if (!ticker.win && ticker.ad)
                ticker.win = _ticker_window_create(ticker.ad);
        if (!ticker.layout)
                ticker.layout = _ticker_layout_create(ticker.win);