Fix potential memory scribbling issue in Render::UniformBuffer 19/254819/1
authorRichard Huang <r.huang@samsung.com>
Tue, 9 Mar 2021 15:40:23 +0000 (15:40 +0000)
committerRichard Huang <r.huang@samsung.com>
Tue, 9 Mar 2021 15:40:23 +0000 (15:40 +0000)
Change-Id: If9bc93b3ab46919432844b9f8a33fef01968edf8

dali/internal/render/renderers/uniform-buffer-manager.cpp

index 0828ea5..828cfae 100644 (file)
@@ -125,10 +125,10 @@ void UniformBuffer::Write(const void* data, uint32_t size, uint32_t dstOffset)
 
   if(mMemory)
   {
-    void* ptr = mMemory->LockRegion(0, size);
-    if(dstOffset + size < mSize)
+    void* ptr = mMemory->LockRegion(dstOffset, size);
+    if(ptr && dstOffset + size < mSize)
     {
-      memcpy(reinterpret_cast<char*>(ptr) + dstOffset, data, size);
+      memcpy(ptr, data, size);
     }
     mMemory->Unlock(true);
   }