ENDIF(NOT CMAKE_BUILD_TYPE)
# Compiler flags
-SET(EXTRA_FLAGS "-Wall -Wextra")
+SET(EXTRA_FLAGS "-Wall -Wextra -Werror -Wnon-virtual-dtor")
SET(EXTRA_OPTIMIZATION_FLAGS "-Wl,--gc-sections -flto -fmerge-all-constants")
SET(CMAKE_C_FLAGS_PROFILING "-O2 ${EXTRA_FLAGS}")
using Dependency = std::tuple<std::string, std::string, std::string>;
explicit ArchiveInfo(std::string path) : path_(std::move(path)) { }
+ virtual ~ArchiveInfo() = default;
virtual bool LoadArchiveInfo() = 0;
bool GetPkgDetailInfo(package_manager_pkg_detail_info_t* info);
*/
class PkgmgrInstallerInterface {
public:
+ virtual ~PkgmgrInstallerInterface() = default;
+
virtual bool CreatePkgMgrInstaller(pkgmgr_installer** installer,
InstallationMode* mode) = 0;
virtual bool ShouldCreateSignal() const = 0;
class SmokeInstallerFactory {
public:
using AppInstallerPtr = std::unique_ptr<common_installer::AppInstaller>;
+ virtual ~SmokeInstallerFactory() = default;
virtual AppInstallerPtr CreateInstaller(
int idx, common_installer::PkgMgrPtr pkgmgr) const = 0;
virtual AppInstallerPtr CreateFailExpectedInstaller(
std::string uid,
RequestResult mode = RequestResult::NORMAL)
: factory_(std::move(factory)), uid_str_(uid), mode_(mode) {}
- virtual ~BackendInterface() {}
+ virtual ~BackendInterface() = default;
void TestRollbackAfterEachStep(int argc, const char* argv[],
std::function<bool()> validator) const;
UnKnown
};
+ virtual ~SmokeTestHelperRunner() = default;
Result InstallWithSubprocess(const bf::path& path, uid_t uid) const;
Result MountInstallWithSubprocess(const bf::path& path, uid_t uid) const;
Result RecoveryWithSubprocess(const bf::path& path, uid_t uid) const;