edje_signal: reduce member count when deleted edje_signal_callback is found

    Summary:
     - when deleted callback is found _edje_signal_callback_move_last() is called
       in order to pack match array.
     - during _edje_signal_callback_move_last() index skips when another deleted
       callback is found, but does not reduce members_count.
     - this duplicates a remaining callback and calls the callback twice.

    Test Plan:
    1. add multiple edje_signal_callback by edje_object_signal_callback_add()
                  which have the same source, signal, func but different data.
               2. delete first and last callback by
                  edje_object_signal_callback_del/edje_object_signal_callback_del_full.
               3. emit edje_signal.
               4. observe one callback is called twice.

    Reviewers: SanghyeonLee, conr2d, jpeg

    Subscribers: cedric, jpeg

    Differential Revision: https://phab.enlightenment.org/D4985

Change-Id: Ie6c8f2f05c7c4bdeb1ed692960588ab0b7244bfb
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>

diff --git a/src/lib/edje/edje_signal.c b/src/lib/edje/edje_signal.c
index f8988af..d856106 100644 (file)
--- a/src/lib/edje/edje_signal.c
+++ b/src/lib/edje/edje_signal.c
@@ -359,6 +359,11 @@ _edje_signal_callback_move_last(Edje_Signal_Callback_Group *gp,
              gp->custom_data[i] = gp->custom_data[j];
              return;
           }
+        else
+          {
+             _edje_signal_callback_unset(gp, j);
+             m->matches_count--;
+          }
      }
 }