Fix uninitialized value issue detected by static analysis tool 18/113618/1
authorJihoon Kim <jihoon48.kim@samsung.com>
Wed, 8 Feb 2017 07:55:01 +0000 (16:55 +0900)
committerJihoon Kim <jihoon48.kim@samsung.com>
Wed, 8 Feb 2017 07:55:01 +0000 (16:55 +0900)
Change-Id: Iecc69b1541cf1feae7ecdbce1f0b9992e33b7ca6
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
src/MicEffector.cpp
src/candidate/efl/candidate-multiline-efl.cpp

index 6e1ec2e..38e9c17 100644 (file)
@@ -75,7 +75,8 @@ double cubic_easy_out(double index, double start, double end, double duration)
  *
  */
 MicEffector::MicEffector(Evas_Object *canvas, Evas_Object *layout, IMicEffector& effect)
-    : drawcount(0)
+    : startcount(0)
+    , drawcount(0)
     , forcestop(false)
     , started(false)
     , fake(false)
index 1852970..f2fd06f 100644 (file)
@@ -362,6 +362,15 @@ EflMultiLineCandidate::EflMultiLineCandidate(Evas_Object *window)
     m_screenHeight = 0;
     m_screenRatio = 1.0;
     m_window = window;
+    m_candidateScrollerBg = NULL;
+    m_candidateScroller = NULL;
+    m_candidateTable = NULL;
+    m_candidateMoreBtn = NULL;
+    m_candidateCloseBtn = NULL;
+    m_candidateMoreScrollerBg = NULL;
+    m_candidateMoreScroller = NULL;
+    m_candidateMoreTable = NULL;
+
     make_view();
     make_more_view();
     m_candidateFontName = string("Tizen");
@@ -372,18 +381,38 @@ EflMultiLineCandidate::EflMultiLineCandidate(Evas_Object *window)
 
 EflMultiLineCandidate::~EflMultiLineCandidate()
 {
-    elm_table_clear(m_candidateTable, EINA_TRUE);
-    elm_table_clear(m_candidateMoreTable, EINA_TRUE);
+    if (m_candidateTable)
+        elm_table_clear(m_candidateTable, EINA_TRUE);
+
+    if (m_candidateMoreTable)
+        elm_table_clear(m_candidateMoreTable, EINA_TRUE);
+
+    if (m_stringWidthCalObj)
+        evas_object_del(m_stringWidthCalObj);
+
+    if (m_candidateScrollerBg)
+        evas_object_del(m_candidateScrollerBg);
+
+    if (m_candidateScroller)
+        evas_object_del(m_candidateScroller);
+
+    if (m_candidateTable)
+        evas_object_del(m_candidateTable);
+
+    if (m_candidateMoreBtn)
+        evas_object_del(m_candidateMoreBtn);
+
+    if (m_candidateCloseBtn)
+        evas_object_del(m_candidateCloseBtn);
+
+    if (m_candidateMoreScrollerBg)
+        evas_object_del(m_candidateMoreScrollerBg);
+
+    if (m_candidateMoreScroller)
+        evas_object_del(m_candidateMoreScroller);
 
-    evas_object_del(m_stringWidthCalObj);
-    evas_object_del(m_candidateScrollerBg);
-    evas_object_del(m_candidateScroller);
-    evas_object_del(m_candidateTable);
-    evas_object_del(m_candidateMoreBtn);
-    evas_object_del(m_candidateCloseBtn);
-    evas_object_del(m_candidateMoreScrollerBg);
-    evas_object_del(m_candidateMoreScroller);
-    evas_object_del(m_candidateMoreTable);
+    if (m_candidateMoreTable)
+        evas_object_del(m_candidateMoreTable);
 }
 
 void