Fixed the dexter analysis issue.

 -self assignment issue, uninitialized variable, wrong comment

Change-Id: I02ad53f10dfe0a3ab7b0296f94f1e070de7997b3

diff --git a/ism/extras/efl_panel/isf_panel_efl.cpp b/ism/extras/efl_panel/isf_panel_efl.cpp
index 5394255..07f21d5 100644 (file)
--- a/ism/extras/efl_panel/isf_panel_efl.cpp
+++ b/ism/extras/efl_panel/isf_panel_efl.cpp
@@ -1988,7 +1988,7 @@ static void ui_candidate_window_adjust (void)
     if (!_candidate_window)
         return;
 
-    int x, y, width, height;
+    int x = 0, y = 0, width = 0, height = 0;
 
     /* Get candidate window size */
 #if HAVE_ECOREX
@@ -3506,8 +3506,6 @@ static void ui_settle_candidate_window (void)
         } else {
             if (ise_rect.height > 0 && spot_y + height2 > _screen_height - (int)ise_rect.height + nOffset) {
                 spot_y = _spot_location_top_y - height2;
-            } else {
-                spot_y = spot_y;
             }
         }
     }

diff --git a/ism/extras/efl_panel/websocketserver.cpp b/ism/extras/efl_panel/websocketserver.cpp
index d914d82..470640e 100644 (file)
--- a/ism/extras/efl_panel/websocketserver.cpp
+++ b/ism/extras/efl_panel/websocketserver.cpp
@@ -35,9 +35,7 @@
 #include "remote_input.h"
 
 #include <syslog.h>
-
 #include <signal.h>
-
 #include <libwebsockets.h>
 
 pthread_t g_ws_server_thread = (pthread_t)NULL;

diff --git a/ism/extras/efl_panel/websocketserver.h b/ism/extras/efl_panel/websocketserver.h
index a10b2be..f756d42 100644 (file)
--- a/ism/extras/efl_panel/websocketserver.h
+++ b/ism/extras/efl_panel/websocketserver.h
@@ -108,11 +108,11 @@ const std::string ISE_MESSAGE_COMMAND_STRINGS[] = {
     "commit_string", // ISE_MESSAGE_COMMAND_COMMIT_STRING,
     "update_preedit_string", // ISE_MESSAGE_COMMAND_UPDATE_PREEDIT_STRING,
     "send_key_event", // ISE_MESSAGE_COMMAND_SEND_KEY_EVENT,
-    "send_mouse_key", // ISE_MESSAGE_COMMAND_SEND_KEY_EVENT,
-    "send_mouse_move", // ISE_MESSAGE_COMMAND_SEND_KEY_EVENT,
-    "send_wheel_move", // ISE_MESSAGE_COMMAND_SEND_KEY_EVENT,
-    "send_air_input", // ISE_MESSAGE_COMMAND_SEND_KEY_EVENT,
-    "send_air_setting", // ISE_MESSAGE_COMMAND_SEND_KEY_EVENT,
+    "send_mouse_key", // ISE_MESSAGE_COMMAND_SEND_MOUSE_KEY,
+    "send_mouse_move", // ISE_MESSAGE_COMMAND_SEND_MOUSE_MOVE,
+    "send_wheel_move", // ISE_MESSAGE_COMMAND_SEND_WHEEL_MOVE,
+    "send_air_input", // ISE_MESSAGE_COMMAND_SEND_AIR_INPUT,
+    "send_air_setting", // ISE_MESSAGE_COMMAND_SEND_AIR_SETTING,
     "forward_key_event", // ISE_MESSAGE_COMMAND_FORWARD_KEY_EVENT,
     "set_keyboard_sizes", // ISE_MESSAGE_COMMAND_SET_KEYBOARD_SIZES,
     "login", // ISE_MESSAGE_COMMAND_LOGIN,