readers: initialize fd entities properly 08/273008/2
authorMichal Bloch <m.bloch@samsung.com>
Fri, 18 Mar 2022 16:22:41 +0000 (17:22 +0100)
committerMichal Bloch <m.bloch@samsung.com>
Tue, 29 Mar 2022 17:23:23 +0000 (19:23 +0200)
Set the FD inside to -1 (as opposed to 0).
If something fails during init, that FD gets closed.

Change-Id: Ic50cadabc7ca4ec514e40878d49df027e450e61c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
src/logger/reader_logger.c
src/logger/reader_pipe.c

index 0085d4c..8965589 100644 (file)
@@ -96,6 +96,9 @@ static struct reader_logger *reader_logger_alloc(void)
        if (!ret)
                return NULL;
 
+       init_fd_entity(&ret->common.fd_entity_sink  , NULL, NULL);
+       init_fd_entity(&ret->common.fd_entity_source, NULL, NULL);
+
        ret->buf_id = LOG_ID_INVALID;
        ret->common.service_reader = service_reader_logger;
 
index 021d934..052ea87 100644 (file)
@@ -63,6 +63,9 @@ static struct reader_pipe *reader_pipe_alloc(struct log_filter *filter, struct l
        if (!ret)
                return NULL;
 
+       init_fd_entity(&ret->common.fd_entity_sink  , NULL, NULL);
+       init_fd_entity(&ret->common.fd_entity_source, NULL, NULL);
+
        ret->common.service_reader = print_out_logs;
        ret->filter = log_filter_move(filter);
        ret->monitor = monitor;