Fix Coverity issues 05/196205/2
authorhj kim <backto.kim@samsung.com>
Wed, 26 Dec 2018 05:32:15 +0000 (14:32 +0900)
committerhj kim <backto.kim@samsung.com>
Wed, 26 Dec 2018 06:32:07 +0000 (15:32 +0900)
Change-Id: Ie63d53ed8665b43457a8a6201bdf909c9daef264

svc/media_controller_db_util.c
test/server_test/media_controller_server_test.c

index 5b97536..0ff0736 100755 (executable)
@@ -527,6 +527,7 @@ int mc_db_util_init_latest_server_table(void *handle)
                if (MC_STRING_VALID((const char *)sqlite3_column_text(stmt, 1))) {
                        latest_server_name = strdup((const char *)sqlite3_column_text(stmt, 1));
                        mc_debug("latest_server_name: %s", latest_server_name);
+                       break;
                }
                ret = sqlite3_step(stmt);
        }
@@ -538,6 +539,7 @@ int mc_db_util_init_latest_server_table(void *handle)
 
        /* Update server_state and playback_state to 0 */
        sql_str = sqlite3_mprintf("UPDATE '%q' SET server_state=%d, playback_state=%d;", latest_server_name, MC_SERVER_STATE_DEACTIVATE, MC_PLAYBACK_STATE_STOPPED);
+       MC_SAFE_FREE(latest_server_name);
        mc_retvm_if(!MC_STRING_VALID(sql_str), MEDIA_CONTROLLER_ERROR_INVALID_OPERATION, "SQL string is null");
 
        ret = mc_db_util_update_db(handle, sql_str);
index 12494ca..0cb89dc 100755 (executable)
@@ -301,6 +301,8 @@ static int __update_playlist(mc_server_h server, mc_playlist_update_mode_e mode)
                        mc_debug("Get playlist [%s]", playlist_name);
 
                        MC_SAFE_FREE(playlist_name);
+
+                       ret = mc_playlist_destroy(playlist_2);
                }
 
        } else {