Change parameter types for r-value reference

Change-Id: Id0010cd7cd20a6ae7d68afe5f76f269329c4c38b
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>

diff --git a/idlc/attribute.cc b/idlc/attribute.cc
index 19a3dc0..15db4ec 100644 (file)
--- a/idlc/attribute.cc
+++ b/idlc/attribute.cc
@@ -14,14 +14,17 @@
  * limitations under the License.
  */
 
+#include <utility>
+
 #include "idlc/attribute.h"
 #include "idlc/type.h"
 
 namespace tidl {
 
-Attribute::Attribute(const std::string& id, BaseType* type,
-                     const std::string& comments, unsigned line)
-    : id_(id), type_(type), comments_(comments), line_(line) {}
+Attribute::Attribute(std::string id, BaseType* type,
+                     std::string comments, unsigned line)
+    : id_(std::move(id)), type_(type), comments_(std::move(comments)),
+      line_(line) {}
 
 const std::string& Attribute::GetID() const {
   return id_;

diff --git a/idlc/attribute.h b/idlc/attribute.h
index fb3ea7c..f68b673 100644 (file)
--- a/idlc/attribute.h
+++ b/idlc/attribute.h
@@ -21,15 +21,15 @@
 #include <list>
 #include <memory>
 
-#include "type.h"
-#include "parameter.h"
+#include "idlc/type.h"
+#include "idlc/parameter.h"
 
 namespace tidl {
 
 class Attribute {
  public:
-  Attribute(const std::string& id, BaseType* type,
-            const std::string& comments, unsigned line);
+  Attribute(std::string id, BaseType* type,
+            std::string comments, unsigned line);
 
   const std::string& GetID() const;
   const BaseType& GetType() const;

diff --git a/idlc/block.cc b/idlc/block.cc
index 82a8bc4..2a3ee86 100644 (file)
--- a/idlc/block.cc
+++ b/idlc/block.cc
@@ -14,15 +14,17 @@
  * limitations under the License.
  */
 
+#include <utility>
+
 #include "idlc/type.h"
 #include "idlc/block.h"
 
 namespace tidl {
 
-Block::Block(const std::string& id, Block::Type type,
-             const std::string& comments, unsigned line)
-    : id_(id), type_(type), comments_(comments), line_(line) {
-}
+Block::Block(std::string id, Block::Type type,
+             std::string comments, unsigned line)
+    : id_(std::move(id)), type_(type), comments_(std::move(comments)),
+      line_(line) {}
 
 const std::string& Block::GetID() const {
   return id_;

diff --git a/idlc/block.h b/idlc/block.h
index 50c3054..bbdd026 100644 (file)
--- a/idlc/block.h
+++ b/idlc/block.h
@@ -20,7 +20,7 @@
 #include <string>
 #include <memory>
 
-#include "declaration.h"
+#include "idlc/declaration.h"
 
 namespace tidl {
 
@@ -31,7 +31,7 @@ class Block {
     TYPE_STRUCTURE,
   };
 
-  Block(const std::string& id, Block::Type type, const std::string& comments,
+  Block(std::string id, Block::Type type, std::string comments,
         unsigned line);
   virtual ~Block() = default;
 

diff --git a/idlc/declaration.cc b/idlc/declaration.cc
index 5963fef..39c9d83 100644 (file)
--- a/idlc/declaration.cc
+++ b/idlc/declaration.cc
@@ -14,19 +14,21 @@
  * limitations under the License.
  */
 
+#include <utility>
+
 #include "idlc/declaration.h"
 #include "idlc/type.h"
 #include "idlc/parameter.h"
 
 namespace tidl {
 
-Declaration::Declaration(const std::string& id, BaseType* ret_type,
-                         Parameters* params, const std::string& comments,
+Declaration::Declaration(std::string id, BaseType* ret_type,
+                         Parameters* params, std::string comments,
                          unsigned line, bool async)
-    : id_(id),
+    : id_(std::move(id)),
       ret_type_(ret_type),
       params_(params),
-      comments_(comments),
+      comments_(std::move(comments)),
       line_(line),
       async_(async) {}
 

diff --git a/idlc/declaration.h b/idlc/declaration.h
index 6ec9e47..6a37f0b 100644 (file)
--- a/idlc/declaration.h
+++ b/idlc/declaration.h
@@ -28,8 +28,8 @@ namespace tidl {
 
 class Declaration {
  public:
-  Declaration(const std::string& id, BaseType* ret_type, Parameters* params,
-              const std::string& comments, unsigned line, bool async = false);
+  Declaration(std::string id, BaseType* ret_type, Parameters* params,
+              std::string comments, unsigned line, bool async = false);
 
   const std::string& GetID() const;
   const BaseType& GetType() const;

diff --git a/idlc/generator.h b/idlc/generator.h
index f89e2b1..73d40e3 100644 (file)
--- a/idlc/generator.h
+++ b/idlc/generator.h
@@ -40,8 +40,8 @@ class Generator {
   virtual void OnInterfaceEnd(std::ofstream& stream, const std::string& id) = 0;
   virtual void OnDeclarationGen(std::ofstream& stream, const std::string& id,
                                 const Parameters& args,
-                               const BaseType& ret,
-                               const std::string& comments) = 0;
+                                const BaseType& ret,
+                                const std::string& comments) = 0;
   virtual void OnStructureBegin(std::ofstream& stream,
                                 const std::string& id,
                                 const std::string& comments) = 0;

diff --git a/idlc/interface.cc b/idlc/interface.cc
index e76c3ae..04dd466 100644 (file)
--- a/idlc/interface.cc
+++ b/idlc/interface.cc
@@ -14,16 +14,18 @@
  * limitations under the License.
  */
 
+#include <utility>
+
 #include "idlc/declaration.h"
 #include "idlc/interface.h"
 #include "idlc/block.h"
 
 namespace tidl {
 
-Interface::Interface(const std::string& id, Declarations* decls,
-                     const std::string& comments, unsigned line)
-    : Block::Block(id, Block::TYPE_INTERFACE, comments, line), decls_(decls) {
-}
+Interface::Interface(std::string id, Declarations* decls, std::string comments,
+                     unsigned line)
+    : Block::Block(std::move(id), Block::TYPE_INTERFACE,
+                   std::move(comments), line), decls_(decls) {}
 
 const Declarations& Interface::GetDeclarations() const {
   return *decls_;

diff --git a/idlc/interface.h b/idlc/interface.h
index a762ca9..b2da729 100644 (file)
--- a/idlc/interface.h
+++ b/idlc/interface.h
@@ -27,8 +27,8 @@ namespace tidl {
 
 class Interface : public Block {
  public:
-  Interface(const std::string& id, Declarations* decls,
-            const std::string& comments, unsigned line);
+  Interface(std::string id, Declarations* decls, std::string comments,
+            unsigned line);
 
   const Declarations& GetDeclarations() const;
 

diff --git a/idlc/parameter.cc b/idlc/parameter.cc
index 183d3b9..9634626 100644 (file)
--- a/idlc/parameter.cc
+++ b/idlc/parameter.cc
@@ -14,13 +14,15 @@
  * limitations under the License.
  */
 
+#include <utility>
+
 #include "idlc/parameter.h"
 #include "idlc/type.h"
 
 namespace tidl {
 
-Parameter::Parameter(const std::string& id, ParameterType* type, unsigned line)
-    : type_(type), id_(id), line_(line) {}
+Parameter::Parameter(std::string id, ParameterType* type, unsigned line)
+    : type_(type), id_(std::move(id)), line_(line) {}
 
 const std::string& Parameter::GetID() const {
   return id_;

diff --git a/idlc/parameter.h b/idlc/parameter.h
index 2d9dd94..c4feeaf 100644 (file)
--- a/idlc/parameter.h
+++ b/idlc/parameter.h
@@ -27,7 +27,7 @@ namespace tidl {
 
 class Parameter {
  public:
-  Parameter(const std::string& id, ParameterType* type, unsigned line);
+  Parameter(std::string id, ParameterType* type, unsigned line);
 
   const std::string& GetID() const;
   const ParameterType& GetParameterType() const;

diff --git a/idlc/structure.cc b/idlc/structure.cc
index 2f99af9..05535ab 100644 (file)
--- a/idlc/structure.cc
+++ b/idlc/structure.cc
@@ -14,16 +14,18 @@
  * limitations under the License.
  */
 
+#include <utility>
+
 #include "idlc/attribute.h"
 #include "idlc/structure.h"
 #include "idlc/block.h"
 
 namespace tidl {
 
-Structure::Structure(const std::string& id, Attributes* attrs,
-                     const std::string& comments, unsigned line)
-    : Block::Block(id, Block::TYPE_STRUCTURE, comments, line), attrs_(attrs) {
-}
+Structure::Structure(std::string id, Attributes* attrs, std::string comments,
+                     unsigned line)
+    : Block::Block(std::move(id), Block::TYPE_STRUCTURE,
+                   std::move(comments), line), attrs_(attrs) {}
 
 const Attributes& Structure::GetAttributes() const {
   return *attrs_;

diff --git a/idlc/structure.h b/idlc/structure.h
index d9dffa7..96cef6e 100644 (file)
--- a/idlc/structure.h
+++ b/idlc/structure.h
@@ -27,8 +27,8 @@ namespace tidl {
 
 class Structure : public Block {
  public:
-  Structure(const std::string& id, Attributes* attrs,
-            const std::string& comments, unsigned line);
+  Structure(std::string id, Attributes* attrs, std::string comments,
+            unsigned line);
 
   const Attributes& GetAttributes() const;
 

diff --git a/idlc/stub_gen.h b/idlc/stub_gen.h
index e28a26a..22b497c 100644 (file)
--- a/idlc/stub_gen.h
+++ b/idlc/stub_gen.h
@@ -31,12 +31,12 @@ class StubGen : public Generator {
 
   void OnDeclarationGen(std::ofstream& stream, const std::string& id,
                         const Parameters& args, const BaseType& ret,
-                       const std::string& comments) override;
+                        const std::string& comments) override;
   void OnInitGen(std::ofstream& stream) override;
   void OnFiniGen(std::ofstream& stream) override;
   void OnInterfaceBegin(std::ofstream& stream,
                         const std::string& id,
-                       const std::string& comments) override;
+                        const std::string& comments) override;
   void OnInterfaceEnd(std::ofstream& stream, const std::string& id) override;
   void OnAttributeGen(std::ofstream& stream, const std::string& id,
                       const BaseType& type,

diff --git a/idlc/type.cc b/idlc/type.cc
index 6f9595d..fec745b 100644 (file)
--- a/idlc/type.cc
+++ b/idlc/type.cc
@@ -15,17 +15,19 @@
  */
 
 #include <iostream>
+#include <utility>
+
 #include "idlc/type.h"
 
 namespace tidl {
 
-Token::Token(const std::string& name, const std::string& comments)
-    : name_(name), comments_(comments) {
+Token::Token(std::string name, std::string comments)
+    : name_(std::move(name)), comments_(std::move(comments)) {
 }
 
-BaseType::BaseType(const std::string& name, const std::string& comments,
+BaseType::BaseType(std::string name, std::string comments,
                    bool user_defined)
-    : Token(name, comments), user_defined_(user_defined) {
+    : Token(std::move(name), std::move(comments)), user_defined_(user_defined) {
 }
 
 void BaseType::SetMetaType(BaseType* type) {

diff --git a/idlc/type.h b/idlc/type.h
index 529eb0d..8a8e3ca 100644 (file)
--- a/idlc/type.h
+++ b/idlc/type.h
@@ -24,7 +24,7 @@ namespace tidl {
 
 class Token {
  public:
-  Token(const std::string& name, const std::string& comments);
+  Token(std::string name, std::string comments);
   virtual ~Token() = default;
 
   virtual std::string ToString() const { return name_; }
@@ -37,7 +37,7 @@ class Token {
 
 class BaseType : public Token {
  public:
-  explicit BaseType(const std::string& name, const std::string& comments,
+  explicit BaseType(std::string name, std::string comments,
                     bool user_defined = false);
   void SetMetaType(BaseType* type);
   const BaseType& GetMetaType() const {