gpio: rcar: Propagate errors from devm_request_irq()
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tue, 4 Jan 2022 15:36:15 +0000 (15:36 +0000)
committerBartosz Golaszewski <brgl@bgdev.pl>
Wed, 5 Jan 2022 08:57:34 +0000 (09:57 +0100)
The driver overrides the error code returned by devm_request_irq() to
-ENOENT. Switch to propagating the error code upstream.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-rcar.c

index 437baec..bd2e16d 100644 (file)
@@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev)
                goto err0;
        }
 
-       if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
-                            IRQF_SHARED, name, p)) {
+       ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
+                              IRQF_SHARED, name, p);
+       if (ret) {
                dev_err(dev, "failed to request IRQ\n");
-               ret = -ENOENT;
                goto err1;
        }