- Update test status file with fixed tests for ARM and add failing test tracked by...
authoriposva@chromium.org <iposva@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Fri, 12 Sep 2008 04:31:34 +0000 (04:31 +0000)
committeriposva@chromium.org <iposva@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Fri, 12 Sep 2008 04:31:34 +0000 (04:31 +0000)
- Remove debugging aid stop("Generate_ArgumentsAdaptorTrampoline - non-function call")
- Cleanup comment

Review URL: http://codereview.chromium.org/2801

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@290 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

src/builtins-arm.cc
src/top.cc
test/mjsunit/mjsunit.status

index 425a155195d76d6f1922bf53e23b86f454e5b964..107629c55d861ee0a1028ad0c5b94af728a7efc1 100644 (file)
@@ -644,7 +644,7 @@ void Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) {
   { Label invoke;
     __ tst(r1, r1);
     __ b(ne, &invoke);
-    __ stop("Generate_ArgumentsAdaptorTrampoline - non-function call");
+    //__ stop("Generate_ArgumentsAdaptorTrampoline - non-function call");
     __ mov(r2, Operand(0));  // expected arguments is 0 for CALL_NON_FUNCTION
     __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION);
     __ b(&enough);
index 236bdedb960dccefe070a6b3f9370124db28afe3..e9d8b6e5a05984f7316299ca7d45637c4007d6a6 100644 (file)
@@ -621,9 +621,6 @@ Object* Top::PromoteScheduledException() {
 }
 
 
-// TODO(1233523): Get rid of this hackish abstraction once all
-// JavaScript frames have a function associated with them.
-
 // NOTE: The stack trace frame iterator is an iterator that only
 // traverse proper JavaScript frames; that is JavaScript frames that
 // have proper JavaScript functions. This excludes the problematic
index 4289bc4637ad0a0b9fe886f10746b0353b40762d..7c3b707fe1cbd6b708759d99c82458da15a7a74b 100644 (file)
@@ -62,6 +62,6 @@ debug-step-stub-callfunction: FAIL
 debug-stepin-constructor: FAIL
 debug-step: FAIL
 regress/regress-998565: FAIL
-regress/regress-1081309: FAIL
-# Call as function does not always work on ARM port yet.
-number-string-index-call: FAIL
+
+# Issue 67: ARM fails in: Generate_ArgumentsAdaptorTrampoline - non-function call
+call-non-function-call: FAIL