mmc: sdhci-msm: Remove unnecessary error log
authorJia Yang <jiayang5@huawei.com>
Fri, 9 Apr 2021 01:54:24 +0000 (09:54 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 12 Apr 2021 11:52:47 +0000 (13:52 +0200)
devm_ioremap_resource() has recorded error log, so it's
unnecessary to record log again.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jia Yang <jiayang5@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20210409015424.3277212-1-jiayang5@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-msm.c

index 5e1da4d..d0767a5 100644 (file)
@@ -1864,7 +1864,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
        struct mmc_host *mmc = msm_host->mmc;
        struct device *dev = mmc_dev(mmc);
        struct resource *res;
-       int err;
 
        if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS))
                return 0;
@@ -1882,11 +1881,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
        }
 
        msm_host->ice_mem = devm_ioremap_resource(dev, res);
-       if (IS_ERR(msm_host->ice_mem)) {
-               err = PTR_ERR(msm_host->ice_mem);
-               dev_err(dev, "Failed to map ICE registers; err=%d\n", err);
-               return err;
-       }
+       if (IS_ERR(msm_host->ice_mem))
+               return PTR_ERR(msm_host->ice_mem);
 
        if (!sdhci_msm_ice_supported(msm_host))
                goto disable;