fimc-is: Fix bool-operation build warning with arm64 56/196856/2
authorHoegeun Kwon <hoegeun.kwon@samsung.com>
Mon, 7 Jan 2019 01:35:43 +0000 (10:35 +0900)
committerHoegeun Kwon <hoegeun.kwon@samsung.com>
Mon, 7 Jan 2019 03:49:57 +0000 (12:49 +0900)
This patch fixes following build warning caused  boolean expression:

  drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c: In function ‘flite_hw_enable_bns’:
  drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:187:45: warning: ‘~’ on a boolean expression [-Wbool-operation]
   #define FLITE_REG_BINNINGON_CLKGATE_ON(x)  (~(x) << 1)

  drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:241:9: note: in expansion of macro ‘FLITE_REG_BINNINGON_CLKGATE_ON’
    cfg |= FLITE_REG_BINNINGON_CLKGATE_ON(enable);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:187:45: note: did you mean to use logical not?
   #define FLITE_REG_BINNINGON_CLKGATE_ON(x)  (~(x) << 1)

  drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:241:9: note: in expansion of macro ‘FLITE_REG_BINNINGON_CLKGATE_ON’
    cfg |= FLITE_REG_BINNINGON_CLKGATE_ON(enable);

Change-Id: I9b16f36de1bb6d56d2eced55ea97697179dca2b7
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c

index ca45acb8087d5bff46e6c04f4b29c6c4791451ae..d4a1c94a0b36367c4adf52405e6c55298dd1695e 100644 (file)
@@ -238,7 +238,7 @@ static void flite_hw_enable_bns(void __iomem *base_reg, bool enable)
 
        /* enable */
        cfg = readl(base_reg + FLITE_REG_BINNINGON);
-       cfg |= FLITE_REG_BINNINGON_CLKGATE_ON(enable);
+       cfg |= FLITE_REG_BINNINGON_CLKGATE_ON((enable ? 1U : 0U));
        cfg |= FLITE_REG_BINNINGON_EN(enable);
        writel(cfg, base_reg + FLITE_REG_BINNINGON);
 }