Remove misleading check (dotnet/coreclr#7654)
authorDmitry-Me <Dmitry-Me@users.noreply.github.com>
Thu, 20 Oct 2016 00:25:48 +0000 (03:25 +0300)
committerMike McLaughlin <mikem@microsoft.com>
Thu, 20 Oct 2016 00:25:48 +0000 (17:25 -0700)
Commit migrated from https://github.com/dotnet/coreclr/commit/0e798126fc5c5d5cf045530c73d296e5aacc8b5d

src/coreclr/src/debug/di/process.cpp

index a842220..a5496ee 100644 (file)
@@ -8120,7 +8120,9 @@ void CordbProcess::DispatchUnmanagedInBandEvent()
             break;
 
         // Get the thread for this event
+        _ASSERTE(pUnmanagedThread == NULL);
         pUnmanagedThread = pUnmanagedEvent->m_owner;
+        _ASSERTE(pUnmanagedThread != NULL);
 
         // We better not have dispatched it yet!
         _ASSERTE(!pUnmanagedEvent->IsDispatched());
@@ -8178,13 +8180,10 @@ void CordbProcess::DispatchUnmanagedInBandEvent()
         m_pShim->GetWin32EventThread()->DoDbgContinue(this, pUnmanagedEvent);
 
         // Release our reference to the unmanaged thread that we dispatched
-        if (pUnmanagedThread)
-        {
-            // This event should have been continued long ago...
-            _ASSERTE(!pUnmanagedThread->IBEvent()->IsEventWaitingForContinue());
-            pUnmanagedThread->InternalRelease();
-            pUnmanagedThread = NULL;
-        }
+        // This event should have been continued long ago...
+        _ASSERTE(!pUnmanagedThread->IBEvent()->IsEventWaitingForContinue());
+        pUnmanagedThread->InternalRelease();
+        pUnmanagedThread = NULL;
     }
 
     m_dispatchingUnmanagedEvent = false;