media: cx23885: Add some missing register documentation
authorBrad Love <brad@nextdimension.cc>
Tue, 8 May 2018 21:20:20 +0000 (17:20 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 11 May 2018 15:29:53 +0000 (11:29 -0400)
Document what these two register calls are doing.

Signed-off-by: Brad Love <brad@nextdimension.cc>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/cx23885/cx23885-core.c

index 11a1dce..94b996f 100644 (file)
@@ -1464,8 +1464,15 @@ int cx23885_start_dma(struct cx23885_tsport *port,
                reg = reg | 0xa;
                cx_write(PAD_CTRL, reg);
 
-               /* FIXME and these two registers should be documented. */
+               /* Sets MOE_CLK_DIS to disable MoE clock */
+               /* sets MCLK_DLY_SEL/BCLK_DLY_SEL to 1 buffer delay each */
                cx_write(CLK_DELAY, cx_read(CLK_DELAY) | 0x80000011);
+
+               /* ALT_GPIO_ALT_SET: GPIO[0]
+                * IR_ALT_TX_SEL: GPIO[1]
+                * GPIO1_ALT_SEL: VIP_656_DATA[0]
+                * GPIO0_ALT_SEL: VIP_656_CLK
+                */
                cx_write(ALT_PIN_OUT_SEL, 0x10100045);
        }