xilinx: common: Optimise updating ethaddr from eeprom
authorAshok Reddy Soma <ashok.reddy.soma@xilinx.com>
Wed, 23 Feb 2022 14:00:58 +0000 (15:00 +0100)
committerMichal Simek <michal.simek@xilinx.com>
Mon, 7 Mar 2022 07:48:21 +0000 (08:48 +0100)
In board_late_init_xilinx() eth*addr are updated from the values read from
eeprom. Ideally the MAC addresses are updated sequencially. So if any
MAC address is invalid, it means there are no further valid values.
So optimise this logic by replacing continue with break.

Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/efef0d07add5d5777396ea111ad75411dc402db3.1645624855.git.michal.simek@xilinx.com
board/xilinx/common/board.c

index 0068cb8..db089c4 100644 (file)
@@ -416,7 +416,7 @@ int board_late_init_xilinx(void)
 
                        for (i = 0; i < EEPROM_HDR_NO_OF_MAC_ADDR; i++) {
                                if (!desc->mac_addr[i])
-                                       continue;
+                                       break;
 
                                if (is_valid_ethaddr((const u8 *)desc->mac_addr[i]))
                                        ret |= eth_env_set_enetaddr_by_index("eth",