clocksource/drivers/timer-imx-gpt: Fix potential memory leak

[ Upstream commit 8051a993ce222a5158bccc6ac22ace9253dd71cb ]

Fix coverity Issue CID 250382:  Resource leak (RESOURCE_LEAK).
Add kfree when error return.

Signed-off-by: Jacky Bai <ping.bai@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20231009083922.1942971-1-ping.bai@nxp.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
index 7b2c70f2f353bba9b3e8fd5a4810070da26a1f65..fabff69e52e589b9932e83fedc637fed7d2368bb 100644 (file)
--- a/drivers/clocksource/timer-imx-gpt.c
+++ b/drivers/clocksource/timer-imx-gpt.c
@@ -454,12 +454,16 @@ static int __init mxc_timer_init_dt(struct device_node *np,  enum imx_gpt_type t
                return -ENOMEM;
 
        imxtm->base = of_iomap(np, 0);
-       if (!imxtm->base)
-               return -ENXIO;
+       if (!imxtm->base) {
+               ret = -ENXIO;
+               goto err_kfree;
+       }
 
        imxtm->irq = irq_of_parse_and_map(np, 0);
-       if (imxtm->irq <= 0)
-               return -EINVAL;
+       if (imxtm->irq <= 0) {
+               ret = -EINVAL;
+               goto err_kfree;
+       }
 
        imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");
 
@@ -472,11 +476,15 @@ static int __init mxc_timer_init_dt(struct device_node *np,  enum imx_gpt_type t
 
        ret = _mxc_timer_init(imxtm);
        if (ret)
-               return ret;
+               goto err_kfree;
 
        initialized = 1;
 
        return 0;
+
+err_kfree:
+       kfree(imxtm);
+       return ret;
 }
 
 static int __init imx1_timer_init_dt(struct device_node *np)