ecore-wl2: Fix issue where hash would not get destroyed on error
authorChris Michael <cpmichael@osg.samsung.com>
Thu, 30 Jun 2016 15:14:40 +0000 (11:14 -0400)
committerChris Michael <cpmichael@osg.samsung.com>
Thu, 30 Jun 2016 15:14:40 +0000 (11:14 -0400)
Coverity reports that we could not reach the eina_hash_free here on
erorr condition. This was due to an erroneous return NULL above the if
(hash_create) check.

Fixes Coverity CID1357171

@fix

Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
src/lib/ecore_wl2/ecore_wl2_display.c

index cdc859c..0df55f5 100644 (file)
@@ -695,7 +695,6 @@ connect_err:
    eina_hash_free(ewd->globals);
    free(ewd->name);
    free(ewd);
-   return NULL;
 
    if (hash_create)
      {