Fixed issues reported in Klockwork run
Change-Id: Icc1fb0d2d0e3aa9662fa50e17d2d821e8407c4a4
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5663
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
message->remoteEndpoint->addr,
0);
+ if (!remoteEndpoint)
+ {
+ OIC_LOG(ERROR, EDR_ADAPTER_TAG, "remoteEndpoint is NULL");
+ return;
+ }
+
OIC_LOG(DEBUG, EDR_ADAPTER_TAG, "Sending data up !");
const CASecureEndpoint_t sep = { .endpoint = *remoteEndpoint };
return res;
}
}
+ else
+ {
+ CADestroyBlockID(blockDataID);
+ return CA_STATUS_FAILED;
+ }
}
else
{
token = data->sentData->responseInfo->info.token;
}
+ if (!data->sentData->remoteEndpoint)
+ {
+ OIC_LOG(ERROR, TAG, "remoteEndpoint is null");
+ CADestroyDataSet(data->sentData);
+ OICFree(data);
+ return NULL;
+ }
+
CABlockDataID_t* blockDataID = CACreateBlockDatablockId(
token, tokenLength,
data->sentData->remoteEndpoint->port);
if (resSize == 0)
{
+ OICFree(tempInfo);
+ OICFree(tempSize);
if (res == CA_ADAPTER_NOT_ENABLED || res == CA_NOT_SUPPORTED)
{
- OICFree(tempInfo);
- OICFree(tempSize);
return res;
}
- return CA_STATUS_FAILED;
+ else
+ {
+ return CA_STATUS_FAILED;
+ }
}
// #3. add data into result
for (nh = (struct nlmsghdr *)buf; NLMSG_OK(nh, len); nh = NLMSG_NEXT(nh, len))
{
- if (nh->nlmsg_type != RTM_NEWLINK)
+ if (nh != NULL && nh->nlmsg_type != RTM_NEWLINK)
{
continue;
}