mesa: remove GL_UNSIGNED_BYTE as supported for snorm reads
authorTapani Pälli <tapani.palli@intel.com>
Thu, 10 Aug 2023 05:07:29 +0000 (08:07 +0300)
committerMarge Bot <emma+marge@anholt.net>
Fri, 1 Sep 2023 10:37:43 +0000 (10:37 +0000)
UNSIGNED_BYTE should not be allowed for reading snorm color buffers.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9718
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24600>

src/mesa/main/readpix.c

index 9978884..d60159c 100644 (file)
@@ -968,15 +968,6 @@ read_pixels_es3_error_check(struct gl_context *ctx, GLenum format, GLenum type,
                return GL_NO_ERROR;
          }
       }
-      if (type == GL_UNSIGNED_BYTE) {
-         switch (internalFormat) {
-         case GL_R8_SNORM:
-         case GL_RG8_SNORM:
-         case GL_RGBA8_SNORM:
-            if (_mesa_has_EXT_render_snorm(ctx))
-               return GL_NO_ERROR;
-         }
-      }
       break;
    case GL_BGRA:
       /* GL_EXT_read_format_bgra */