mailbox: mediatek: Remove redundant error printing in cmdq_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 11:35:58 +0000 (19:35 +0800)
committerJassi Brar <jaswinder.singh@linaro.org>
Sat, 26 Jun 2021 16:37:51 +0000 (11:37 -0500)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mtk-cmdq-mailbox.c

index 5665b6e..3900ea6 100644 (file)
@@ -519,10 +519,8 @@ static int cmdq_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        cmdq->base = devm_ioremap_resource(dev, res);
-       if (IS_ERR(cmdq->base)) {
-               dev_err(dev, "failed to ioremap gce\n");
+       if (IS_ERR(cmdq->base))
                return PTR_ERR(cmdq->base);
-       }
 
        cmdq->irq = platform_get_irq(pdev, 0);
        if (cmdq->irq < 0)