evdev: Drop joystick rejection heurstics
authorKristian Høgsberg <krh@bitplanet.net>
Mon, 16 Dec 2013 23:57:53 +0000 (15:57 -0800)
committerJonas Ådahl <jadahl@gmail.com>
Sat, 21 Dec 2013 11:54:27 +0000 (12:54 +0100)
We now no longer add joysticks at all.  They show up as absolute motion
devices without has_button, so we don't add them as a pointer.  We may add
a keyboard for the keyboard-style keys, but that's fine.  With the previous
commit, we no longer generate spurious absolute pointer motion for the abs
axes.

https://bugs.freedesktop.org/show_bug.cgi?id=71687

src/evdev.c

index 0f6ae1c..8ee8a16 100644 (file)
@@ -489,14 +489,6 @@ evdev_configure_device(struct evdev_device *device)
                ioctl(device->fd, EVIOCGBIT(EV_ABS, sizeof(abs_bits)),
                      abs_bits);
 
-               if (TEST_BIT(abs_bits, ABS_WHEEL) ||
-                   TEST_BIT(abs_bits, ABS_GAS) ||
-                   TEST_BIT(abs_bits, ABS_BRAKE) ||
-                   TEST_BIT(abs_bits, ABS_HAT0X)) {
-                       /* Device %s is a joystick, ignoring. */
-                       return 0;
-               }
-
                if (TEST_BIT(abs_bits, ABS_X)) {
                        ioctl(device->fd, EVIOCGABS(ABS_X), &absinfo);
                        device->abs.min_x = absinfo.minimum;