mtd: rawnand: Avoid accessing NV-DDR timings from legacy code
authorMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 5 May 2021 21:37:40 +0000 (23:37 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 26 May 2021 08:43:52 +0000 (10:43 +0200)
Legacy code should not benefit from newer features, especially in
helpers that have been deprecated for a very long time. People who want
NV-DDR support must migrate their driver to the ->exec_op() API.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210505213750.257417-13-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/nand_legacy.c

index eccc18b..743792e 100644 (file)
@@ -369,7 +369,7 @@ static void nand_ccs_delay(struct nand_chip *chip)
         * Wait tCCS_min if it is correctly defined, otherwise wait 500ns
         * (which should be safe for all NANDs).
         */
-       if (nand_controller_can_setup_interface(chip))
+       if (!IS_ERR(sdr) && nand_controller_can_setup_interface(chip))
                ndelay(sdr->tCCS_min / 1000);
        else
                ndelay(500);