Fix coverity issue: declaration hides parameter 69/224869/1
authorhimanshu <h.himanshu@samsung.com>
Thu, 13 Feb 2020 13:44:58 +0000 (19:14 +0530)
committerhimanshu <h.himanshu@samsung.com>
Thu, 13 Feb 2020 13:44:58 +0000 (19:14 +0530)
The data used in the BT_UNIT_TEST_FUNCTION_ADAPTER_READ_BATTERY_INFO
test case conflicts with the declared parameter "data" in the
test_input_callback function.

Change-Id: I51f80732880b631995c4fa3bc52ae390d13d8fc2
Signed-off-by: himanshu <h.himanshu@samsung.com>
test/bt_unit_test.c

index b7e6a48..916d08a 100644 (file)
@@ -4374,21 +4374,21 @@ int test_input_callback(void *data)
                        break;
                }
                case BT_UNIT_TEST_FUNCTION_ADAPTER_READ_BATTERY_INFO: {
-                       bt_battery_info_s data;
-                       memset(&data, 0, sizeof(bt_battery_info_s));
-                        ret = bt_adapter_read_battery_info(&data);
+                       bt_battery_info_s battery_data;
+                       memset(&battery_data, 0, sizeof(bt_battery_info_s));
+                        ret = bt_adapter_read_battery_info(&battery_data);
                        if (ret < 0) {
                                TC_PRT("returns %s\n", __bt_get_error_message(ret));
                        } else {
-                               TC_PRT("Battery data: %ld %ld %d %d", data.session_start_time,
-                                       data.session_end_time, data.session_scan_time, data.session_connected_time);
-                               if(data.atm_list == NULL) {
+                               TC_PRT("Battery data: %ld %ld %d %d", battery_data.session_start_time,
+                                       battery_data.session_end_time, battery_data.session_scan_time, battery_data.session_connected_time);
+                               if(battery_data.atm_list == NULL) {
                                        TC_PRT("No data transaction in this session");
                                        break;
                                }
 
                                TC_PRT("Displaying app-wise transaction details");
-                               for (GSList *l = data.atm_list; l != NULL; l = g_slist_next(l)) {
+                               for (GSList *l = battery_data.atm_list; l != NULL; l = g_slist_next(l)) {
                                        bt_battery_app_info_s *t = (bt_battery_app_info_s *)(l->data);
                                        TC_PRT("uid: %ld, pid: %ld, received bytes: %d, sent bytes: %d, time: %u",
                                                (long int)(t->uid), (long int)(t->pid), t->rx_bytes, t->tx_bytes, t->time);