[TIC-UI] performance improvement

- fix the reference algorithm

Signed-off-by: ChangHyun Lee <leechwin.lee@samsung.com>
Change-Id: Iad47bb5f9cbc87ad6e226bd2026fa45c8ed15cf0

diff --git a/public/src/index.html b/public/src/index.html
index 4066490..66c5698 100644 (file)
--- a/public/src/index.html
+++ b/public/src/index.html
@@ -5,7 +5,7 @@
         <meta http-equiv="X-UA-Compatible" content="IE=edge">
         <meta name="viewport" content="width=device-width, initial-scale=1.0">
 
-        <title>Tizen Image Configurator</title>
+        <title>Tizen Image Creator (TIC)</title>
 
         <link rel="shortcut icon" href="/image/tizen.ico">
         <link rel="stylesheet" href="/lib/bootstrap/css/bootstrap.css">
@@ -31,7 +31,7 @@
                         <span class="icon-bar"></span>
                         <span class="icon-bar"></span>
                     </button>
-                    <a class="navbar-brand tic-page-scroll" href="#tic-package-section"><img id="tic-brand-img" src="image/tizen_32.png"/> Tizen Image Configurator</a>
+                    <a class="navbar-brand tic-page-scroll" href="#tic-package-section"><img id="tic-brand-img" src="image/tizen_32.png"/> Tizen Image Creator (TIC)</a>
                 </div>
 
                 <!-- Collect the nav links, forms, and other content for toggling -->

diff --git a/public/src/js/page/package.js b/public/src/js/page/package.js
index 2b67f13..dd7491f 100644 (file)
--- a/public/src/js/page/package.js
+++ b/public/src/js/page/package.js
@@ -136,8 +136,8 @@ define([
         localNode.state.checked = true;
 
         var toggleNode = [];
-        if (!_.isEmpty(localNode.dependency) && localNode.dependency.length > 0) {
-            _.forEach(localNode.dependency, function(name) {
+        if (!_.isEmpty(localNode.dependency)) {
+            _.forEach(localNode.dependency, function(name) { // FIXME: Performance
                 var depNode = _find(name);
                 if (_.isEmpty(depNode)) {
                     Util.showAlertDialog('Can not find dependency package. \'' + name + '\'');
@@ -171,14 +171,12 @@ define([
 
         // TODO: Refactoring
         var localNode = _find(node.text);
-        var checkedData = _getChecked();
 
         // check reference node
         var checkedRefNode = [];
         if (!_.isEmpty(localNode.reference)) {
-            _.forEach(localNode.reference, function(name) {
-                var refNode = _find(name, checkedData);
-                if (!_.isEmpty(refNode) && !_.isEqual(refNode.text, localNode.text) && refNode.selfChecked === true) {
+            _.forEach(localNode.reference, function(refNode) {
+                if (refNode.state.checked === true && !_.isEqual(refNode.text, localNode.text) && refNode.selfChecked === true) {
                     checkedRefNode.push(refNode);
                 }
             });
@@ -196,8 +194,8 @@ define([
 
         // check dependency node
         var toggleNode = [];
-        if (!_.isEmpty(localNode.dependency) && localNode.dependency.length > 0 && localNode.selfChecked === true) {
-            _.forEach(localNode.dependency, function(name) {
+        if (!_.isEmpty(localNode.dependency) && localNode.selfChecked === true) {
+            _.forEach(localNode.dependency, function(name) { // FIXME: Performance
                 var depNode = _find(name);
                 if (!_.isEqual(localNode.text, depNode.text)) {
                     if (depNode.state.checked === true) {
@@ -215,8 +213,7 @@ define([
             _.forEach(toggleNode, function(node) {
                 if (!_.isEmpty(node.reference)) {
                     checkedRefNode2.push(node);
-                    _.forEach(node.reference, function(name) {
-                        var refNode = _find(name);
+                    _.forEach(node.reference, function(refNode) {
                         if (!_.isEqual(refNode.text, node.text) && !_.isEqual(refNode.text, localNode.text)) {
                             if (refNode.state.checked === true && refNode.selfChecked === true) {
                                 checkedRefNode2.pop();
@@ -250,14 +247,14 @@ define([
             function _onRendered(event, nodes) {
                 packages = _.uniqBy(_.values(nodes), 'text');
                 _.forEach(packages, function(node) {
-                    _.forEach(node.dependency, function(name) {
+                    _.forEach(node.dependency, function(name) { // FIXME: Performance
                         var depNode = _.find(packages, {'text' : name});
                         depNode.selfChecked = false;
                         if (_.isEmpty(depNode.reference)) {
                             depNode.reference = [];
                         }
                         if (!_.isEqual(depNode.text, node.text)) {
-                            depNode.reference.push(node.text);
+                            depNode.reference.push(node);
                         }
                     });
                 });
@@ -275,6 +272,7 @@ define([
                 $('#tic-package-info-summary').empty();
                 $('#tic-package-info-description').empty();
                 $('#tic-package-info-dependency').empty();
+                $('#tic-package-info-dependency-badge').empty();
             }
 
             $tree.treeview({