projects / platform / upstream / mesa.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 1ede7c0)
zink: prune some validation errors from ci
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Wed, 26 Apr 2023 14:22:36 +0000 (10:22 -0400)
committerMarge Bot <emma+marge@anholt.net>
Wed, 26 Apr 2023 19:37:58 +0000 (19:37 +0000)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22715>

src/gallium/drivers/zink/ci/zink-anv-tgl-validation-settings.txt patch | blob | history
src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt patch | blob | history

diff --git a/src/gallium/drivers/zink/ci/zink-anv-tgl-validation-settings.txt b/src/gallium/drivers/zink/ci/zink-anv-tgl-validation-settings.txt
index 6a64eda..9c12fa3 100644 (file)
--- a/src/gallium/drivers/zink/ci/zink-anv-tgl-validation-settings.txt
+++ b/src/gallium/drivers/zink/ci/zink-anv-tgl-validation-settings.txt
@@ -1,6 +1,6 @@
 # Please include a comment with the log message and a testcase triggering each
 # VUID at the bottom of the file.
-khronos_validation.message_id_filter = UNASSIGNED-CoreValidation-Shader-InconsistentSpirv,VUID-vkDestroyDevice-device-00378,VUID-VkShaderModuleCreateInfo-pCode-01377,VUID-vkCmdDrawMultiIndexedEXT-None-02699,VUID-RuntimeSpirv-Location-06272,VUID-VkGraphicsPipelineCreateInfo-renderPass-06590,VUID-VkGraphicsPipelineCreateInfo-Geometry-07725,VUID-vkCmdDrawMultiIndexedEXT-format-07753,UNASSIGNED-CoreValidation-Shader-InterfaceTypeMismatch,VUID-RuntimeSpirv-OpEntryPoint-07754,VUID-VkShaderModuleCreateInfo-pCode-01379,VUID-RuntimeSpirv-OpEntryPoint-08743
+khronos_validation.message_id_filter = UNASSIGNED-CoreValidation-Shader-InconsistentSpirv,VUID-vkDestroyDevice-device-00378,VUID-VkShaderModuleCreateInfo-pCode-01377,VUID-RuntimeSpirv-Location-06272,VUID-VkGraphicsPipelineCreateInfo-renderPass-06590,VUID-VkGraphicsPipelineCreateInfo-Geometry-07725,VUID-vkCmdDrawMultiIndexedEXT-format-07753,UNASSIGNED-CoreValidation-Shader-InterfaceTypeMismatch,VUID-RuntimeSpirv-OpEntryPoint-07754,VUID-VkShaderModuleCreateInfo-pCode-01379,VUID-RuntimeSpirv-OpEntryPoint-08743
 khronos_validation.report_flags = error
 khronos_validation.debug_action = VK_DBG_LAYER_ACTION_LOG_MSG,VK_DBG_LAYER_ACTION_BREAK
 VK_LAYER_ENABLES=VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT
@@ -29,19 +29,6 @@ khronos_validation.log_filename = stdout
 #   %142 = OpVectorShuffle %v2uint %141 %141 0 1
 #  The Vulkan spec states: pCode must point to either valid SPIR-V code, formatted and packed as described by the Khronos SPIR-V Specification or valid GLSL code which must be written to the GL_KHR_vulkan_glsl extension specification (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-01377)
 
-# KHR-GL46.sample_variables.position.fixed.samples_0:
-# [ VUID-vkCmdDrawMultiIndexedEXT-None-02699 ] Object 0: handle =
-# 0x535b660000000043, type = VK_OBJECT_TYPE_DESCRIPTOR_SET; | MessageID =
-# 0xc5b20f4e | vkCmdDrawMultiIndexedEXT: Descriptor set VkDescriptorSet
-# 0x535b660000000043[] in binding #129 index 0 requires bound image to have
-# multiple samples, but got VK_SAMPLE_COUNT_1_BIT. The Vulkan spec states:
-# Descriptors in each bound descriptor set, specified via vkCmdBindDescriptorSets,
-# must be valid as described by descriptor validity if they are statically used by
-# the VkPipeline bound to the pipeline bind point used by this command
-# (https://github.com/KhronosGroup/Vulkan-Docs/search?q=)VUID-vkCmdDrawMultiIndexedEXT-None-02699)
-#
-# https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22492
-
 # KHR-GL46.geometry_shader.limits.max_output_components
 # [ VUID-RuntimeSpirv-Location-06272 ] Object 0: handle = 0x3a6cbb0000000025,
 # type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0xa3614f8b | Invalid Pipeline
diff --git a/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt b/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt
index 1dce929..a3f52e2 100644 (file)
--- a/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt
+++ b/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt
@@ -1,6 +1,6 @@
 # Please include a comment with the log message and a testcase triggering each
 # VUID at the bottom of the file.
-khronos_validation.message_id_filter = VUID-vkCmdDrawMultiEXT-colorAttachmentCount-06188,VUID-VkGraphicsPipelineCreateInfo-Geometry-07725,VUID-VkShaderModuleCreateInfo-pCode-01091,VUID-vkCmdCopyImage-srcImage-07743,VUID-RuntimeSpirv-Location-06272,VUID-vkCmdDrawMultiEXT-None-02699,VUID-VkPhysicalDeviceProperties2-pNext-pNext,VUID-VkDeviceCreateInfo-pNext-pNext,VUID-VkShaderModuleCreateInfo-pCode-01091,VUID-VkShaderModuleCreateInfo-pCode-08740,VUID-RuntimeSpirv-OpEntryPoint-08743
+khronos_validation.message_id_filter = VUID-VkGraphicsPipelineCreateInfo-Geometry-07725,VUID-VkShaderModuleCreateInfo-pCode-01091,VUID-vkCmdCopyImage-srcImage-07743,VUID-RuntimeSpirv-Location-06272,VUID-vkCmdDrawMultiEXT-None-02699,VUID-VkPhysicalDeviceProperties2-pNext-pNext,VUID-VkDeviceCreateInfo-pNext-pNext,VUID-VkShaderModuleCreateInfo-pCode-01091,VUID-VkShaderModuleCreateInfo-pCode-08740,VUID-RuntimeSpirv-OpEntryPoint-08743
 khronos_validation.report_flags = error
 khronos_validation.debug_action = VK_DBG_LAYER_ACTION_LOG_MSG,VK_DBG_LAYER_ACTION_BREAK
 VK_LAYER_ENABLES=VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT
@@ -8,29 +8,6 @@ khronos_validation.printf_buffer_size = 40960
 khronos_validation.printf_to_stdout = true
 khronos_validation.log_filename = stdout
 
-# caselist of :
-#   dEQP-GLES31.functional.shaders.helper_invocation.value.triangles
-#   dEQP-GLES31.functional.shaders.helper_invocation.value.wide_points_4_samples
-#
-# [VUID-vkCmdDrawMultiEXT-colorAttachmentCount-06188 ] Object 0: handle
-# = 0x56444e83ff20, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID =
-# 0x3d2cdcc3 | vkCmdDrawMultiEXT: Color attachment (0) sample count
-# (VK_SAMPLE_COUNT_4_BIT) must match corresponding
-# VkPipelineMultisampleStateCreateInfo sample count
-# (VK_SAMPLE_COUNT_1_BIT) The Vulkan spec states: If the currently
-# bound pipeline was created without a VkAttachmentSampleCountInfoAMD
-# or VkAttachmentSampleCountInfoNV structure, and the current render
-# pass instance was begun with vkCmdBeginRendering with a
-# VkRenderingInfo::colorAttachmentCount parameter greater than 0, then
-# each element of the VkRenderingInfo::pColorAttachments array with a
-# imageView not equal to VK_NULL_HANDLE must have been created with a
-# sample count equal to the value of
-# VkPipelineMultisampleStateCreateInfo::rasterizationSamples used to
-# create the currently bound graphics pipeline
-# (https://github.com/KhronosGroup/Vulkan-Docs/search?q=)VUID-vkCmdDrawMultiEXT-colorAttachmentCount-06188)
-#
-# https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/5136
-
 # dEQP-GLES31.functional.geometry_shading.emit.points_emit_0_end_1:
 #
 # [ VUID-VkGraphicsPipelineCreateInfo-Geometry-07725 ] Object 0: handle =
Domain: Graphics System / GL;