Bluetooth: hci_qca: Fix suspend/resume functionality failure
authorZijun Hu <zijuhu@codeaurora.org>
Thu, 28 May 2020 20:31:07 +0000 (04:31 +0800)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 29 May 2020 11:38:19 +0000 (13:38 +0200)
@dev parameter of qca_suspend()/qca_resume() represents
serdev_device, but it is mistook for hci_dev and causes
succedent unexpected memory access.

Fix by taking @dev as serdev_device.

Fixes: 41d5b25fed0 ("Bluetooth: hci_qca: add PM support")
Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_qca.c

index e4a6823..adcbe00 100644 (file)
@@ -1977,8 +1977,9 @@ static void qca_serdev_remove(struct serdev_device *serdev)
 
 static int __maybe_unused qca_suspend(struct device *dev)
 {
-       struct hci_dev *hdev = container_of(dev, struct hci_dev, dev);
-       struct hci_uart *hu = hci_get_drvdata(hdev);
+       struct serdev_device *serdev = to_serdev_device(dev);
+       struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
+       struct hci_uart *hu = &qcadev->serdev_hu;
        struct qca_data *qca = hu->priv;
        unsigned long flags;
        int ret = 0;
@@ -2057,8 +2058,9 @@ error:
 
 static int __maybe_unused qca_resume(struct device *dev)
 {
-       struct hci_dev *hdev = container_of(dev, struct hci_dev, dev);
-       struct hci_uart *hu = hci_get_drvdata(hdev);
+       struct serdev_device *serdev = to_serdev_device(dev);
+       struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
+       struct hci_uart *hu = &qcadev->serdev_hu;
        struct qca_data *qca = hu->priv;
 
        clear_bit(QCA_SUSPENDING, &qca->flags);