crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 21 Oct 2019 14:51:45 +0000 (16:51 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 25 Oct 2019 15:09:59 +0000 (02:09 +1100)
Variables of type atomic{,64}_t can be used fine with
debugfs_create_u{32,64}, when passing a pointer to the embedded counter.
This allows to get rid of the casts, which prevented compiler checks.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/nx/nx_debugfs.c

index e0d44a5..1975bcb 100644 (file)
@@ -38,23 +38,23 @@ void nx_debugfs_init(struct nx_crypto_driver *drv)
        drv->dfs_root = root;
 
        debugfs_create_u32("aes_ops", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u32 *)&drv->stats.aes_ops);
+                          root, &drv->stats.aes_ops.counter);
        debugfs_create_u32("sha256_ops", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u32 *)&drv->stats.sha256_ops);
+                          root, &drv->stats.sha256_ops.counter);
        debugfs_create_u32("sha512_ops", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u32 *)&drv->stats.sha512_ops);
+                          root, &drv->stats.sha512_ops.counter);
        debugfs_create_u64("aes_bytes", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u64 *)&drv->stats.aes_bytes);
+                          root, &drv->stats.aes_bytes.counter);
        debugfs_create_u64("sha256_bytes", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u64 *)&drv->stats.sha256_bytes);
+                          root, &drv->stats.sha256_bytes.counter);
        debugfs_create_u64("sha512_bytes", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u64 *)&drv->stats.sha512_bytes);
+                          root, &drv->stats.sha512_bytes.counter);
        debugfs_create_u32("errors", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u32 *)&drv->stats.errors);
+                          root, &drv->stats.errors.counter);
        debugfs_create_u32("last_error", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u32 *)&drv->stats.last_error);
+                          root, &drv->stats.last_error.counter);
        debugfs_create_u32("last_error_pid", S_IRUSR | S_IRGRP | S_IROTH,
-                          root, (u32 *)&drv->stats.last_error_pid);
+                          root, &drv->stats.last_error_pid.counter);
 }
 
 void