f2fs: allow copying file range only in between regular files
authorChao Yu <yuchao0@huawei.com>
Thu, 4 Aug 2016 12:13:02 +0000 (20:13 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 19 Aug 2016 02:15:08 +0000 (11:15 +0900)
Only if two input files are regular files, we allow copying data in
range of them, otherwise, deny it.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c

index 0e493f6..685e629 100644 (file)
@@ -2086,8 +2086,8 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
        if (unlikely(f2fs_readonly(src->i_sb)))
                return -EROFS;
 
-       if (S_ISDIR(src->i_mode) || S_ISDIR(dst->i_mode))
-               return -EISDIR;
+       if (!S_ISREG(src->i_mode) || !S_ISREG(dst->i_mode))
+               return -EINVAL;
 
        if (f2fs_encrypted_inode(src) || f2fs_encrypted_inode(dst))
                return -EOPNOTSUPP;